[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5788: [TE] Error handling refactor of EntityManagerResource

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #5788:
URL: https://github.com/apache/incubator-pinot/pull/5788#discussion_r464136771



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/BadRequestWebException.java
##########
@@ -0,0 +1,29 @@
+package org.apache.pinot.thirdeye.dashboard.resources;
+
+import javax.ws.rs.WebApplicationException;
+import javax.ws.rs.core.MediaType;
+import javax.ws.rs.core.Response;
+import javax.ws.rs.core.Response.Status;
+
+public class BadRequestWebException extends WebApplicationException {

Review comment:
       javadocs

##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/ResourceUtils.java
##########
@@ -0,0 +1,19 @@
+package org.apache.pinot.thirdeye.dashboard.resources;
+
+public class ResourceUtils {

Review comment:
       consider including some javadocs for this utility class

##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/BadRequestWebException.java
##########
@@ -0,0 +1,29 @@
+package org.apache.pinot.thirdeye.dashboard.resources;

Review comment:
       can you copy over and include the license header on new files.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org