You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/12/12 09:34:38 UTC
[GitHub] [incubator-hugegraph-toolchain] imbajin opened a new pull request, #399: refact: enhance root pom & sub-modules settings
imbajin opened a new pull request, #399:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/399
Just Test Now, **will not merged** in v1.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] codecov[bot] commented on pull request #399: refact: enhance root pom & sub-modules settings
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #399:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/399#issuecomment-1346179629
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#399](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (675e7f4) into [master](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/commit/1c47673eb9511d3eff0d0901012a69d7a0148cdc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c47673) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #399 +/- ##
============================================
- Coverage 62.55% 62.52% -0.03%
+ Complexity 1866 972 -894
============================================
Files 260 169 -91
Lines 9405 5022 -4383
Branches 872 357 -515
============================================
- Hits 5883 3140 -2743
+ Misses 3140 1703 -1437
+ Partials 382 179 -203
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/hugegraph/loader/struct/EdgeStructV1.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9zdHJ1Y3QvRWRnZVN0cnVjdFYxLmphdmE=) | | |
| [...a/org/apache/hugegraph/loader/HugeGraphLoader.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9IdWdlR3JhcGhMb2FkZXIuamF2YQ==) | | |
| [...e/hugegraph/loader/source/hdfs/KerberosConfig.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9zb3VyY2UvaGRmcy9LZXJiZXJvc0NvbmZpZy5qYXZh) | | |
| [...org/apache/hugegraph/loader/source/SourceType.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9zb3VyY2UvU291cmNlVHlwZS5qYXZh) | | |
| [...g/apache/hugegraph/loader/metrics/RangesTimer.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9tZXRyaWNzL1Jhbmdlc1RpbWVyLmphdmE=) | | |
| [...rg/apache/hugegraph/loader/reader/InputReader.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9yZWFkZXIvSW5wdXRSZWFkZXIuamF2YQ==) | | |
| [...g/apache/hugegraph/loader/builder/EdgeBuilder.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9idWlsZGVyL0VkZ2VCdWlsZGVyLmphdmE=) | | |
| [...apache/hugegraph/loader/builder/VertexBuilder.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9idWlsZGVyL1ZlcnRleEJ1aWxkZXIuamF2YQ==) | | |
| [...ugegraph/loader/metrics/LoadDistributeMetrics.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9tZXRyaWNzL0xvYWREaXN0cmlidXRlTWV0cmljcy5qYXZh) | | |
| [...che/hugegraph/loader/mapping/BackendStoreInfo.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVnZWdyYXBoL2xvYWRlci9tYXBwaW5nL0JhY2tlbmRTdG9yZUluZm8uamF2YQ==) | | |
| ... and [81 more](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/399/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on pull request #399: refact: enhance root pom & sub-modules settings
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #399:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/399#issuecomment-1712755775
> Is it still in progress?
@conghuhu could address this PR when free? (maybe some of them included it in #478 already?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-toolchain] github-actions[bot] commented on pull request #399: refact: enhance root pom & sub-modules settings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #399:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/399#issuecomment-1382916641
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refact: enhance root pom & sub-modules settings [hugegraph-toolchain]
Posted by "bitflicker64 (via GitHub)" <gi...@apache.org>.
bitflicker64 commented on code in PR #399:
URL: https://github.com/apache/hugegraph-toolchain/pull/399#discussion_r4267203293
##########
pom.xml:
##########
@@ -83,93 +116,106 @@
<docker.repo>${project.name}</docker.repo>
<docker.tag>${project.version}</docker.tag>
<hbase.version>2.2.3</hbase.version>
+ <hugegraph.common.version>1.0.0</hugegraph.common.version>
</properties>
- <dependencies>
- <!--TODO: enhance it later to avoid conflicts now -->
-<!-- <dependency>-->
-<!-- <groupId>commons-io</groupId>-->
-<!-- <artifactId>commons-io</artifactId>-->
-<!-- <version>2.7</version>-->
-<!-- </dependency>-->
-<!-- <dependency>-->
-<!-- <groupId>org.apache.commons</groupId>-->
-<!-- <artifactId>commons-lang3</artifactId>-->
-<!-- <version>3.9</version>-->
-<!-- </dependency>-->
-<!-- <dependency>-->
-<!-- <groupId>com.google.guava</groupId>-->
-<!-- <artifactId>guava</artifactId>-->
-<!-- <version>29.0-jre</version>-->
-<!-- </dependency>-->
-<!-- <dependency>-->
-<!-- <groupId>org.apache.commons</groupId>-->
-<!-- <artifactId>commons-compress</artifactId>-->
-<!-- <version>1.21</version>-->
-<!-- </dependency>-->
- </dependencies>
+ <!-- Note: dependencies won't be imported in root & won't be inherited by default,
+ just defined for submodules (more flexible) -->
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hugegraph</groupId>
+ <artifactId>hugegraph-common</artifactId>
+ <version>${hugegraph.common.version}</version>
+ </dependency>
-<!-- <profiles>-->
-<!-- <profile>-->
-<!-- <id>release</id>-->
-<!-- <build>-->
-<!-- <plugins>-->
-<!-- <plugin>-->
-<!-- <groupId>org.apache.maven.plugins</groupId>-->
-<!-- <artifactId>maven-source-plugin</artifactId>-->
-<!-- <version>2.2.1</version>-->
-<!-- <executions>-->
-<!-- <execution>-->
-<!-- <id>attach-sources</id>-->
-<!-- <goals>-->
-<!-- <goal>jar-no-fork</goal>-->
-<!-- </goals>-->
-<!-- </execution>-->
-<!-- </executions>-->
-<!-- </plugin>-->
-<!-- <plugin>-->
-<!-- <groupId>org.apache.maven.plugins</groupId>-->
-<!-- <artifactId>maven-javadoc-plugin</artifactId>-->
-<!-- <version>2.9.1</version>-->
-<!-- <executions>-->
-<!-- <execution>-->
-<!-- <id>attach-javadocs</id>-->
-<!-- <goals>-->
-<!-- <goal>jar</goal>-->
-<!-- </goals>-->
-<!-- </execution>-->
-<!-- </executions>-->
-<!-- <configuration>-->
-<!-- <additionalJOptions>-->
-<!-- <additionalJOption>-Xdoclint:none</additionalJOption>-->
-<!-- </additionalJOptions>-->
-<!-- </configuration>-->
-<!-- </plugin>-->
-<!-- <plugin>-->
-<!-- <groupId>org.apache.maven.plugins</groupId>-->
-<!-- <artifactId>maven-gpg-plugin</artifactId>-->
-<!-- <version>1.5</version>-->
-<!-- <executions>-->
-<!-- <execution>-->
-<!-- <id>sign-artifacts</id>-->
-<!-- <phase>verify</phase>-->
-<!-- <goals>-->
-<!-- <goal>sign</goal>-->
-<!-- </goals>-->
-<!-- </execution>-->
-<!-- </executions>-->
-<!-- <configuration>-->
-<!-- <!– Prevent `gpg` from using pinentry programs –>-->
-<!-- <gpgArguments>-->
-<!-- <arg>--pinentry-mode</arg>-->
-<!-- <arg>loopback</arg>-->
-<!-- </gpgArguments>-->
-<!-- </configuration>-->
-<!-- </plugin>-->
-<!-- </plugins>-->
-<!-- </build>-->
-<!-- </profile>-->
-<!-- </profiles>-->
+ <!--TODO: enhance it later to avoid conflicts now -->
+ <!-- <dependency>-->
+ <!-- <groupId>commons-io</groupId>-->
+ <!-- <artifactId>commons-io</artifactId>-->
+ <!-- <version>2.7</version>-->
+ <!-- </dependency>-->
+ <!-- <dependency>-->
+ <!-- <groupId>org.apache.commons</groupId>-->
+ <!-- <artifactId>commons-lang3</artifactId>-->
+ <!-- <version>3.9</version>-->
+ <!-- </dependency>-->
+ <!-- <dependency>-->
+ <!-- <groupId>com.google.guava</groupId>-->
+ <!-- <artifactId>guava</artifactId>-->
+ <!-- <version>29.0-jre</version>-->
+ <!-- </dependency>-->
+ <!-- <dependency>-->
+ <!-- <groupId>org.apache.commons</groupId>-->
+ <!-- <artifactId>commons-compress</artifactId>-->
+ <!-- <version>1.21</version>-->
+ <!-- </dependency>-->
+ </dependencies>
+ </dependencyManagement>
+
+ <dependencies> <!-- dependencies will be inherited by default here --></dependencies>
+
+ <profiles>
+ <profile>
+ <id>apache-release</id>
+ <build>
+ <!-- plugins under management won't be executed in root & won't be inherited
+ by default, just defined for submodules (more flexible)
+ refer: https://maven.apache.org/pom.html#Plugin_Management -->
+ <!--<pluginManagement></pluginManagement>-->
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-source-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>attach-sources</id>
+ <goals>
+ <goal>jar-no-fork</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>attach-javadocs</id>
+ <goals>
+ <goal>jar</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <doclint>none</doclint>
+ <failOnError>false</failOnError>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-gpg-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>sign-artifacts</id>
Review Comment:
Important: This adds a second gpg `sign` execution on top of the `sign-release-artifacts` execution that `org.apache:apache:23` already defines in its own `apache-release` profile, so every module is signed twice and the second pass signs the `.asc` files.
Reproduced with a throwaway key: `mvn deploy -Papache-release -pl hugegraph-client -DskipTests -DaltDeploymentRepository=tmp::default::file:///tmp/repo` runs `maven-gpg-plugin:1.6:sign (sign-release-artifacts)` and then `(sign-artifacts)`, logs `jar.asc:1.0.0 already attached, replace previous instance`, and deploys `hugegraph-client-1.0.0.jar.asc.asc`, `pom.asc.asc` and `sources.jar.asc.asc` next to the normal signatures. `help:effective-pom` shows both executions.
Drop this gpg plugin block (the parent profile already signs), or reuse the parent execution id `sign-release-artifacts` if only the pinentry config is needed.
##########
hugegraph-tools/pom.xml:
##########
@@ -240,32 +228,31 @@
</execution>
</executions>
</plugin>
- <plugin>
- <artifactId>maven-clean-plugin</artifactId>
- <version>3.0.0</version>
- <configuration>
- <filesets>
- <fileset>
- <directory>${project.basedir}</directory>
- <includes>
- <include>*.tar.gz</include>
- <include>${final.name}/**</include>
- </includes>
- <followSymlinks>false</followSymlinks>
- </fileset>
- <fileset>
- <directory>${final.name}</directory>
- </fileset>
- </filesets>
- </configuration>
- </plugin>
+<!-- <plugin>-->
+<!-- <artifactId>maven-clean-plugin</artifactId>-->
+<!-- <configuration>-->
+<!-- <filesets>-->
+<!-- <fileset>-->
+<!-- <directory>${project.basedir}</directory>-->
+<!-- <includes>-->
+<!-- <include>*.tar.gz</include>-->
+<!-- <include>${final.name}/**</include>-->
+<!-- </includes>-->
+<!-- <followSymlinks>false</followSymlinks>-->
+<!-- </fileset>-->
+<!-- <fileset>-->
+<!-- <directory>${final.name}</directory>-->
+<!-- </fileset>-->
+<!-- </filesets>-->
+<!-- </configuration>-->
+<!-- </plugin>-->
</plugins>
</build>
<profiles>
<!-- mvn clean install -Prelease -->
<profile>
- <id>release</id>
+ <id>apache-release</id>
Review Comment:
Minor: Renaming this profile to `apache-release` merges it with the parent `apache-release` profile, so tools now builds its sources jar and javadoc jar twice.
`mvn help:effective-pom -Papache-release -pl hugegraph-tools` lists `maven-source-plugin` executions `attach-sources` (jar-no-fork) and `create-source-jar` (jar, test-jar), and `maven-javadoc-plugin` executions `attach-javadocs` and `create-javadoc-jar`. The second one of each re-attaches the same classifier. The `<!-- mvn clean install -Prelease -->` comment above is also stale now.
Remove the `create-source-jar` and `create-javadoc-jar` executions (keep only the test-jar parts if they are needed) and update the comment.
##########
.gitattributes:
##########
@@ -1 +1,15 @@
* text=auto !eol
+
+# ignored file when package to source.tgz
+.gitattributes export-ignore
+.gitignore export-ignore
+.asf.yaml export-ignore
+checkstyle.xml export-ignore
Review Comment:
Important: Excluding `checkstyle.xml` from `git archive` makes the source release produced by `apache-release.sh` unbuildable, because the root pom binds `maven-checkstyle-plugin:check` to `validate` with `<configLocation>checkstyle.xml</configLocation>`.
I extracted `git archive HEAD` (which applies these rules) and ran `mvn -o validate -pl hugegraph-client` in it: `BUILD FAILURE ... Unable to find configuration file at location: checkstyle.xml`. The same command in the git checkout passes. So `mvn package` fails on the first step for anyone building the voted source tarball.
Keep `checkstyle.xml` in the source package (remove this line), or drop the checkstyle execution from the default build first.
##########
hugegraph-dist/scripts/apache-release.sh:
##########
@@ -0,0 +1,100 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+GROUP="hugegraph"
+# current repository name
+REPO="${GROUP}-toolchain"
+# release version (input by committer)
+RELEASE_VERSION=$1
+USERNAME=$2
+PASSWORD=$3
+# git release branch (check it carefully)
+GIT_BRANCH="release-${RELEASE_VERSION}"
+
+RELEASE_VERSION=${RELEASE_VERSION:?"Please input the release version behind script"}
+
+WORK_DIR=$(cd "$(dirname "$0")" || exit; pwd)
+cd "${WORK_DIR}" || exit
+echo "In the work dir: $(pwd)"
+
+# clean old dir then build a new one
+rm -rfv dist && mkdir -p dist/apache-${REPO}
+
+# step1: package the source code
+cd ../../ || exit
+git archive --format=tar.gz \
+ --output="${GROUP}-dist/scripts/dist/apache-${REPO}/apache-${REPO}-incubating-${RELEASE_VERSION}-src.tar.gz" \
+ --prefix="apache-${REPO}-incubating-${RELEASE_VERSION}-src/" "${GIT_BRANCH}" || exit
+
+cd - || exit
+
+# step2: copy the binary file (Optional)
+# Note: it's optional for project to generate binary package (skip this step if not need)
+cp -v ../../target/apache-${REPO}-incubating-"${RELEASE_VERSION}".tar.gz \
+ dist/apache-${REPO} || exit
+
+# step3: sign + hash
+##### 3.1 sign in source & binary package
+gpg --version 1>/dev/null || exit
+cd ./dist/apache-${REPO} || exit
+for i in *.tar.gz; do
+ echo "$i" && gpg --armor --output "$i".asc --detach-sig "$i"
+done
+
+##### 3.2 Generate SHA512 file
+shasum --version 1>/dev/null || exit
+for i in *.tar.gz; do
+ echo "$i" && shasum -a 512 "$i" >"$i".sha512
+done
+
+#### 3.3 check signature & sha512
+for i in *.tar.gz; do
+ echo "$i"
+ gpg --verify "$i".asc "$i" || exit
+done
+
+for i in *.tar.gz; do
+ echo "$i"
+ shasum -a 512 --check "$i".sha512 || exit
+done
+
+# step4: upload to Apache-SVN
+SVN_DIR="${GROUP}-svn-dev"
+cd ../
+rm -rfv ${SVN_DIR}
+
+##### 4.1 pull from remote & copy files
+svn co "https://dist.apache.org/repos/dist/dev/incubator/${GROUP}" ${SVN_DIR}
+mkdir -p ${SVN_DIR}/"${RELEASE_VERSION}"
+cp -v apache-${REPO}/*tar.gz* "${SVN_DIR}/${RELEASE_VERSION}"
+cd ${SVN_DIR} || exit
+
+##### 4.2 check status first
+svn status
+svn add --parents "${RELEASE_VERSION}"/apache-${REPO}-*
+# check status again
+svn status
+
+##### 4.3 commit & push files
+if [ "$USERNAME" = "" ]; then
+ svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}"
+else
+ svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}" --username "${USERNAME}" --password "${PASSWORD}"
Review Comment:
Minor: The ASF password is passed as a positional script argument and then as `--password` on the `svn` command line.
Running `./apache-release.sh 1.0.0 user secret` leaves `secret` in shell history and visible to other local users in `ps` while both processes run.
Drop the PASSWORD argument and let `svn commit` prompt or use the cached svn credentials.
##########
pom.xml:
##########
@@ -38,18 +38,51 @@
<licenses>
<license>
<name>The Apache Software License, Version 2.0</name>
- <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
+ <url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
</license>
</licenses>
- <!-- TODO: we need update the url and all package together -->
+ <developers>
+ <developer>
+ <id>Apache Hugegraph(incubating)</id>
+ <email>dev-subscribe@hugegraph.apache.org</email>
+ <url>https://hugegraph.apache.org/</url>
+ </developer>
+ </developers>
+
+ <mailingLists>
+ <mailingList>
+ <name>Developer List</name>
+ <subscribe>dev-subscribe@hugegraph.apache.org</subscribe>
+ <unsubscribe>dev-unsubscribe@hugegraph.apache.org</unsubscribe>
+ <post>dev@hugegraph.incubator.apache.org</post>
Review Comment:
Minor: The project metadata mixes address forms. The dev list `post` is `dev@hugegraph.incubator.apache.org` while every other list uses `@hugegraph.apache.org`, and the developer `<email>` at line 49 is the subscribe address, not a contact address.
These values are published in the deployed pom and shown on Maven Central.
Use `dev@hugegraph.apache.org` for `post` and as the developer email.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on pull request #399: refact: enhance root pom & sub-modules settings
Posted by "javeme (via GitHub)" <gi...@apache.org>.
javeme commented on PR #399:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/399#issuecomment-1712704984
Is it still in progress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] refact: enhance root pom & sub-modules settings [hugegraph-toolchain]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #399:
URL: https://github.com/apache/hugegraph-toolchain/pull/399#issuecomment-6175503294
Closing this superseded experiment. The remaining current-master release execution cleanup is tracked in https://github.com/apache/hugegraph-toolchain/issues/821 and should be handled in a focused PR against master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on pull request #399: refact: enhance root pom & sub-modules settings
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on PR #399:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/399#issuecomment-1581221798
Note: This PR is outdated & need update/resolve conflicts first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] refact: enhance root pom & sub-modules settings [hugegraph-toolchain]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin closed pull request #399: refact: enhance root pom & sub-modules settings
URL: https://github.com/apache/hugegraph-toolchain/pull/399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org