You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/14 12:00:59 UTC

[GitHub] [cloudstack] weizhouapache opened a new pull request #5105: server: set correct gateway when update vm nic on shared networks

weizhouapache opened a new pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105


   ### Description
   
   This PR fixes the issue that nic has wrong gateway after updating vm nic.
   
   Steps to reproduce the issue
   (1) create shared network (in advanced zone or advanced zone with sg)
   (2) create new shared network (with same startip/endip/netmask, but different gateway).
   (3) create a vm in new network
   (4) stop vm and update vm nic
   
   Expected result:
   The vm has correct gateway and netmask (of second network)
   
   Actual result:
   The vm has wrong gateway and netmask (of first network)
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [X] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861195491


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache removed a comment on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
weizhouapache removed a comment on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860763369


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-862007795


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861547458


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861738435


   <b>Trillian test result (tid-946)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43307 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5105-t946-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Smoke tests completed. 85 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 315.37 | test_routers_network_ops.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 429.88 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 479.42 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860694107






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-862006820


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860689590


   unit test failed, I will fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861437897


   - Testing on basic zone w/without SG
   - Testing on Adv zone w/without SG + shared


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860694107


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 229


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860825544


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] borisstoyanov commented on a change in pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on a change in pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#discussion_r651684617



##########
File path: server/src/test/java/com/cloud/vm/UserVmManagerTest.java
##########
@@ -630,9 +631,9 @@ public void testUpdateVmNicIpSuccess2() throws Exception {
         when(vlan.getVlanNetmask()).thenReturn("255.255.255.0");
 
         when(_ipAddrMgr.allocatePublicIpForGuestNic(Mockito.eq(_networkMock), nullable(Long.class), Mockito.eq(_accountMock), anyString())).thenReturn("10.10.10.10");
-        lenient().when(_ipAddressDao.findByIpAndSourceNetworkId(anyLong(), anyString())).thenReturn(null);
+        when(_ipAddressDao.findByIpAndSourceNetworkId(anyLong(), eq("10.10.10.10"))).thenReturn(newIp);
+        when(_ipAddressDao.findByIpAndSourceNetworkId(anyLong(), eq("10.10.10.9"))).thenReturn(null);

Review comment:
       Sorry I hope I'm wrong here, but isn't this too specific, looks like hardcoded to me?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-862007487


   @blueorangutan test 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860825954


   @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#discussion_r651692362



##########
File path: server/src/test/java/com/cloud/vm/UserVmManagerTest.java
##########
@@ -630,9 +631,9 @@ public void testUpdateVmNicIpSuccess2() throws Exception {
         when(vlan.getVlanNetmask()).thenReturn("255.255.255.0");
 
         when(_ipAddrMgr.allocatePublicIpForGuestNic(Mockito.eq(_networkMock), nullable(Long.class), Mockito.eq(_accountMock), anyString())).thenReturn("10.10.10.10");
-        lenient().when(_ipAddressDao.findByIpAndSourceNetworkId(anyLong(), anyString())).thenReturn(null);
+        when(_ipAddressDao.findByIpAndSourceNetworkId(anyLong(), eq("10.10.10.10"))).thenReturn(newIp);
+        when(_ipAddressDao.findByIpAndSourceNetworkId(anyLong(), eq("10.10.10.9"))).thenReturn(null);

Review comment:
       @borisstoyanov yes, it is hardcoded, but it is just an unit test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861812373


   <b>Trillian test result (tid-947)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 51032 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5105-t947-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 84 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 355.30 | test_routers_network_ops.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 599.85 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 534.41 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 546.81 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 580.91 | test_vpc_redundant.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 54.24 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861548309


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860842259


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 230


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861195051


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860630163


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860673289


   @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861437169


   cc @vladimirpetrov @shwstppr @Pearl1594 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-862006736


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861995859


   <b>Trillian test result (tid-950)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42817 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5105-t950-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 86 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 494.82 | test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 480.70 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 472.27 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861277346


   <b>Trillian test result (tid-939)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 51102 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5105-t939-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 80 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_create_template_with_checksum_sha1 | `Error` | 65.36 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.38 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.38 | test_templates.py
   test_04_extract_template | `Failure` | 128.31 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_volume_usage | `Error` | 187.07 | test_usage.py
   test_10_attachAndDetach_iso | `Failure` | 1516.39 | test_vm_life_cycle.py
   test_06_download_detached_volume | `Failure` | 313.07 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   test_disable_oobm_ha_state_ineligible | `Error` | 1517.87 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860630861


   @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860635320






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860763369


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860672752


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860635320


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 226


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861195838


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache removed a comment on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
weizhouapache removed a comment on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860630163


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860855742


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-860855095


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #5105: server: set correct gateway when update vm nic on shared networks

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5105:
URL: https://github.com/apache/cloudstack/pull/5105#issuecomment-861195339


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org