Re: svn commit: r652467 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/BlockContainer.java

[Andreas Delmelle <an...@telenet.be>]

On 11 Jan 2010, at 16:09, Edmund Mielach wrote:

Hi Edmund,

> I send you a mail in reply to your post on the fop-dev mailinglist (see below). I hope this direct mailing to you is ok. We are using Lotus Notes in our company and I didn't want to mess up the mailing list ... ;-) 

No problem! I have sent a copy to fop-dev@, since I have been inactive for a few months now...

> 
> Well, according to this post you have removed the height and width attributes from BlockContainer.java because these values are not used in the current trunk version (and perhaps even in the last release of fop). However, I have developed my own pdf renderer (special requirements implemented for a customer) which needs this values. It's not a big problem for me to add those lines of code in my source code but I think whenever someone wants to implement a new renderer it would be great to have those values here in the BlockContainer class. Or can I find them somewhere else. 

If I recall correctly, I did this because it is recommended to use getBlockProgressionDimension() and getInlineProgressionDimension(). 
width/height are actually properties that are only allowed in XSL-FO to remain compatible with CSS, but they are not really XSL-FO 'native'. Since almost everywhere, FOP stores only the native XSL-FO properties (CSS shortcuts, for example, are expanded at parse-time), I thought removing the accessors for width/height made the whole thing more consistent.

So...

> 
> Would you agree to put those lines back into the current trunk version ? 

I'd rather not, but will leave this up to other devs (who have been more active lately)

Regards


Andreas Delmelle
---

Re: svn commit: r652467 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/flow/BlockContainer.java

[Jeremias Maerki <de...@jeremias-maerki.ch>]

I concur with Andreas. Removing getWidth and getHeight from the FO tree
was the right thing to do for BlockContainer.
getBlockProgressionDimension() and getInlineProgressionDimension()
should be used for any calculations inside the layout engine.

On 11.01.2010 19:07:07 Andreas Delmelle wrote:
> On 11 Jan 2010, at 16:09, Edmund Mielach wrote:
> 
> Hi Edmund,
> 
> > I send you a mail in reply to your post on the fop-dev mailinglist (see below). I hope this direct mailing to you is ok. We are using Lotus Notes in our company and I didn't want to mess up the mailing list ... ;-) 
> 
> No problem! I have sent a copy to fop-dev@, since I have been inactive for a few months now...
> 
> > 
> > Well, according to this post you have removed the height and width attributes from BlockContainer.java because these values are not used in the current trunk version (and perhaps even in the last release of fop). However, I have developed my own pdf renderer (special requirements implemented for a customer) which needs this values. It's not a big problem for me to add those lines of code in my source code but I think whenever someone wants to implement a new renderer it would be great to have those values here in the BlockContainer class. Or can I find them somewhere else. 
> 
> If I recall correctly, I did this because it is recommended to use getBlockProgressionDimension() and getInlineProgressionDimension(). 
> width/height are actually properties that are only allowed in XSL-FO to remain compatible with CSS, but they are not really XSL-FO 'native'. Since almost everywhere, FOP stores only the native XSL-FO properties (CSS shortcuts, for example, are expanded at parse-time), I thought removing the accessors for width/height made the whole thing more consistent.
> 
> So...
> 
> > 
> > Would you agree to put those lines back into the current trunk version ? 
> 
> I'd rather not, but will leave this up to other devs (who have been more active lately)
> 
> Regards
> 
> 
> Andreas Delmelle
> ---
> 




Jeremias Maerki