You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/22 22:58:50 UTC
Review Request: Added current master "leader" to '/state.json' as well as
redirection in the webui.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6083/
-----------------------------------------------------------
Review request for mesos, John Sirois and Vinod Kone.
Description
-------
Now, if a leader is known to one of the masters it will be included in the JSON returned from hitting the '/state.json' endpoint. In addition, the webui will automagically redirect to the leading master after 5 seconds.
Diffs
-----
src/master/http.cpp 2568303
src/master/master.hpp ad2ec25
src/master/master.cpp 43407fa
src/webui/master/static/controllers.js a73814e
src/webui/master/static/index.html 70a5b8e
Diff: https://reviews.apache.org/r/6083/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Added current master "leader" to '/state.json' as well
as redirection in the webui.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 23, 2012, 4:16 p.m., John Sirois wrote:
> > src/webui/master/static/controllers.js, line 16
> > <https://reviews.apache.org/r/6083/diff/1/?file=126994#file126994line16>
> >
> > This is kinda long - presumably you're damping here to prevent redirect thrash. It might be nice to add a redirect link during the countdown to allow a user to proceed right away.
Added a "go now" link.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6083/#review9361
-----------------------------------------------------------
On July 22, 2012, 8:58 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6083/
> -----------------------------------------------------------
>
> (Updated July 22, 2012, 8:58 p.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> Now, if a leader is known to one of the masters it will be included in the JSON returned from hitting the '/state.json' endpoint. In addition, the webui will automagically redirect to the leading master after 5 seconds.
>
>
> Diffs
> -----
>
> src/master/http.cpp 2568303
> src/master/master.hpp ad2ec25
> src/master/master.cpp 43407fa
> src/webui/master/static/controllers.js a73814e
> src/webui/master/static/index.html 70a5b8e
>
> Diff: https://reviews.apache.org/r/6083/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added current master "leader" to '/state.json' as well
as redirection in the webui.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6083/#review9361
-----------------------------------------------------------
Ship it!
src/webui/master/static/controllers.js
<https://reviews.apache.org/r/6083/#comment20091>
This is kinda long - presumably you're damping here to prevent redirect thrash. It might be nice to add a redirect link during the countdown to allow a user to proceed right away.
- John Sirois
On July 22, 2012, 8:58 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6083/
> -----------------------------------------------------------
>
> (Updated July 22, 2012, 8:58 p.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> Now, if a leader is known to one of the masters it will be included in the JSON returned from hitting the '/state.json' endpoint. In addition, the webui will automagically redirect to the leading master after 5 seconds.
>
>
> Diffs
> -----
>
> src/master/http.cpp 2568303
> src/master/master.hpp ad2ec25
> src/master/master.cpp 43407fa
> src/webui/master/static/controllers.js a73814e
> src/webui/master/static/index.html 70a5b8e
>
> Diff: https://reviews.apache.org/r/6083/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added current master "leader" to '/state.json' as well
as redirection in the webui.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 23, 2012, 4:27 p.m., Vinod Kone wrote:
> > yay..this makes life easy. i agree with john about having a redirect link to proceed right away to the leader
Also added an "alert" if no masters are currently leading.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6083/#review9362
-----------------------------------------------------------
On July 22, 2012, 8:58 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6083/
> -----------------------------------------------------------
>
> (Updated July 22, 2012, 8:58 p.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> Now, if a leader is known to one of the masters it will be included in the JSON returned from hitting the '/state.json' endpoint. In addition, the webui will automagically redirect to the leading master after 5 seconds.
>
>
> Diffs
> -----
>
> src/master/http.cpp 2568303
> src/master/master.hpp ad2ec25
> src/master/master.cpp 43407fa
> src/webui/master/static/controllers.js a73814e
> src/webui/master/static/index.html 70a5b8e
>
> Diff: https://reviews.apache.org/r/6083/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Added current master "leader" to '/state.json' as well
as redirection in the webui.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6083/#review9362
-----------------------------------------------------------
Ship it!
yay..this makes life easy. i agree with john about having a redirect link to proceed right away to the leader
- Vinod Kone
On July 22, 2012, 8:58 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6083/
> -----------------------------------------------------------
>
> (Updated July 22, 2012, 8:58 p.m.)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Description
> -------
>
> Now, if a leader is known to one of the masters it will be included in the JSON returned from hitting the '/state.json' endpoint. In addition, the webui will automagically redirect to the leading master after 5 seconds.
>
>
> Diffs
> -----
>
> src/master/http.cpp 2568303
> src/master/master.hpp ad2ec25
> src/master/master.cpp 43407fa
> src/webui/master/static/controllers.js a73814e
> src/webui/master/static/index.html 70a5b8e
>
> Diff: https://reviews.apache.org/r/6083/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>