[jira] [Comment Edited] (BEAM-1205) Auto set "enableAbandonedNodeEnforcement" in TestPipeline

["Stas Levin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770602#comment-15770602 ] 

Stas Levin edited comment on BEAM-1205 at 12/22/16 6:10 PM:
------------------------------------------------------------

I see, thanks for commenting.

So {{if (!isCrashingRunner || needsRunner || runnableOnService)}} we can activate the enforcement by default, right?
What use cases can you think of that are not covered and require checking the package prefix?


was (Author: staslev):
I see, thanks for commenting.

So {{if (!sCrashingRunner || needsRunner || runnableOnService)}} we can activate the enforcement by default, right?
What use cases can you think of that are not covered and require checking the package prefix?

> Auto set "enableAbandonedNodeEnforcement" in TestPipeline
> ---------------------------------------------------------
>
>                 Key: BEAM-1205
>                 URL: https://issues.apache.org/jira/browse/BEAM-1205
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>
> At the moment one has to manually set {{enableAbandonedNodeEnforcement(false)}} in tests that do not run the TestPipeline, otherwise one gets an {{AbandonedNodeException}} on account of having nodes that were not run.
> This could probably be auto detected using the {{RunnableOnService}} annotation, the presence of which indicates a given test does indeed use a runner. 
> Essentially we need to check if {{RunnableOnService}} is present on a given test and if so set {{enableAbandonedNodeEnforcement(true)}}, otherwise set {{enableAbandonedNodeEnforcement(false)}}.
> [~tgroh], [~kenn]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)