You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/12/09 08:24:10 UTC
[GitHub] [incubator-inlong] luchunliang opened a new pull request #1942: [INLONG-1893] Inlong-Sort-Standalone support to sort the events to Pulsar clusters.
luchunliang opened a new pull request #1942:
URL: https://github.com/apache/incubator-inlong/pull/1942
### Title Name: [INLONG-1893][Inlong-Sort-Standalone] Inlong-Sort-Standalone support to sort the events to Pulsar clusters.
Fixes #1893
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #1942: [INLONG-1893] Inlong-Sort-Standalone support to sort the events to Pulsar clusters.
Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #1942:
URL: https://github.com/apache/incubator-inlong/pull/1942#discussion_r767378440
##########
File path: inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/pulsar/PulsarProducerCluster.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.sink.pulsar;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.flume.Context;
+import org.apache.flume.Event;
+import org.apache.flume.Transaction;
+import org.apache.flume.lifecycle.LifecycleAware;
+import org.apache.flume.lifecycle.LifecycleState;
+import org.apache.inlong.sort.standalone.config.pojo.CacheClusterConfig;
+import org.apache.inlong.sort.standalone.metrics.SortMetricItem;
+import org.apache.inlong.sort.standalone.utils.Constants;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+import org.apache.pulsar.client.api.AuthenticationFactory;
+import org.apache.pulsar.client.api.BatcherBuilder;
+import org.apache.pulsar.client.api.CompressionType;
+import org.apache.pulsar.client.api.HashingScheme;
+import org.apache.pulsar.client.api.MessageId;
+import org.apache.pulsar.client.api.Producer;
+import org.apache.pulsar.client.api.ProducerBuilder;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.PulsarClientException;
+import org.apache.pulsar.shade.org.apache.commons.lang.math.NumberUtils;
+import org.slf4j.Logger;
+
+/**
+ *
+ * PulsarProducerCluster
+ */
+public class PulsarProducerCluster implements LifecycleAware {
+
+ public static final Logger LOG = InlongLoggerFactory.getLogger(PulsarProducerCluster.class);
+
+ public static final String KEY_SERVICE_URL = "serviceUrl";
+ public static final String KEY_AUTHENTICATION = "authentication";
+
+ public static final String KEY_ENABLEBATCHING = "enableBatching";
+ public static final String KEY_BATCHINGMAXBYTES = "batchingMaxBytes";
+ public static final String KEY_BATCHINGMAXMESSAGES = "batchingMaxMessages";
+ public static final String KEY_BATCHINGMAXPUBLISHDELAY = "batchingMaxPublishDelay";
+ public static final String KEY_MAXPENDINGMESSAGES = "maxPendingMessages";
+ public static final String KEY_MAXPENDINGMESSAGESACROSSPARTITIONS = "maxPendingMessagesAcrossPartitions";
+ public static final String KEY_SENDTIMEOUT = "sendTimeout";
+ public static final String KEY_COMPRESSIONTYPE = "compressionType";
+ public static final String KEY_BLOCKIFQUEUEFULL = "blockIfQueueFull";
+ public static final String KEY_ROUNDROBINROUTERBATCHINGPARTITIONSWITCHFREQUENCY = "roundRobinRouter"
+ + "BatchingPartitionSwitchFrequency";
+
+ private final String workerName;
+ private final CacheClusterConfig config;
+ private final PulsarFederationSinkContext sinkContext;
+ private final Context context;
+ private final String cacheClusterName;
+ private LifecycleState state;
+
+ /**
+ * pulsar client
+ */
+ private PulsarClient client;
+ private ProducerBuilder<byte[]> baseBuilder;
+
+ private Map<String, Producer<byte[]>> producerMap = new ConcurrentHashMap<>();
+
+ /**
+ * Constructor
+ *
+ * @param workerName
+ * @param config
+ * @param context
+ */
+ public PulsarProducerCluster(String workerName, CacheClusterConfig config, PulsarFederationSinkContext context) {
+ this.workerName = workerName;
+ this.config = config;
+ this.sinkContext = context;
+ this.context = context.getProducerContext();
+ this.state = LifecycleState.IDLE;
+ this.cacheClusterName = config.getClusterName();
+ }
+
+ /**
+ * start
+ */
+ @Override
+ public void start() {
+ this.state = LifecycleState.START;
+ // create pulsar client
+ try {
+ String serviceUrl = config.getParams().get(KEY_SERVICE_URL);
+ String authentication = config.getParams().get(KEY_AUTHENTICATION);
+ this.client = PulsarClient.builder()
+ .serviceUrl(serviceUrl)
+ .authentication(AuthenticationFactory.token(authentication))
+ .build();
+ this.baseBuilder = client.newProducer();
+// Map<String, Object> builderConf = new HashMap<>();
+// builderConf.putAll(context.getParameters());
+ this.baseBuilder
+ .hashingScheme(HashingScheme.Murmur3_32Hash)
+ .enableBatching(context.getBoolean(KEY_ENABLEBATCHING, true))
+ .batchingMaxBytes(context.getInteger(KEY_BATCHINGMAXBYTES, 5242880))
+ .batchingMaxMessages(context.getInteger(KEY_BATCHINGMAXMESSAGES, 3000))
+ .batchingMaxPublishDelay(context.getInteger(KEY_BATCHINGMAXPUBLISHDELAY, 1),
+ TimeUnit.MILLISECONDS);
+ this.baseBuilder.maxPendingMessages(context.getInteger(KEY_MAXPENDINGMESSAGES, 1000))
+ .maxPendingMessagesAcrossPartitions(
+ context.getInteger(KEY_MAXPENDINGMESSAGESACROSSPARTITIONS, 50000))
+ .sendTimeout(context.getInteger(KEY_SENDTIMEOUT, 0), TimeUnit.MILLISECONDS)
+ .compressionType(this.getPulsarCompressionType())
+ .blockIfQueueFull(context.getBoolean(KEY_BLOCKIFQUEUEFULL, true))
+ .roundRobinRouterBatchingPartitionSwitchFrequency(
+ context.getInteger(KEY_ROUNDROBINROUTERBATCHINGPARTITIONSWITCHFREQUENCY, 10))
+ .batcherBuilder(BatcherBuilder.DEFAULT);
+ } catch (Throwable e) {
+ LOG.error(e.getMessage(), e);
+ }
+ }
+
+ /**
+ * getPulsarCompressionType
+ *
+ * @return CompressionType
+ */
+ private CompressionType getPulsarCompressionType() {
+ String type = this.context.getString(KEY_COMPRESSIONTYPE);
+ switch (type) {
+ case "LZ4" :
+ return CompressionType.LZ4;
+ case "NONE" :
+ return CompressionType.NONE;
+ case "ZLIB" :
+ return CompressionType.ZLIB;
+ case "ZSTD" :
+ return CompressionType.ZSTD;
+ case "SNAPPY" :
+ return CompressionType.SNAPPY;
+ default :
+ return CompressionType.NONE;
+ }
+ }
+
+ /**
+ * stop
+ */
+ @Override
+ public void stop() {
+ this.state = LifecycleState.STOP;
+ //
Review comment:
add comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #1942: [INLONG-1893] Inlong-Sort-Standalone support to sort the events to Pulsar clusters.
Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #1942:
URL: https://github.com/apache/incubator-inlong/pull/1942#discussion_r767376309
##########
File path: inlong-dataproxy/dataproxy-source/pom.xml
##########
@@ -26,9 +34,6 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Review comment:
ok, use spaces instead of tabs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #1942: [INLONG-1893] Inlong-Sort-Standalone support to sort the events to Pulsar clusters.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1942:
URL: https://github.com/apache/incubator-inlong/pull/1942#issuecomment-992059293
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1942?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1942](https://codecov.io/gh/apache/incubator-inlong/pull/1942?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (adefdd4) into [master](https://codecov.io/gh/apache/incubator-inlong/commit/50bc7237f168703715c9ffd25b897e20e5545ad5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (50bc723) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/1942?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1942 +/- ##
============================================
+ Coverage 12.25% 12.28% +0.02%
Complexity 1157 1157
============================================
Files 413 413
Lines 35225 35225
Branches 5542 5542
============================================
+ Hits 4318 4327 +9
+ Misses 30135 30127 -8
+ Partials 772 771 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/1942?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...bemq/server/common/heartbeat/HeartbeatManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/1942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL3NlcnZlci9jb21tb24vaGVhcnRiZWF0L0hlYXJ0YmVhdE1hbmFnZXIuamF2YQ==) | `38.38% <0.00%> (+2.02%)` | :arrow_up: |
| [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-inlong/pull/1942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29ubmVjdG9ycy90dWJlbXEtY29ubmVjdG9yLWZsdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9mbHVtZS9zaW5rL3R1YmVtcS9UdWJlbXFTaW5rLmphdmE=) | `55.42% <0.00%> (+4.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1942?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/1942?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [50bc723...adefdd4](https://codecov.io/gh/apache/incubator-inlong/pull/1942?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #1942: [INLONG-1893] Inlong-Sort-Standalone support to sort the events to Pulsar clusters.
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #1942:
URL: https://github.com/apache/incubator-inlong/pull/1942#discussion_r767370345
##########
File path: inlong-dataproxy/dataproxy-source/pom.xml
##########
@@ -26,9 +34,6 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
Review comment:
please use spaces instead of tabs.
##########
File path: inlong-sort-standalone/pom.xml
##########
@@ -50,6 +50,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<compiler.source>1.8</compiler.source>
<compiler.target>1.8</compiler.target>
+ <pulsar.version>2.7.2</pulsar.version>
Review comment:
ditto.
##########
File path: inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/pulsar/PulsarProducerCluster.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.sink.pulsar;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.flume.Context;
+import org.apache.flume.Event;
+import org.apache.flume.Transaction;
+import org.apache.flume.lifecycle.LifecycleAware;
+import org.apache.flume.lifecycle.LifecycleState;
+import org.apache.inlong.sort.standalone.config.pojo.CacheClusterConfig;
+import org.apache.inlong.sort.standalone.metrics.SortMetricItem;
+import org.apache.inlong.sort.standalone.utils.Constants;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+import org.apache.pulsar.client.api.AuthenticationFactory;
+import org.apache.pulsar.client.api.BatcherBuilder;
+import org.apache.pulsar.client.api.CompressionType;
+import org.apache.pulsar.client.api.HashingScheme;
+import org.apache.pulsar.client.api.MessageId;
+import org.apache.pulsar.client.api.Producer;
+import org.apache.pulsar.client.api.ProducerBuilder;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.PulsarClientException;
+import org.apache.pulsar.shade.org.apache.commons.lang.math.NumberUtils;
+import org.slf4j.Logger;
+
+/**
+ *
+ * PulsarProducerCluster
+ */
+public class PulsarProducerCluster implements LifecycleAware {
+
+ public static final Logger LOG = InlongLoggerFactory.getLogger(PulsarProducerCluster.class);
+
+ public static final String KEY_SERVICE_URL = "serviceUrl";
+ public static final String KEY_AUTHENTICATION = "authentication";
+
+ public static final String KEY_ENABLEBATCHING = "enableBatching";
+ public static final String KEY_BATCHINGMAXBYTES = "batchingMaxBytes";
+ public static final String KEY_BATCHINGMAXMESSAGES = "batchingMaxMessages";
+ public static final String KEY_BATCHINGMAXPUBLISHDELAY = "batchingMaxPublishDelay";
+ public static final String KEY_MAXPENDINGMESSAGES = "maxPendingMessages";
+ public static final String KEY_MAXPENDINGMESSAGESACROSSPARTITIONS = "maxPendingMessagesAcrossPartitions";
+ public static final String KEY_SENDTIMEOUT = "sendTimeout";
+ public static final String KEY_COMPRESSIONTYPE = "compressionType";
+ public static final String KEY_BLOCKIFQUEUEFULL = "blockIfQueueFull";
+ public static final String KEY_ROUNDROBINROUTERBATCHINGPARTITIONSWITCHFREQUENCY = "roundRobinRouter"
+ + "BatchingPartitionSwitchFrequency";
+
+ private final String workerName;
+ private final CacheClusterConfig config;
+ private final PulsarFederationSinkContext sinkContext;
+ private final Context context;
+ private final String cacheClusterName;
+ private LifecycleState state;
+
+ /**
+ * pulsar client
+ */
+ private PulsarClient client;
+ private ProducerBuilder<byte[]> baseBuilder;
+
+ private Map<String, Producer<byte[]>> producerMap = new ConcurrentHashMap<>();
+
+ /**
+ * Constructor
+ *
+ * @param workerName
+ * @param config
+ * @param context
+ */
+ public PulsarProducerCluster(String workerName, CacheClusterConfig config, PulsarFederationSinkContext context) {
+ this.workerName = workerName;
+ this.config = config;
+ this.sinkContext = context;
+ this.context = context.getProducerContext();
+ this.state = LifecycleState.IDLE;
+ this.cacheClusterName = config.getClusterName();
+ }
+
+ /**
+ * start
+ */
+ @Override
+ public void start() {
+ this.state = LifecycleState.START;
+ // create pulsar client
+ try {
+ String serviceUrl = config.getParams().get(KEY_SERVICE_URL);
+ String authentication = config.getParams().get(KEY_AUTHENTICATION);
+ this.client = PulsarClient.builder()
+ .serviceUrl(serviceUrl)
+ .authentication(AuthenticationFactory.token(authentication))
+ .build();
+ this.baseBuilder = client.newProducer();
+// Map<String, Object> builderConf = new HashMap<>();
Review comment:
remove those unnecessary codes.
##########
File path: inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/pulsar/PulsarProducerCluster.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.sink.pulsar;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.flume.Context;
+import org.apache.flume.Event;
+import org.apache.flume.Transaction;
+import org.apache.flume.lifecycle.LifecycleAware;
+import org.apache.flume.lifecycle.LifecycleState;
+import org.apache.inlong.sort.standalone.config.pojo.CacheClusterConfig;
+import org.apache.inlong.sort.standalone.metrics.SortMetricItem;
+import org.apache.inlong.sort.standalone.utils.Constants;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+import org.apache.pulsar.client.api.AuthenticationFactory;
+import org.apache.pulsar.client.api.BatcherBuilder;
+import org.apache.pulsar.client.api.CompressionType;
+import org.apache.pulsar.client.api.HashingScheme;
+import org.apache.pulsar.client.api.MessageId;
+import org.apache.pulsar.client.api.Producer;
+import org.apache.pulsar.client.api.ProducerBuilder;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.PulsarClientException;
+import org.apache.pulsar.shade.org.apache.commons.lang.math.NumberUtils;
+import org.slf4j.Logger;
+
+/**
+ *
+ * PulsarProducerCluster
+ */
+public class PulsarProducerCluster implements LifecycleAware {
+
+ public static final Logger LOG = InlongLoggerFactory.getLogger(PulsarProducerCluster.class);
+
+ public static final String KEY_SERVICE_URL = "serviceUrl";
+ public static final String KEY_AUTHENTICATION = "authentication";
+
+ public static final String KEY_ENABLEBATCHING = "enableBatching";
+ public static final String KEY_BATCHINGMAXBYTES = "batchingMaxBytes";
+ public static final String KEY_BATCHINGMAXMESSAGES = "batchingMaxMessages";
+ public static final String KEY_BATCHINGMAXPUBLISHDELAY = "batchingMaxPublishDelay";
+ public static final String KEY_MAXPENDINGMESSAGES = "maxPendingMessages";
+ public static final String KEY_MAXPENDINGMESSAGESACROSSPARTITIONS = "maxPendingMessagesAcrossPartitions";
+ public static final String KEY_SENDTIMEOUT = "sendTimeout";
+ public static final String KEY_COMPRESSIONTYPE = "compressionType";
+ public static final String KEY_BLOCKIFQUEUEFULL = "blockIfQueueFull";
+ public static final String KEY_ROUNDROBINROUTERBATCHINGPARTITIONSWITCHFREQUENCY = "roundRobinRouter"
+ + "BatchingPartitionSwitchFrequency";
+
+ private final String workerName;
+ private final CacheClusterConfig config;
+ private final PulsarFederationSinkContext sinkContext;
+ private final Context context;
+ private final String cacheClusterName;
+ private LifecycleState state;
+
+ /**
+ * pulsar client
+ */
+ private PulsarClient client;
+ private ProducerBuilder<byte[]> baseBuilder;
+
+ private Map<String, Producer<byte[]>> producerMap = new ConcurrentHashMap<>();
+
+ /**
+ * Constructor
+ *
+ * @param workerName
+ * @param config
+ * @param context
+ */
+ public PulsarProducerCluster(String workerName, CacheClusterConfig config, PulsarFederationSinkContext context) {
+ this.workerName = workerName;
+ this.config = config;
+ this.sinkContext = context;
+ this.context = context.getProducerContext();
+ this.state = LifecycleState.IDLE;
+ this.cacheClusterName = config.getClusterName();
+ }
+
+ /**
+ * start
+ */
+ @Override
+ public void start() {
+ this.state = LifecycleState.START;
+ // create pulsar client
+ try {
+ String serviceUrl = config.getParams().get(KEY_SERVICE_URL);
+ String authentication = config.getParams().get(KEY_AUTHENTICATION);
+ this.client = PulsarClient.builder()
+ .serviceUrl(serviceUrl)
+ .authentication(AuthenticationFactory.token(authentication))
+ .build();
+ this.baseBuilder = client.newProducer();
+// Map<String, Object> builderConf = new HashMap<>();
+// builderConf.putAll(context.getParameters());
+ this.baseBuilder
+ .hashingScheme(HashingScheme.Murmur3_32Hash)
+ .enableBatching(context.getBoolean(KEY_ENABLEBATCHING, true))
+ .batchingMaxBytes(context.getInteger(KEY_BATCHINGMAXBYTES, 5242880))
+ .batchingMaxMessages(context.getInteger(KEY_BATCHINGMAXMESSAGES, 3000))
+ .batchingMaxPublishDelay(context.getInteger(KEY_BATCHINGMAXPUBLISHDELAY, 1),
+ TimeUnit.MILLISECONDS);
+ this.baseBuilder.maxPendingMessages(context.getInteger(KEY_MAXPENDINGMESSAGES, 1000))
+ .maxPendingMessagesAcrossPartitions(
+ context.getInteger(KEY_MAXPENDINGMESSAGESACROSSPARTITIONS, 50000))
+ .sendTimeout(context.getInteger(KEY_SENDTIMEOUT, 0), TimeUnit.MILLISECONDS)
+ .compressionType(this.getPulsarCompressionType())
+ .blockIfQueueFull(context.getBoolean(KEY_BLOCKIFQUEUEFULL, true))
+ .roundRobinRouterBatchingPartitionSwitchFrequency(
+ context.getInteger(KEY_ROUNDROBINROUTERBATCHINGPARTITIONSWITCHFREQUENCY, 10))
+ .batcherBuilder(BatcherBuilder.DEFAULT);
+ } catch (Throwable e) {
+ LOG.error(e.getMessage(), e);
+ }
+ }
+
+ /**
+ * getPulsarCompressionType
+ *
+ * @return CompressionType
+ */
+ private CompressionType getPulsarCompressionType() {
+ String type = this.context.getString(KEY_COMPRESSIONTYPE);
+ switch (type) {
+ case "LZ4" :
+ return CompressionType.LZ4;
+ case "NONE" :
+ return CompressionType.NONE;
+ case "ZLIB" :
+ return CompressionType.ZLIB;
+ case "ZSTD" :
+ return CompressionType.ZSTD;
+ case "SNAPPY" :
+ return CompressionType.SNAPPY;
+ default :
+ return CompressionType.NONE;
+ }
+ }
+
+ /**
+ * stop
+ */
+ @Override
+ public void stop() {
+ this.state = LifecycleState.STOP;
+ //
Review comment:
add your comment, or remove the blank comment.
##########
File path: inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/pulsar/PulsarFederationSinkContext.java
##########
@@ -0,0 +1,122 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.sink.pulsar;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+import org.apache.flume.Channel;
+import org.apache.flume.Context;
+import org.apache.inlong.sort.standalone.config.holder.SortClusterConfigHolder;
+import org.apache.inlong.sort.standalone.config.pojo.CacheClusterConfig;
+import org.apache.inlong.sort.standalone.config.pojo.InlongId;
+import org.apache.inlong.sort.standalone.config.pojo.SortTaskConfig;
+import org.apache.inlong.sort.standalone.sink.SinkContext;
+import org.apache.inlong.sort.standalone.utils.Constants;
+import org.slf4j.Logger;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+
+/**
+ *
+ * PulsarFederationSinkContext
+ */
+public class PulsarFederationSinkContext extends SinkContext {
+
+ public static final Logger LOG = InlongLoggerFactory.getLogger(PulsarFederationSinkContext.class);
+
+ private Context producerContext;
+ private Map<String, String> idTopicMap = new ConcurrentHashMap<>();
+ private List<CacheClusterConfig> clusterConfigList = new ArrayList<>();
+
+ /**
+ * Constructor
+ *
+ * @param sinkName
+ * @param context
+ * @param channel
+ */
+ public PulsarFederationSinkContext(String sinkName, Context context, Channel channel) {
+ super(sinkName, context, channel);
+ }
+
+ /**
+ * reload
+ */
+ public void reload() {
+ super.reload();
+ try {
+ SortTaskConfig newSortTaskConfig = SortClusterConfigHolder.getTaskConfig(taskName);
+ if (this.sortTaskConfig != null && this.sortTaskConfig.equals(newSortTaskConfig)) {
+ return;
+ }
+ this.sortTaskConfig = newSortTaskConfig;
+ this.producerContext = new Context(this.sortTaskConfig.getSinkParams());
+ //
Review comment:
What is the purpose of these empty comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #1942: [INLONG-1893] Inlong-Sort-Standalone support to sort the events to Pulsar clusters.
Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #1942:
URL: https://github.com/apache/incubator-inlong/pull/1942#discussion_r767376530
##########
File path: inlong-sort-standalone/pom.xml
##########
@@ -50,6 +50,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<compiler.source>1.8</compiler.source>
<compiler.target>1.8</compiler.target>
+ <pulsar.version>2.7.2</pulsar.version>
Review comment:
ok, use spaces instead of tabs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #1942: [INLONG-1893] Inlong-Sort-Standalone support to sort the events to Pulsar clusters.
Posted by GitBox <gi...@apache.org>.
dockerzhang merged pull request #1942:
URL: https://github.com/apache/incubator-inlong/pull/1942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #1942: [INLONG-1893] Inlong-Sort-Standalone support to sort the events to Pulsar clusters.
Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #1942:
URL: https://github.com/apache/incubator-inlong/pull/1942#discussion_r767378311
##########
File path: inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/pulsar/PulsarProducerCluster.java
##########
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.sink.pulsar;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.flume.Context;
+import org.apache.flume.Event;
+import org.apache.flume.Transaction;
+import org.apache.flume.lifecycle.LifecycleAware;
+import org.apache.flume.lifecycle.LifecycleState;
+import org.apache.inlong.sort.standalone.config.pojo.CacheClusterConfig;
+import org.apache.inlong.sort.standalone.metrics.SortMetricItem;
+import org.apache.inlong.sort.standalone.utils.Constants;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+import org.apache.pulsar.client.api.AuthenticationFactory;
+import org.apache.pulsar.client.api.BatcherBuilder;
+import org.apache.pulsar.client.api.CompressionType;
+import org.apache.pulsar.client.api.HashingScheme;
+import org.apache.pulsar.client.api.MessageId;
+import org.apache.pulsar.client.api.Producer;
+import org.apache.pulsar.client.api.ProducerBuilder;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.PulsarClientException;
+import org.apache.pulsar.shade.org.apache.commons.lang.math.NumberUtils;
+import org.slf4j.Logger;
+
+/**
+ *
+ * PulsarProducerCluster
+ */
+public class PulsarProducerCluster implements LifecycleAware {
+
+ public static final Logger LOG = InlongLoggerFactory.getLogger(PulsarProducerCluster.class);
+
+ public static final String KEY_SERVICE_URL = "serviceUrl";
+ public static final String KEY_AUTHENTICATION = "authentication";
+
+ public static final String KEY_ENABLEBATCHING = "enableBatching";
+ public static final String KEY_BATCHINGMAXBYTES = "batchingMaxBytes";
+ public static final String KEY_BATCHINGMAXMESSAGES = "batchingMaxMessages";
+ public static final String KEY_BATCHINGMAXPUBLISHDELAY = "batchingMaxPublishDelay";
+ public static final String KEY_MAXPENDINGMESSAGES = "maxPendingMessages";
+ public static final String KEY_MAXPENDINGMESSAGESACROSSPARTITIONS = "maxPendingMessagesAcrossPartitions";
+ public static final String KEY_SENDTIMEOUT = "sendTimeout";
+ public static final String KEY_COMPRESSIONTYPE = "compressionType";
+ public static final String KEY_BLOCKIFQUEUEFULL = "blockIfQueueFull";
+ public static final String KEY_ROUNDROBINROUTERBATCHINGPARTITIONSWITCHFREQUENCY = "roundRobinRouter"
+ + "BatchingPartitionSwitchFrequency";
+
+ private final String workerName;
+ private final CacheClusterConfig config;
+ private final PulsarFederationSinkContext sinkContext;
+ private final Context context;
+ private final String cacheClusterName;
+ private LifecycleState state;
+
+ /**
+ * pulsar client
+ */
+ private PulsarClient client;
+ private ProducerBuilder<byte[]> baseBuilder;
+
+ private Map<String, Producer<byte[]>> producerMap = new ConcurrentHashMap<>();
+
+ /**
+ * Constructor
+ *
+ * @param workerName
+ * @param config
+ * @param context
+ */
+ public PulsarProducerCluster(String workerName, CacheClusterConfig config, PulsarFederationSinkContext context) {
+ this.workerName = workerName;
+ this.config = config;
+ this.sinkContext = context;
+ this.context = context.getProducerContext();
+ this.state = LifecycleState.IDLE;
+ this.cacheClusterName = config.getClusterName();
+ }
+
+ /**
+ * start
+ */
+ @Override
+ public void start() {
+ this.state = LifecycleState.START;
+ // create pulsar client
+ try {
+ String serviceUrl = config.getParams().get(KEY_SERVICE_URL);
+ String authentication = config.getParams().get(KEY_AUTHENTICATION);
+ this.client = PulsarClient.builder()
+ .serviceUrl(serviceUrl)
+ .authentication(AuthenticationFactory.token(authentication))
+ .build();
+ this.baseBuilder = client.newProducer();
+// Map<String, Object> builderConf = new HashMap<>();
Review comment:
remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #1942: [INLONG-1893] Inlong-Sort-Standalone support to sort the events to Pulsar clusters.
Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #1942:
URL: https://github.com/apache/incubator-inlong/pull/1942#discussion_r767378084
##########
File path: inlong-sort-standalone/sort-standalone-source/src/main/java/org/apache/inlong/sort/standalone/sink/pulsar/PulsarFederationSinkContext.java
##########
@@ -0,0 +1,122 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.standalone.sink.pulsar;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+import org.apache.flume.Channel;
+import org.apache.flume.Context;
+import org.apache.inlong.sort.standalone.config.holder.SortClusterConfigHolder;
+import org.apache.inlong.sort.standalone.config.pojo.CacheClusterConfig;
+import org.apache.inlong.sort.standalone.config.pojo.InlongId;
+import org.apache.inlong.sort.standalone.config.pojo.SortTaskConfig;
+import org.apache.inlong.sort.standalone.sink.SinkContext;
+import org.apache.inlong.sort.standalone.utils.Constants;
+import org.slf4j.Logger;
+import org.apache.inlong.sort.standalone.utils.InlongLoggerFactory;
+
+/**
+ *
+ * PulsarFederationSinkContext
+ */
+public class PulsarFederationSinkContext extends SinkContext {
+
+ public static final Logger LOG = InlongLoggerFactory.getLogger(PulsarFederationSinkContext.class);
+
+ private Context producerContext;
+ private Map<String, String> idTopicMap = new ConcurrentHashMap<>();
+ private List<CacheClusterConfig> clusterConfigList = new ArrayList<>();
+
+ /**
+ * Constructor
+ *
+ * @param sinkName
+ * @param context
+ * @param channel
+ */
+ public PulsarFederationSinkContext(String sinkName, Context context, Channel channel) {
+ super(sinkName, context, channel);
+ }
+
+ /**
+ * reload
+ */
+ public void reload() {
+ super.reload();
+ try {
+ SortTaskConfig newSortTaskConfig = SortClusterConfigHolder.getTaskConfig(taskName);
+ if (this.sortTaskConfig != null && this.sortTaskConfig.equals(newSortTaskConfig)) {
+ return;
+ }
+ this.sortTaskConfig = newSortTaskConfig;
+ this.producerContext = new Context(this.sortTaskConfig.getSinkParams());
+ //
Review comment:
add comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org