You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:51:41 UTC

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #651: feat: support get plugin schema based on schema_type

juzhiyuan edited a comment on pull request #651:
URL: https://github.com/apache/apisix-dashboard/pull/651#issuecomment-720811356


   > What problem is this PR trying to solve? Sorry, I am not familiar with this part of the logic.
   > I have some questions:
   > 
   > 1. Why dashboard repo has Lua code?
   > 2. If Apache APISIX adds or modifies the plug-in schema, do we need to modify the code here?
   
   Related issue https://github.com/apache/apisix-dashboard/issues/605
   
   This PR aims to fetch the plugin's schema type.
   
   > Why dashboard repo has Lua code?
   
   @nic-chen uses those codes to sync schema from APISIX.
   
   > If Apache APISIX adds or modifies the plug-in schema, do we need to modify the code here?
   
   Yes, and this way should be removed and use other good solutions, or this issue will occur https://github.com/apache/apisix-dashboard/issues/646#issuecomment-719430552


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org