You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/12/01 12:25:12 UTC

[jira] [Commented] (THRIFT-2866) Go generator source code is hard to read and maintain

    [ https://issues.apache.org/jira/browse/THRIFT-2866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229680#comment-14229680 ] 

ASF GitHub Bot commented on THRIFT-2866:
----------------------------------------

Github user hcorg commented on the pull request:

    https://github.com/apache/thrift/pull/295#issuecomment-65051630
  
    another run of 'make style' will remove changes made by in this PR. If you want to increase readability of Go generator some bigger refactoring is needed - shorter functions, shorter << sequences.


> Go generator source code is hard to read and maintain
> -----------------------------------------------------
>
>                 Key: THRIFT-2866
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2866
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Chi Vinh Le
>             Fix For: 0.9.3
>
>
> Because of auto-formatting the source code from https://issues.apache.org/jira/browse/THRIFT-2729 the source writing part of the Go generator is cluttered and barely readable.
> This PR sets line breaks in appropriate positions to make it a lot more readable and maintainable.
> https://github.com/apache/thrift/pull/295



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)