[GitHub] ralf0131 edited a comment on issue #2435: Summary of several issues of graceful shutdown

[GitBox <gi...@apache.org>]

ralf0131 edited a comment on issue #2435: Summary of several issues of graceful shutdown
URL: https://github.com/apache/incubator-dubbo/issues/2435#issuecomment-421555255
 
 
   确实我看到2.6.3版本有相关修改，基本和我描述思路一致，有几个问题问题：
   > 1.个人觉得思路有点偏差，最好的思路是将dubbo停机完全放到spring事件中，最好不要搞框架停机hook，额外增加复杂性，还做不好。比如2.6.3版本DubboBootstrap中registerShutHook，单纯注册dubbo的停机hook没太大的意义，还是需要开发注册spring的停机hook，本身hook执行是无序的，可能导致spring先关闭。在我们的使用场景中，基本都是加载dubbo相关xml启动的。
   
   Please consider scenarios where Dubbo may be used without Spring.
   
   > 2. 为什么通过ApplicationContextInitializer注册的方式，需要考虑web.xml加载问题，而且也不针对web项目吧。为什么不在类似于ApplicationConfig类中直接implements ApplicaionListener，监听close事件，对于使用者来说不需要配置，更简单。
   
   Again, please consider scenarios where Dubbo may be used without Spring. Please note that the core design principles of Dubbo is that the core should not have strong dependency to other framework like Spring.
   
   > 3.在destroyAll方法中，之前版本为了注册中心通知延迟，故意sleep了一段时间，2.6.3版本删除了相关代码逻辑，请问是怎么考虑的？
   
   Which destroyAll method do you exactly mean?  I can't find the logic you mentioned.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org