You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/14 18:39:49 UTC
[GitHub] [airflow] mik-laj opened a new issue #13069: Handwritten argument parser in prepare_provider_packages.py
mik-laj opened a new issue #13069:
URL: https://github.com/apache/airflow/issues/13069
Hello @potiuk
I believe you wrote this script - [`prepare_provider_packages.py`](https://github.com/apache/airflow/blob/master/dev/provider_packages/prepare_provider_packages.py).
I am wondering if there is any reason why you did not use the standard library - [`argument.ArgumentParser`](https://docs.python.org/3/library/argparse.html) in this script?
https://docs.python.org/3/library/argparse.html
https://github.com/apache/airflow/blob/master/dev/provider_packages/prepare_provider_packages.py#L1518-L1552
This makes the code overly complex and, by the way, more prone to errors e.g. ``usage()`` method describes the `--version-suffix-for-pypi`` parameter, but we changed its name to` --version-suffix`.
What do you think to rewrite this script to use the standard library? Do we have a requirement that prevents this? I think of something similar to [my gist](https://gist.github.com/mik-laj/ff008718fc6cec9fe929731b8c62d6f8).
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
<!--
IMPORTANT!!!
PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
Please complete the next sections or the issue will be closed.
These questions are the first thing we need to know to understand the context.
-->
**Apache Airflow version**:
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
**Environment**:
- **Cloud provider or hardware configuration**:
- **OS** (e.g. from /etc/os-release):
- **Kernel** (e.g. `uname -a`):
- **Install tools**:
- **Others**:
**What happened**:
<!-- (please include exact error messages if you can) -->
**What you expected to happen**:
<!-- What do you think went wrong? -->
**How to reproduce it**:
<!---
As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
## Install minikube/kind
- Minikube https://minikube.sigs.k8s.io/docs/start/
- Kind https://kind.sigs.k8s.io/docs/user/quick-start/
If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
You can include images using the .md style of
To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
--->
**Anything else we need to know**:
<!--
How often does this problem occur? Once? Every time etc?
Any relevant logs to include? Put them here in side a detail tag:
<details><summary>x.log</summary> lots of stuff </details>
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #13069: Handwritten argument parser in prepare_provider_packages.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13069:
URL: https://github.com/apache/airflow/issues/13069#issuecomment-744708333
Feel free to rewrite it :). No problem with that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #13069: Rewrite handwritten argument parser in prepare_provider_packages.py
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #13069:
URL: https://github.com/apache/airflow/issues/13069#issuecomment-745149443
@debodirno I assigned you to this ticket 🐈⬛ 🎄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #13069: Rewrite handwritten argument parser in prepare_provider_packages.py
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #13069:
URL: https://github.com/apache/airflow/issues/13069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] debodirno commented on issue #13069: Rewrite handwritten argument parser in prepare_provider_packages.py
Posted by GitBox <gi...@apache.org>.
debodirno commented on issue #13069:
URL: https://github.com/apache/airflow/issues/13069#issuecomment-745042158
Can I take this up @potiuk and @mik-laj?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #13069: Handwritten argument parser in prepare_provider_packages.py
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #13069:
URL: https://github.com/apache/airflow/issues/13069#issuecomment-744709498
It simply grew from a simple script where there was more parameters. But my goal now is that more people take part in writing those scripts not only me. I marked it as good first issue, and if you feel like you would like to rewrite it - go ahead. I am happy to review it and guide you (or anyone else who would like to take on that task).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org