You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by br...@apache.org on 2015/08/14 21:42:04 UTC

[2/3] allura git commit: [#7953] add **kw to api endpoints so ?access_token=X doesn't error, and some more ajax endpoints to make the test happy

[#7953] add **kw to api endpoints so ?access_token=X doesn't error, and some more ajax endpoints to make the test happy


Project: http://git-wip-us.apache.org/repos/asf/allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/allura/commit/24b410ce
Tree: http://git-wip-us.apache.org/repos/asf/allura/tree/24b410ce
Diff: http://git-wip-us.apache.org/repos/asf/allura/diff/24b410ce

Branch: refs/heads/db/7953
Commit: 24b410ceb4238978a4e56be650fc94968f35b25e
Parents: 31ba21a
Author: Dave Brondsema <da...@brondsema.net>
Authored: Fri Aug 14 15:36:37 2015 -0400
Committer: Dave Brondsema <da...@brondsema.net>
Committed: Fri Aug 14 15:36:37 2015 -0400

----------------------------------------------------------------------
 Allura/allura/app.py                      |  4 ++--
 Allura/allura/controllers/project.py      | 16 ++++++++--------
 Allura/allura/controllers/repository.py   |  6 +++---
 Allura/allura/controllers/rest.py         |  6 +++---
 Allura/allura/controllers/site_admin.py   |  2 +-
 Allura/allura/webhooks.py                 |  2 +-
 ForgeShortUrl/forgeshorturl/main.py       |  2 +-
 ForgeTracker/forgetracker/tracker_main.py | 10 +++++-----
 ForgeWiki/forgewiki/wiki_main.py          |  4 ++--
 9 files changed, 26 insertions(+), 26 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/allura/blob/24b410ce/Allura/allura/app.py
----------------------------------------------------------------------
diff --git a/Allura/allura/app.py b/Allura/allura/app.py
index 62b82fe..1d02ffa 100644
--- a/Allura/allura/app.py
+++ b/Allura/allura/app.py
@@ -747,7 +747,7 @@ class DefaultAdminController(BaseController):
 
     @expose('json:')
     @require_post()
-    def block_user(self, username, perm, reason=None):
+    def block_user(self, username, perm, reason=None, **kw):
         if not username or not perm:
             return dict(error='Enter username')
         user = model.User.by_username(username)
@@ -764,7 +764,7 @@ class DefaultAdminController(BaseController):
                    perm=V.UnicodeString()))
     @expose('json:')
     @require_post()
-    def unblock_user(self, user_id=None, perm=None):
+    def unblock_user(self, user_id=None, perm=None, **kw):
         try:
             user_id = map(ObjectId, user_id)
         except InvalidId:

http://git-wip-us.apache.org/repos/asf/allura/blob/24b410ce/Allura/allura/controllers/project.py
----------------------------------------------------------------------
diff --git a/Allura/allura/controllers/project.py b/Allura/allura/controllers/project.py
index 4526e62..20d9f63 100644
--- a/Allura/allura/controllers/project.py
+++ b/Allura/allura/controllers/project.py
@@ -199,7 +199,7 @@ class NeighborhoodController(object):
         return {}
 
     @expose('json:')
-    def verify_phone(self, number):
+    def verify_phone(self, number, **kw):
         p = plugin.ProjectRegistrationProvider.get()
         result = p.verify_phone(c.user, number)
         request_id = result.pop('request_id', None)
@@ -214,7 +214,7 @@ class NeighborhoodController(object):
         return result
 
     @expose('json:')
-    def check_phone_verification(self, pin):
+    def check_phone_verification(self, pin, **kw):
         p = plugin.ProjectRegistrationProvider.get()
         request_id = session.get('phone_verification.request_id')
         number_hash = session.get('phone_verification.number_hash')
@@ -225,7 +225,7 @@ class NeighborhoodController(object):
         return res
 
     @expose('json:')
-    def suggest_name(self, project_name=''):
+    def suggest_name(self, project_name='', **kw):
         provider = plugin.ProjectRegistrationProvider.get()
         return dict(suggested_name=provider.suggest_name(project_name,
                                                          self.neighborhood))
@@ -295,7 +295,7 @@ class NeighborhoodController(object):
         return icon.serve()
 
     @expose('json:')
-    def users(self):
+    def users(self, **kw):
         p = self.neighborhood.neighborhood_project
         return {
             'options': [{
@@ -380,7 +380,7 @@ class ProjectController(FeedController):
         self._list = ToolListController()
 
     @expose('json:')
-    def _nav(self):
+    def _nav(self, **kw):
         menu = []
         for s in c.project.grouped_navbar_entries():
             entry = dict(name=s.label, url=s.url,
@@ -480,7 +480,7 @@ class ProjectController(FeedController):
             redirect(g.forge_static('images/user.png'))
 
     @expose('json:')
-    def user_search(self, term=''):
+    def user_search(self, term='', **kw):
         if len(term) < 3:
             raise exc.HTTPBadRequest('"term" param must be at least length 3')
         named_roles = RoleCache(
@@ -501,7 +501,7 @@ class ProjectController(FeedController):
                 for u in users])
 
     @expose('json:')
-    def users(self):
+    def users(self, **kw):
         users = c.project.users()
         if c.user and c.user in users:
             users.remove(c.user)
@@ -604,7 +604,7 @@ class NeighborhoodAdminController(object):
         return dict(neighborhood=self.neighborhood)
 
     @expose('json:')
-    def project_search(self, term=''):
+    def project_search(self, term='', **kw):
         if len(term) < 3:
             raise exc.HTTPBadRequest('"term" param must be at least length 3')
         project_regex = re.compile('(?i)%s' % re.escape(term))

http://git-wip-us.apache.org/repos/asf/allura/blob/24b410ce/Allura/allura/controllers/repository.py
----------------------------------------------------------------------
diff --git a/Allura/allura/controllers/repository.py b/Allura/allura/controllers/repository.py
index 699931b..b51d3c7 100644
--- a/Allura/allura/controllers/repository.py
+++ b/Allura/allura/controllers/repository.py
@@ -469,15 +469,15 @@ class MergeRequestController(object):
         redirect(self.req.url())
 
     @expose('json:')
-    def merge_task_status(self):
+    def merge_task_status(self, **kw):
         return {'status': self.req.merge_task_status()}
 
     @expose('json:')
-    def can_merge_task_status(self):
+    def can_merge_task_status(self, **kw):
         return {'status': self.req.can_merge_task_status()}
 
     @expose('json:')
-    def can_merge_result(self):
+    def can_merge_result(self, **kw):
         """Return result from the cache. Used by js, after task was completed."""
         return {'can_merge': self.req.can_merge()}
 

http://git-wip-us.apache.org/repos/asf/allura/blob/24b410ce/Allura/allura/controllers/rest.py
----------------------------------------------------------------------
diff --git a/Allura/allura/controllers/rest.py b/Allura/allura/controllers/rest.py
index df5b0ea..2578fa2 100644
--- a/Allura/allura/controllers/rest.py
+++ b/Allura/allura/controllers/rest.py
@@ -265,7 +265,7 @@ def rest_has_access(obj, user, perm):
 
 class AppRestControllerMixin(object):
     @expose('json:')
-    def has_access(self, user, perm):
+    def has_access(self, user, perm, **kw):
         return rest_has_access(c.app, user, perm)
 
 
@@ -275,7 +275,7 @@ class NeighborhoodRestController(object):
         self._neighborhood = neighborhood
 
     @expose('json:')
-    def has_access(self, user, perm):
+    def has_access(self, user, perm, **kw):
         return rest_has_access(self._neighborhood, user, perm)
 
     @expose()
@@ -335,5 +335,5 @@ class ProjectRestController(object):
         return c.project.__json__()
 
     @expose('json:')
-    def has_access(self, user, perm):
+    def has_access(self, user, perm, **kw):
         return rest_has_access(c.project, user, perm)

http://git-wip-us.apache.org/repos/asf/allura/blob/24b410ce/Allura/allura/controllers/site_admin.py
----------------------------------------------------------------------
diff --git a/Allura/allura/controllers/site_admin.py b/Allura/allura/controllers/site_admin.py
index ee47274..8bcd192 100644
--- a/Allura/allura/controllers/site_admin.py
+++ b/Allura/allura/controllers/site_admin.py
@@ -434,7 +434,7 @@ class TaskManagerController(object):
         redirect('../view/%s' % task._id)
 
     @expose('json:')
-    def task_doc(self, task_name):
+    def task_doc(self, task_name, **kw):
         """Return a task's docstring"""
         error, doc = None, None
         try:

http://git-wip-us.apache.org/repos/asf/allura/blob/24b410ce/Allura/allura/webhooks.py
----------------------------------------------------------------------
diff --git a/Allura/allura/webhooks.py b/Allura/allura/webhooks.py
index c42be86..1447802 100644
--- a/Allura/allura/webhooks.py
+++ b/Allura/allura/webhooks.py
@@ -165,7 +165,7 @@ class WebhookController(BaseController):
 
     @expose('json:')
     @require_post()
-    def delete(self, webhook):
+    def delete(self, webhook, **kw):
         form = self.edit_form(self.sender, self.app)
         try:
             wh = form.fields['webhook'].to_python(webhook)

http://git-wip-us.apache.org/repos/asf/allura/blob/24b410ce/ForgeShortUrl/forgeshorturl/main.py
----------------------------------------------------------------------
diff --git a/ForgeShortUrl/forgeshorturl/main.py b/ForgeShortUrl/forgeshorturl/main.py
index b259e92..5a42ea1 100644
--- a/ForgeShortUrl/forgeshorturl/main.py
+++ b/ForgeShortUrl/forgeshorturl/main.py
@@ -204,7 +204,7 @@ class ShortURLAdminController(DefaultAdminController):
 
     @without_trailing_slash
     @expose('json:')
-    def remove(self, shorturl):
+    def remove(self, shorturl, **kw):
         require_access(self.app, 'update')
         ShortUrl.query.remove({
             'app_config_id': self.app.config._id,

http://git-wip-us.apache.org/repos/asf/allura/blob/24b410ce/ForgeTracker/forgetracker/tracker_main.py
----------------------------------------------------------------------
diff --git a/ForgeTracker/forgetracker/tracker_main.py b/ForgeTracker/forgetracker/tracker_main.py
index ddf570d..47a5d8b 100644
--- a/ForgeTracker/forgetracker/tracker_main.py
+++ b/ForgeTracker/forgetracker/tracker_main.py
@@ -1093,7 +1093,7 @@ class RootController(BaseController, FeedController):
     @expose('json:')
     @require_post()
     @validate(W.subscribe_form)
-    def subscribe(self, subscribe=None, unsubscribe=None):
+    def subscribe(self, subscribe=None, unsubscribe=None, **kw):
         if subscribe:
             M.Mailbox.subscribe(type='direct')
         elif unsubscribe:
@@ -1418,7 +1418,7 @@ class TicketController(BaseController, FeedController):
     @without_trailing_slash
     @expose('json:')
     @require_post()
-    def delete(self):
+    def delete(self, **kw):
         require_access(self.ticket, 'delete')
         M.Shortlink.query.remove(dict(ref_id=self.ticket.index_id()))
         self.ticket.deleted = True
@@ -1431,7 +1431,7 @@ class TicketController(BaseController, FeedController):
     @without_trailing_slash
     @expose('json:')
     @require_post()
-    def undelete(self):
+    def undelete(self, **kw):
         require_access(self.ticket, 'delete')
         self.ticket.deleted = False
         self.ticket.summary = re.sub(
@@ -1527,7 +1527,7 @@ class TicketController(BaseController, FeedController):
     @expose('json:')
     @require_post()
     @validate(W.subscribe_form)
-    def subscribe(self, subscribe=None, unsubscribe=None):
+    def subscribe(self, subscribe=None, unsubscribe=None, **kw):
         if subscribe:
             self.ticket.subscribe(type='direct')
         elif unsubscribe:
@@ -1540,7 +1540,7 @@ class TicketController(BaseController, FeedController):
 
     @expose('json:')
     @require_post()
-    def vote(self, vote):
+    def vote(self, vote, **kw):
         require_authenticated()
         require_access(self.ticket, 'post')
         status = 'ok'

http://git-wip-us.apache.org/repos/asf/allura/blob/24b410ce/ForgeWiki/forgewiki/wiki_main.py
----------------------------------------------------------------------
diff --git a/ForgeWiki/forgewiki/wiki_main.py b/ForgeWiki/forgewiki/wiki_main.py
index 513b1e2..d23cff8 100644
--- a/ForgeWiki/forgewiki/wiki_main.py
+++ b/ForgeWiki/forgewiki/wiki_main.py
@@ -587,7 +587,7 @@ class PageController(BaseController, FeedController):
     @without_trailing_slash
     @expose('json:')
     @require_post()
-    def delete(self):
+    def delete(self, **kw):
         require_access(self.page, 'delete')
         self.page.delete()
         return dict(location='../' + self.page.title + '/?deleted=True')
@@ -595,7 +595,7 @@ class PageController(BaseController, FeedController):
     @without_trailing_slash
     @expose('json:')
     @require_post()
-    def undelete(self):
+    def undelete(self, **kw):
         require_access(self.page, 'delete')
         self.page.deleted = False
         M.Shortlink.from_artifact(self.page)