You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/14 22:02:14 UTC
[GitHub] [spark] sumeetgajjar opened a new pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
sumeetgajjar opened a new pull request #32912:
URL: https://github.com/apache/spark/pull/32912
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error message, please read the guideline first:
https://spark.apache.org/error-message-guidelines.html
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Remove commons-httpclient as a direct dependency.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Spark is pulling in commons-httpclient as a dependency directly. commons-httpclient went EOL years ago and there are most likely CVEs not being reported against it, thus we should remove it.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
- Existing unittests
- Checked the dependency tree before and after introducing the changes
Before:
```
./build/mvn dependency:tree | grep -i "commons-httpclient"
Using `mvn` from path: /Users/sumeet.gajjar/cloudera/upstream-spark/build/apache-maven-3.6.3/bin/mvn
[INFO] +- commons-httpclient:commons-httpclient:jar:3.1:compile
[INFO] | +- commons-httpclient:commons-httpclient:jar:3.1:provided
```
After
```
./build/mvn dependency:tree | grep -i "commons-httpclient"
Using `mvn` from path: /Users/sumeet.gajjar/cloudera/upstream-spark/build/apache-maven-3.6.3/bin/mvn
```
P.S. Reopening this since [spark upgraded](https://github.com/apache/spark/commit/463daabd5afd9abfb8027ebcb2e608f169ad1e40) its `hive.version` to `2.3.9` which does not have a dependency on `commons-httpclient`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sumeetgajjar commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sumeetgajjar commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861095609
> Please also remove commons-httpclient in LICENSE-binary:
>
> https://github.com/apache/spark/blob/b52d47a920c24826b45d9d8c0fb4e59fc119479b/LICENSE-binary#L240
Hi @wangyum, thank you for the comment, but I have already removed it from the LICENSE-binary
The following snippet will yield empty output
```
curl "https://raw.githubusercontent.com/sumeetgajjar/spark/SPARK-35429/LICENSE-binary" | grep -i "commons-httpclient:commons-httpclient"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861128653
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44312/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861150658
**[Test build #139792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139792/testReport)** for PR 32912 at commit [`3c0eb47`](https://github.com/apache/spark/commit/3c0eb4763bf74a67eabb21fc02565790d9505ee0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861131502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861024710
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861182466
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44318/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #32912:
URL: https://github.com/apache/spark/pull/32912#discussion_r651413299
##########
File path: LICENSE-binary
##########
@@ -237,7 +237,6 @@ org.apache.spark:spark-network-shuffle_2.12
org.apache.spark:spark-sketch_2.12
org.apache.spark:spark-tags_2.12
org.apache.spark:spark-unsafe_2.12
-commons-httpclient:commons-httpclient
Review comment:
Sorry. Hadoop-2.7 need this:
```
[INFO] +- org.apache.hadoop:hadoop-client:jar:2.7.4:compile
[INFO] | +- org.apache.hadoop:hadoop-common:jar:2.7.4:compile
[INFO] | | +- commons-cli:commons-cli:jar:1.2:compile
[INFO] | | +- xmlenc:xmlenc:jar:0.52:compile
[INFO] | | +- commons-httpclient:commons-httpclient:jar:3.1:compile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #32912:
URL: https://github.com/apache/spark/pull/32912#discussion_r651416912
##########
File path: LICENSE-binary
##########
@@ -237,7 +237,6 @@ org.apache.spark:spark-network-shuffle_2.12
org.apache.spark:spark-sketch_2.12
org.apache.spark:spark-tags_2.12
org.apache.spark:spark-unsafe_2.12
-commons-httpclient:commons-httpclient
Review comment:
We can also move the dependency under `hadoop-3.2` profile so Spark won't package it by default, although I'm not sure whether that helps much with the issue the PR is trying to address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861152778
**[Test build #139786 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139786/testReport)** for PR 32912 at commit [`483c6fb`](https://github.com/apache/spark/commit/483c6fbf14a9b499734d6f4fc75c2542c7cd5c02).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sumeetgajjar commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sumeetgajjar commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861096164
> Did you run `dev/test-dependencies.sh --replace-manifest` to update `dev/deps` or do it manually?
Sorry, I didn't know about this script, thus I had removed it manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32912: [SPARK-35429][CORE][test-hadoop2.7] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861758270
Retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sumeetgajjar commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sumeetgajjar commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861613413
> So hadoop-2.7 still works because it will pull it in transitively via hadoop-2.7 dependencies?
Yes, @srowen, that is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861112107
**[Test build #139786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139786/testReport)** for PR 32912 at commit [`483c6fb`](https://github.com/apache/spark/commit/483c6fbf14a9b499734d6f4fc75c2542c7cd5c02).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861091647
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44311/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sumeetgajjar commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sumeetgajjar commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861024888
cc: @dongjoon-hyun, @sunchao, @wangyum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32912: [SPARK-35429][CORE][test-hadoop2.7] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861758593
Thank you for updating, @sumeetgajjar . As a final test, I triggered a Jenkin run with `hadoop-2.7` profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861854376
Oh, it's too bad. This PR is reusing a closed JIRA ID, SPARK-35429.
I couldn't update the field `Resolution`. So, only `Fixed Version` and `Assignee` fields are updated.
<img width="246" alt="Screen Shot 2021-06-15 at 2 47 17 PM" src="https://user-images.githubusercontent.com/9700541/122127834-a0464a80-cde8-11eb-8175-9b47fda5ab5a.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861198912
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139792/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sumeetgajjar commented on a change in pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sumeetgajjar commented on a change in pull request #32912:
URL: https://github.com/apache/spark/pull/32912#discussion_r651394238
##########
File path: dev/deps/spark-deps-hadoop-2.7-hive-2.3
##########
@@ -43,7 +43,6 @@ commons-configuration/1.6//commons-configuration-1.6.jar
commons-crypto/1.1.0//commons-crypto-1.1.0.jar
commons-dbcp/1.4//commons-dbcp-1.4.jar
commons-digester/1.8//commons-digester-1.8.jar
-commons-httpclient/3.1//commons-httpclient-3.1.jar
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861197977
**[Test build #139792 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139792/testReport)** for PR 32912 at commit [`3c0eb47`](https://github.com/apache/spark/commit/3c0eb4763bf74a67eabb21fc02565790d9505ee0).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861283903
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44323/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861149796
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44312/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861112107
**[Test build #139786 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139786/testReport)** for PR 32912 at commit [`483c6fb`](https://github.com/apache/spark/commit/483c6fbf14a9b499734d6f4fc75c2542c7cd5c02).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861209632
retest this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861871509
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139826/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #32912:
URL: https://github.com/apache/spark/pull/32912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861870445
**[Test build #139826 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139826/testReport)** for PR 32912 at commit [`3c0eb47`](https://github.com/apache/spark/commit/3c0eb4763bf74a67eabb21fc02565790d9505ee0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861369339
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139797/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861139716
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44312/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861367891
**[Test build #139797 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139797/testReport)** for PR 32912 at commit [`3c0eb47`](https://github.com/apache/spark/commit/3c0eb4763bf74a67eabb21fc02565790d9505ee0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861871509
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139826/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861195981
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44318/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE][test-hadoop2.7] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861759913
**[Test build #139826 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139826/testReport)** for PR 32912 at commit [`3c0eb47`](https://github.com/apache/spark/commit/3c0eb4763bf74a67eabb21fc02565790d9505ee0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861195981
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44318/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861131495
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139785/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861024710
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861090198
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44311/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861235546
**[Test build #139797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139797/testReport)** for PR 32912 at commit [`3c0eb47`](https://github.com/apache/spark/commit/3c0eb4763bf74a67eabb21fc02565790d9505ee0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE][test-hadoop2.7] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861821475
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44354/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861283903
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44323/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32912: [SPARK-35429][CORE][test-hadoop2.7] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861827924
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44354/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32912: [SPARK-35429][CORE][test-hadoop2.7] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861827924
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44354/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861413128
cc @srowen too fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861283860
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44323/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861091647
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44311/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861369339
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139797/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #32912:
URL: https://github.com/apache/spark/pull/32912#discussion_r651486359
##########
File path: LICENSE-binary
##########
@@ -237,7 +237,6 @@ org.apache.spark:spark-network-shuffle_2.12
org.apache.spark:spark-sketch_2.12
org.apache.spark:spark-tags_2.12
org.apache.spark:spark-unsafe_2.12
-commons-httpclient:commons-httpclient
Review comment:
Spark currently support two Hadoop profiles: `hadoop-2.7` and `hadoop-3.2`. Since this library is only used in the former, we could remove it from the latter so it at least won't be used and distributed. You can check `hadoop-3.2` profile in `pom.xml` to see how it handles Hadoop 3.x specific dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861073066
**[Test build #139785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139785/testReport)** for PR 32912 at commit [`2b52fac`](https://github.com/apache/spark/commit/2b52fac5687815d6cbb134cb4064016107dd7da0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32912:
URL: https://github.com/apache/spark/pull/32912#discussion_r651361613
##########
File path: dev/deps/spark-deps-hadoop-2.7-hive-2.3
##########
@@ -43,7 +43,6 @@ commons-configuration/1.6//commons-configuration-1.6.jar
commons-crypto/1.1.0//commons-crypto-1.1.0.jar
commons-dbcp/1.4//commons-dbcp-1.4.jar
commons-digester/1.8//commons-digester-1.8.jar
-commons-httpclient/3.1//commons-httpclient-3.1.jar
Review comment:
Could you try `dev/test-dependencies.sh --replace-manifest` and find which one is using this still?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861127880
**[Test build #139785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139785/testReport)** for PR 32912 at commit [`2b52fac`](https://github.com/apache/spark/commit/2b52fac5687815d6cbb134cb4064016107dd7da0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861153633
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139786/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861759913
**[Test build #139826 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139826/testReport)** for PR 32912 at commit [`3c0eb47`](https://github.com/apache/spark/commit/3c0eb4763bf74a67eabb21fc02565790d9505ee0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sumeetgajjar commented on a change in pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sumeetgajjar commented on a change in pull request #32912:
URL: https://github.com/apache/spark/pull/32912#discussion_r651375777
##########
File path: dev/deps/spark-deps-hadoop-2.7-hive-2.3
##########
@@ -43,7 +43,6 @@ commons-configuration/1.6//commons-configuration-1.6.jar
commons-crypto/1.1.0//commons-crypto-1.1.0.jar
commons-dbcp/1.4//commons-dbcp-1.4.jar
commons-digester/1.8//commons-digester-1.8.jar
-commons-httpclient/3.1//commons-httpclient-3.1.jar
Review comment:
I ran the above command and it seems `spark-deps-hadoop-2.7-hive-2.3` is still using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861153633
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139786/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sumeetgajjar commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sumeetgajjar commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861667373
> Please revise the PR title and description by mentioning the limitation of this PR, @sumeetgajjar .
>
> `Hadoop 3.2 profile distribution removes commons-httpclient dependency while Hadoop 2.7 profile distribution still has it`
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sumeetgajjar commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sumeetgajjar commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-862050777
Thank you @dongjoon-hyun @wangyum and @sunchao for the quick review and comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861235546
**[Test build #139797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139797/testReport)** for PR 32912 at commit [`3c0eb47`](https://github.com/apache/spark/commit/3c0eb4763bf74a67eabb21fc02565790d9505ee0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32912: [SPARK-35429][CORE][test-hadoop2.7] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861853204
Scala/Java test passed and currently PySpark test is running. I'll merge this because the other tests are irrelevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sumeetgajjar commented on a change in pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sumeetgajjar commented on a change in pull request #32912:
URL: https://github.com/apache/spark/pull/32912#discussion_r651436047
##########
File path: LICENSE-binary
##########
@@ -237,7 +237,6 @@ org.apache.spark:spark-network-shuffle_2.12
org.apache.spark:spark-sketch_2.12
org.apache.spark:spark-tags_2.12
org.apache.spark:spark-unsafe_2.12
-commons-httpclient:commons-httpclient
Review comment:
Sorry, I don't understand the above comment, can you please elaborate on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861451097
So hadoop-2.7 still works because it will pull it in transitively via hadoop-2.7 dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861072034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861198912
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139792/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861073066
**[Test build #139785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139785/testReport)** for PR 32912 at commit [`2b52fac`](https://github.com/apache/spark/commit/2b52fac5687815d6cbb134cb4064016107dd7da0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861131502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sumeetgajjar commented on a change in pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sumeetgajjar commented on a change in pull request #32912:
URL: https://github.com/apache/spark/pull/32912#discussion_r651382416
##########
File path: dev/deps/spark-deps-hadoop-2.7-hive-2.3
##########
@@ -43,7 +43,6 @@ commons-configuration/1.6//commons-configuration-1.6.jar
commons-crypto/1.1.0//commons-crypto-1.1.0.jar
commons-dbcp/1.4//commons-dbcp-1.4.jar
commons-digester/1.8//commons-digester-1.8.jar
-commons-httpclient/3.1//commons-httpclient-3.1.jar
Review comment:
I generated the dependency tree for hadoop-2.7 profile, Hadoop-client lists it as a compile dependency
```
+- org.apache.hadoop:hadoop-client:jar:2.7.4:compile
[INFO] | +- org.apache.hadoop:hadoop-common:jar:2.7.4:compile
[INFO] | | +- commons-cli:commons-cli:jar:1.2:compile
[INFO] | | +- xmlenc:xmlenc:jar:0.52:compile
[INFO] | | +- commons-httpclient:commons-httpclient:jar:3.1:compile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861854376
Oh, it's too bad. This PR is reusing a closed JIRA ID, SPARK-35429.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861168347
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44318/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on a change in pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
sunchao commented on a change in pull request #32912:
URL: https://github.com/apache/spark/pull/32912#discussion_r651416136
##########
File path: LICENSE-binary
##########
@@ -237,7 +237,6 @@ org.apache.spark:spark-network-shuffle_2.12
org.apache.spark:spark-sketch_2.12
org.apache.spark:spark-tags_2.12
org.apache.spark:spark-unsafe_2.12
-commons-httpclient:commons-httpclient
Review comment:
oh well ... seems still can't get rid of this then. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32912: [SPARK-35429][CORE][test-hadoop2.7] Remove commons-httpclient from Hadoop-3.2 profile due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861800349
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44354/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32912: [SPARK-35429][CORE] Remove commons-httpclient due to EOL and CVEs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32912:
URL: https://github.com/apache/spark/pull/32912#issuecomment-861150658
**[Test build #139792 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139792/testReport)** for PR 32912 at commit [`3c0eb47`](https://github.com/apache/spark/commit/3c0eb4763bf74a67eabb21fc02565790d9505ee0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org