You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/11/15 00:50:06 UTC
Review Request: SQOOP-681 Split configuration in Generic JDBC connector
between job and connection
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8057/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've decoupled connection and import options and moved handling of output directory to the framework space rather than connector. Unfortunately I'm not able to get table name on framework level, so I've reverted to require this parameter from user in all cases.
This addresses bug SQOOP-681.
https://issues.apache.org/jira/browse/SQOOP-681
Diffs
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java e991734ce579256826fb59b2338b554d9e06c119
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 9199e755fdd24352e7c696722a5fd5b755d373e9
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 39f19f5c8b0fc48846dce4e0b0f57f4834f45cf1
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionConfiguration.java 5057cf57b36298c69c9ac2b473673599100071e0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportJobConfiguration.java c32b0663de509fc921f4690f36ff6c4b562b0cae
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportTableForm.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportJobConfiguration.java 11b1c5f54b59987ecda890a9fba307d0ba17dcfd
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java PRE-CREATION
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/TableForm.java 9eb6a013d695fd7ccd99f3aa544c8321ded32b8f
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java 8dbfb4bc5d0a55d0c92d002c656e936ede3fd0de
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java 0c7be4bfdd3e6a3ce44ab02c92113f8367bddd0c
Diff: https://reviews.apache.org/r/8057/diff/
Testing
-------
Tests are passing and I've tested it on real cluster.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-681 Split configuration in Generic JDBC connector
between job and connection
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8057/#review13495
-----------------------------------------------------------
Ship it!
Ship It!
- Bilung Lee
On Nov. 14, 2012, 11:50 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8057/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2012, 11:50 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've decoupled connection and import options and moved handling of output directory to the framework space rather than connector. Unfortunately I'm not able to get table name on framework level, so I've reverted to require this parameter from user in all cases.
>
>
> This addresses bug SQOOP-681.
> https://issues.apache.org/jira/browse/SQOOP-681
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java e991734ce579256826fb59b2338b554d9e06c119
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 9199e755fdd24352e7c696722a5fd5b755d373e9
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 39f19f5c8b0fc48846dce4e0b0f57f4834f45cf1
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ConnectionConfiguration.java 5057cf57b36298c69c9ac2b473673599100071e0
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportJobConfiguration.java c32b0663de509fc921f4690f36ff6c4b562b0cae
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ExportTableForm.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportJobConfiguration.java 11b1c5f54b59987ecda890a9fba307d0ba17dcfd
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java PRE-CREATION
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/TableForm.java 9eb6a013d695fd7ccd99f3aa544c8321ded32b8f
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java 8dbfb4bc5d0a55d0c92d002c656e936ede3fd0de
> connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java 0c7be4bfdd3e6a3ce44ab02c92113f8367bddd0c
>
> Diff: https://reviews.apache.org/r/8057/diff/
>
>
> Testing
> -------
>
> Tests are passing and I've tested it on real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>