You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Sian January (JIRA)" <ji...@apache.org> on 2006/12/21 17:00:21 UTC
[jira] Created: (HARMONY-2840) [classlib] [luni] Some inner classes
could be removed or changed to static inner classes (FindBugs)
[classlib] [luni] Some inner classes could be removed or changed to static inner classes (FindBugs)
---------------------------------------------------------------------------------------------------
Key: HARMONY-2840
URL: http://issues.apache.org/jira/browse/HARMONY-2840
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Sian January
Priority: Minor
A static inner class takes up less space in memory, so if an inner class doesn't use the reference to the parent object it makes sense to turn it into a static inner class. I have also found a couple of instances where an inner class has been used as a lock object, but there didn't seem to be any reason why the synchronization wasn't done on the parent object, so this bug also addresses that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2840) [classlib] [luni] Some inner
classes could be removed or changed to static inner classes (FindBugs)
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2840?page=comments#action_12460482 ]
Sian January commented on HARMONY-2840:
---------------------------------------
Thanks Tim - patch applied as expected.
> [classlib] [luni] Some inner classes could be removed or changed to static inner classes (FindBugs)
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2840
> URL: http://issues.apache.org/jira/browse/HARMONY-2840
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: luni_patch.txt
>
>
> A static inner class takes up less space in memory, so if an inner class doesn't use the reference to the parent object it makes sense to turn it into a static inner class. I have also found a couple of instances where an inner class has been used as a lock object, but there didn't seem to be any reason why the synchronization wasn't done on the parent object, so this bug also addresses that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2840) [classlib] [luni] Some inner classes
could be removed or changed to static inner classes (FindBugs)
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2840?page=all ]
Tim Ellison closed HARMONY-2840.
--------------------------------
Verified by Sian.
> [classlib] [luni] Some inner classes could be removed or changed to static inner classes (FindBugs)
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2840
> URL: http://issues.apache.org/jira/browse/HARMONY-2840
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: luni_patch.txt
>
>
> A static inner class takes up less space in memory, so if an inner class doesn't use the reference to the parent object it makes sense to turn it into a static inner class. I have also found a couple of instances where an inner class has been used as a lock object, but there didn't seem to be any reason why the synchronization wasn't done on the parent object, so this bug also addresses that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-2840) [classlib] [luni] Some inner
classes could be removed or changed to static inner classes (FindBugs)
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2840?page=all ]
Tim Ellison reassigned HARMONY-2840:
------------------------------------
Assignee: Tim Ellison
> [classlib] [luni] Some inner classes could be removed or changed to static inner classes (FindBugs)
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2840
> URL: http://issues.apache.org/jira/browse/HARMONY-2840
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: luni_patch.txt
>
>
> A static inner class takes up less space in memory, so if an inner class doesn't use the reference to the parent object it makes sense to turn it into a static inner class. I have also found a couple of instances where an inner class has been used as a lock object, but there didn't seem to be any reason why the synchronization wasn't done on the parent object, so this bug also addresses that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2840) [classlib] [luni] Some inner classes
could be removed or changed to static inner classes (FindBugs)
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2840?page=all ]
Sian January updated HARMONY-2840:
----------------------------------
Attachment: luni_patch.txt
Patch attached
> [classlib] [luni] Some inner classes could be removed or changed to static inner classes (FindBugs)
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2840
> URL: http://issues.apache.org/jira/browse/HARMONY-2840
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: luni_patch.txt
>
>
> A static inner class takes up less space in memory, so if an inner class doesn't use the reference to the parent object it makes sense to turn it into a static inner class. I have also found a couple of instances where an inner class has been used as a lock object, but there didn't seem to be any reason why the synchronization wasn't done on the parent object, so this bug also addresses that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-2840) [classlib] [luni] Some inner
classes could be removed or changed to static inner classes (FindBugs)
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2840?page=all ]
Tim Ellison resolved HARMONY-2840.
----------------------------------
Resolution: Fixed
Thanks Sian,
Slightly modified version of patch applied to LUNI module at repo revision r489652.
Please check that the patch was applied as you expected.
> [classlib] [luni] Some inner classes could be removed or changed to static inner classes (FindBugs)
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2840
> URL: http://issues.apache.org/jira/browse/HARMONY-2840
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: luni_patch.txt
>
>
> A static inner class takes up less space in memory, so if an inner class doesn't use the reference to the parent object it makes sense to turn it into a static inner class. I have also found a couple of instances where an inner class has been used as a lock object, but there didn't seem to be any reason why the synchronization wasn't done on the parent object, so this bug also addresses that.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira