You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2006/08/07 13:18:13 UTC

[jira] Created: (HTTPCLIENT-594) HttpMethodBase#abort variable mistakenly declared transient instead of volatile

HttpMethodBase#abort variable mistakenly declared transient instead of volatile
-------------------------------------------------------------------------------

                 Key: HTTPCLIENT-594
                 URL: http://issues.apache.org/jira/browse/HTTPCLIENT-594
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient
    Affects Versions: 3.0.1, 3.1 Alpha 1
            Reporter: Oleg Kalnichevski
         Assigned To: Oleg Kalnichevski
             Fix For: 3.1 Beta 1
         Attachments: httpmethodbase.patch

HttpMethodBase#abort variable mistakenly declared transient instead of volatile. This is quite nasty. 

Do we want to cut an emergency release (3.0.2) because of that or can this wait until 3.1-beta1?

Fix attached.

Oleg

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


[jira] Commented: (HTTPCLIENT-594) HttpMethodBase#aborted variable mistakenly declared transient instead of volatile

Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HTTPCLIENT-594?page=comments#action_12426307 ] 
            
Roland Weber commented on HTTPCLIENT-594:
-----------------------------------------

I'm with Odi. No need for an emergency release if nobody is experiencing problems.
I haven't used volatile since the times when I was programming in C and assembler,
and I don't remember having Java threading issues because of that.

Still, I'll keep it in mind and silently put some volatile declarations into HttpAsync :-)

cheers,
  Roland


> HttpMethodBase#aborted variable mistakenly declared transient instead of volatile
> ---------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-594
>                 URL: http://issues.apache.org/jira/browse/HTTPCLIENT-594
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1, 3.1 Alpha 1
>            Reporter: Oleg Kalnichevski
>         Assigned To: Oleg Kalnichevski
>             Fix For: 3.1 Beta 1
>
>         Attachments: httpmethodbase.patch
>
>
> HttpMethodBase#aborted variable mistakenly declared transient instead of volatile. This is quite nasty. 
> Do we want to cut an emergency release (3.0.2) because of that or can this wait until 3.1-beta1?
> Fix attached.
> Oleg

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


[jira] Commented: (HTTPCLIENT-594) HttpMethodBase#aborted variable mistakenly declared transient instead of volatile

Posted by "Ortwin Glück (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HTTPCLIENT-594?page=comments#action_12426198 ] 
            
Ortwin Glück commented on HTTPCLIENT-594:
-----------------------------------------

I would not make an emergency release unless we have a user that experiences a severe threading issue when calling abort(). If necessary we can always do that within ours.

> HttpMethodBase#aborted variable mistakenly declared transient instead of volatile
> ---------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-594
>                 URL: http://issues.apache.org/jira/browse/HTTPCLIENT-594
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1, 3.1 Alpha 1
>            Reporter: Oleg Kalnichevski
>         Assigned To: Oleg Kalnichevski
>             Fix For: 3.1 Beta 1
>
>         Attachments: httpmethodbase.patch
>
>
> HttpMethodBase#aborted variable mistakenly declared transient instead of volatile. This is quite nasty. 
> Do we want to cut an emergency release (3.0.2) because of that or can this wait until 3.1-beta1?
> Fix attached.
> Oleg

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


[jira] Resolved: (HTTPCLIENT-594) HttpMethodBase#aborted variable mistakenly declared transient instead of volatile

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HTTPCLIENT-594?page=all ]

Oleg Kalnichevski resolved HTTPCLIENT-594.
------------------------------------------

    Resolution: Fixed

Patch checked in

Oleg

> HttpMethodBase#aborted variable mistakenly declared transient instead of volatile
> ---------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-594
>                 URL: http://issues.apache.org/jira/browse/HTTPCLIENT-594
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1, 3.1 Alpha 1
>            Reporter: Oleg Kalnichevski
>         Assigned To: Oleg Kalnichevski
>             Fix For: 3.1 Beta 1
>
>         Attachments: httpmethodbase.patch
>
>
> HttpMethodBase#aborted variable mistakenly declared transient instead of volatile. This is quite nasty. 
> Do we want to cut an emergency release (3.0.2) because of that or can this wait until 3.1-beta1?
> Fix attached.
> Oleg

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


[jira] Updated: (HTTPCLIENT-594) HttpMethodBase#aborted variable mistakenly declared transient instead of volatile

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HTTPCLIENT-594?page=all ]

Oleg Kalnichevski updated HTTPCLIENT-594:
-----------------------------------------

        Summary: HttpMethodBase#aborted variable mistakenly declared transient instead of volatile  (was: HttpMethodBase#abort variable mistakenly declared transient instead of volatile)
    Description: 
HttpMethodBase#aborted variable mistakenly declared transient instead of volatile. This is quite nasty. 

Do we want to cut an emergency release (3.0.2) because of that or can this wait until 3.1-beta1?

Fix attached.

Oleg

  was:
HttpMethodBase#abort variable mistakenly declared transient instead of volatile. This is quite nasty. 

Do we want to cut an emergency release (3.0.2) because of that or can this wait until 3.1-beta1?

Fix attached.

Oleg


> HttpMethodBase#aborted variable mistakenly declared transient instead of volatile
> ---------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-594
>                 URL: http://issues.apache.org/jira/browse/HTTPCLIENT-594
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1, 3.1 Alpha 1
>            Reporter: Oleg Kalnichevski
>         Assigned To: Oleg Kalnichevski
>             Fix For: 3.1 Beta 1
>
>         Attachments: httpmethodbase.patch
>
>
> HttpMethodBase#aborted variable mistakenly declared transient instead of volatile. This is quite nasty. 
> Do we want to cut an emergency release (3.0.2) because of that or can this wait until 3.1-beta1?
> Fix attached.
> Oleg

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org