You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by ol...@apache.org on 2008/10/01 01:34:45 UTC
svn commit: r700632 - in /incubator/pig/branches/types: CHANGES.txt
src/org/apache/pig/builtin/MAX.java src/org/apache/pig/builtin/MIN.java
Author: olga
Date: Tue Sep 30 16:34:45 2008
New Revision: 700632
URL: http://svn.apache.org/viewvc?rev=700632&view=rev
Log:
PIG-54: MIN/MAX with invalid data
Modified:
incubator/pig/branches/types/CHANGES.txt
incubator/pig/branches/types/src/org/apache/pig/builtin/MAX.java
incubator/pig/branches/types/src/org/apache/pig/builtin/MIN.java
Modified: incubator/pig/branches/types/CHANGES.txt
URL: http://svn.apache.org/viewvc/incubator/pig/branches/types/CHANGES.txt?rev=700632&r1=700631&r2=700632&view=diff
==============================================================================
--- incubator/pig/branches/types/CHANGES.txt (original)
+++ incubator/pig/branches/types/CHANGES.txt Tue Sep 30 16:34:45 2008
@@ -263,3 +263,5 @@
PIG-427: casting input to UDFs
PIG-437: as in alias names causing problems (sms via olgan)
+
+ PIG-54: MIN/MAX don't deal with invalid data (pradeepk via olgan)
Modified: incubator/pig/branches/types/src/org/apache/pig/builtin/MAX.java
URL: http://svn.apache.org/viewvc/incubator/pig/branches/types/src/org/apache/pig/builtin/MAX.java?rev=700632&r1=700631&r2=700632&view=diff
==============================================================================
--- incubator/pig/branches/types/src/org/apache/pig/builtin/MAX.java (original)
+++ incubator/pig/branches/types/src/org/apache/pig/builtin/MAX.java Tue Sep 30 16:34:45 2008
@@ -108,6 +108,9 @@
if (d == null) continue;
sawNonNull = true;
curMax = java.lang.Math.max(curMax, d);
+ }catch(NumberFormatException nfe){
+ // do nothing - essentially treat this
+ // particular input as null
} catch (RuntimeException exp) {
ExecException newE = new ExecException("Error processing: " +
t.toString() + exp.getMessage());
Modified: incubator/pig/branches/types/src/org/apache/pig/builtin/MIN.java
URL: http://svn.apache.org/viewvc/incubator/pig/branches/types/src/org/apache/pig/builtin/MIN.java?rev=700632&r1=700631&r2=700632&view=diff
==============================================================================
--- incubator/pig/branches/types/src/org/apache/pig/builtin/MIN.java (original)
+++ incubator/pig/branches/types/src/org/apache/pig/builtin/MIN.java Tue Sep 30 16:34:45 2008
@@ -108,6 +108,9 @@
if (d == null) continue;
sawNonNull = true;
curMin = java.lang.Math.min(curMin, d);
+ }catch(NumberFormatException nfe){
+ // do nothing - essentially treat this
+ // particular input as null
} catch (RuntimeException exp) {
ExecException newE = new ExecException("Error processing: " +
t.toString() + exp.getMessage());