[jira] [Comment Edited] (KAFKA-1053) Kafka patch review tool

["Swapnil Ghike (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13767967#comment-13767967 ] 

Swapnil Ghike edited comment on KAFKA-1053 at 9/16/13 12:38 AM:
----------------------------------------------------------------

Hmm, tried setting up the tool according to the instruction for RHEL. Ran into this:
~/kafka/kafka$ python kafka-patch-review.py --help
Traceback (most recent call last):
  File "kafka-patch-review.py", line 3, in <module>
    import argparse
ImportError: No module named argparse

Does the easy_install think work only on Mac? (jira-python and RBTools are installed using easy_install)?

On the Mac, I got this:
~/kafka-local/kafka$ echo $JIRA_CMDLINE_HOME 
.
~/kafka-local/kafka$ python kafka-patch-review.py -b 0.8 -j KAFKA-1003 -db
Jira Home= .
git diff 0.8 > KAFKA-1003.patch
Creating diff against 0.8 and uploading patch to JIRA KAFKA-1003
Creating a new reviewboard
post-review --publish --tracking-branch 0.8 --target-groups=kafka --bugs-closed=KAFKA-1003 --summary "Patch for KAFKA-1003"
There don't seem to be any diffs!

rb url= 

If you take a look at KAFKA-1003, it has appended my diffs, it just did not crete a review board. I guess this is expected.

                
      was (Author: swapnilghike):
    Hmm, tried setting up the tool according to the instruction for RHEL. Ran into this:
~/kafka/kafka$ python kafka-patch-review.py --help
Traceback (most recent call last):
  File "kafka-patch-review.py", line 3, in <module>
    import argparse
ImportError: No module named argparse

Does the easy_install think work only on Mac? (jira-python and RBTools are installed using easy_install)?

On the Mac, I got this:
~/kafka-local/kafka$ echo $JIRA_CMDLINE_HOME 
.
~/kafka-local/kafka$ python kafka-patch-review.py -b 0.8 -j KAFKA-1003 -db
Jira Home= .
git diff 0.8 > KAFKA-1003.patch
Creating diff against 0.8 and uploading patch to JIRA KAFKA-1003
Creating a new reviewboard
post-review --publish --tracking-branch 0.8 --target-groups=kafka --bugs-closed=KAFKA-1003 --summary "Patch for KAFKA-1003"
There don't seem to be any diffs!

rb url= 

                  
> Kafka patch review tool
> -----------------------
>
>                 Key: KAFKA-1053
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1053
>             Project: Kafka
>          Issue Type: New Feature
>          Components: tools
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>         Attachments: KAFKA-1053-2013-09-15_09:40:04.patch, KAFKA-1053-followup2.patch, KAFKA-1053-followup.patch, KAFKA-1053-v1.patch, KAFKA-1053-v1.patch, KAFKA-1053-v1.patch, KAFKA-1053-v2.patch, KAFKA-1053-v3.patch
>
>
> Created a new patch review tool that will integrate JIRA and reviewboard - https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira