[GitHub] shazron opened a new pull request #329: CB-13112 - should not create a new file reference on each "cordova prepare"

[gi...@git.apache.org]

shazron opened a new pull request #329: CB-13112 - <resource-file> should not create a new file reference on each "cordova prepare"
URL: https://github.com/apache/cordova-ios/pull/329
 
 
   Added new ios-config-xml project fixture based off cordova-ios@4.4.0 template. The old one doesn't reflect current project structure.
   
   prepare.spec.js
       Added failing test for multiple adds of the same <resource-file> tag
       Fixed failing test in prepare.js
   
   pluginHandlers.spec.js
       Fix failing test due to new ios-config-xml project template in addPlugin
       Don't need to prefix 'Resources' and 'Plugins' to the files that are from those groups. The file reference 'sourceTree' relies on its parent group, in the new template structure.
   
   ### Platforms affected
   
   self
   
   ### What does this PR do?
   
   Fix multiple file references added for a <resource-file> tag. This creates "cordova build" failures.
   
   ### What testing has been done on this change?
   
   npm run unit-tests
   npm test
   
   ### Checklist
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [X] Added automated test coverage as appropriate for this change.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org