You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/04 19:01:39 UTC
[GitHub] [flink] realdengziqi opened a new pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
realdengziqi opened a new pull request #18982:
URL: https://github.com/apache/flink/pull/18982
Co-authored-by: Lin WanNi <li...@foxmail.com>
Co-authored-by: Guo YuanFang <16...@qq.com>
## What is the purpose of the change
The goal of this PR is to fix the bug that: the element couldn't be assigned to the correct window-start, if it's *timestamp - offset + windowSize < 0*.
This bug located at _org.apache.flink.streaming.api.windowing.windows.TimeWindow_ .
This problem will be triggered by the negative timestamp, and is caused by the calculation method of remainder in the JAVA compiler.
Specifically, when we try to calculate the window-start of an incoming element, if _timestamp - offset + windowSize < 0_, based on the current calculation formula for window-start, **the element will be right shifted to the next window, which has a start time larger than the timestamp of current element**, seems violated the assignment principle for elements on window.
This problem can be fixed by modifying the calculation formula inside the getWindowStartWithOffset() method as below:
```java
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
return timestamp
- (timestamp - offset) % windowSize
- (windowSize & (timestamp - offset) >> 63);
}
```
After this modify, for the element who has negative timestamp, we can still get the correct window-start. Like the below graph showing:
## Brief change log
- Fix getWindowStartWithOffset in *TimeWindow.java*
## Verifying this change
This change is already covered by existing tests, such as the tests in the flink-streaming-java [mvn clean verify]
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98216c66614336a98e00d764be862413994c063b Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258)
* 74f16ec4dc13e9571ce2d4f59b18f83a97182ac1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b4e1a56ff405d84036f5fa30e6dd768ef87e711 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1071387191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1072022907
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi removed a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi removed a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1071387191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1065235908
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1067722277
@godfreyhe Could you please help review and merge this code if it's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 98216c66614336a98e00d764be862413994c063b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi removed a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi removed a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1071387191
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f16ec4dc13e9571ce2d4f59b18f83a97182ac1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269)
* 4b4e1a56ff405d84036f5fa30e6dd768ef87e711 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r829790683
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/TimeWindow.java
##########
@@ -220,7 +220,13 @@ public TimeWindowSerializerSnapshot() {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ long remainder = (timestamp - offset) % windowSize;
Review comment:
Yes no worries this can also be done outside of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98216c66614336a98e00d764be862413994c063b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5bf80617fee372c23728e2c4ba4192198e34205e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931)
* a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r825644868
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/TimeWindowTest.java
##########
@@ -29,23 +29,41 @@
public class TimeWindowTest {
@Test
public void testGetWindowStartWithOffset() {
- // [0, 7), [7, 14), [14, 21)...
+ // [-21, 14), [-14, -7), [-7, 0), [0, 7), [7, 14), [14, 21)...
long offset = 0;
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-8, offset, 7), -14);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-7, offset, 7), -7);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-6, offset, 7), -7);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-1, offset, 7), -7);
+ // ---
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r824368943
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/TimeWindow.java
##########
@@ -220,7 +220,9 @@ public TimeWindowSerializerSnapshot() {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ return timestamp
+ - (timestamp - offset) % windowSize
+ - (windowSize & (timestamp - offset) >> 63);
Review comment:
`(windowSize & (timestamp - offset) >> 63` hard to understand, better to add more comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552)
* cabfe09bfb90f080a3cf048559e5e064f3842c94 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998)
* 1a69a086de263767964103a46c653795ea5334e7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi removed a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi removed a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1067722277
@godfreyhe Could you please help review and merge this code if it's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998)
* 1a69a086de263767964103a46c653795ea5334e7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a69a086de263767964103a46c653795ea5334e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249)
* 98216c66614336a98e00d764be862413994c063b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r829203216
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/TimeWindow.java
##########
@@ -262,6 +262,12 @@ public int compare(TimeWindow o1, TimeWindow o2) {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ long remainder = (timestamp - offset) % windowSize;
Review comment:
It has been modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 98216c66614336a98e00d764be862413994c063b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f16ec4dc13e9571ce2d4f59b18f83a97182ac1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cabfe09bfb90f080a3cf048559e5e064f3842c94 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi removed a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi removed a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1065235908
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5bf80617fee372c23728e2c4ba4192198e34205e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r829204910
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/TimeWindowTest.java
##########
@@ -29,23 +29,38 @@
public class TimeWindowTest {
@Test
public void testGetWindowStartWithOffset() {
- // [0, 7), [7, 14), [14, 21)...
+ // [-21, 14), [-14, -7), [-7, 0), [0, 7), [7, 14), [14, 21)...
Review comment:
Thanks, it was an oversight, we've fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "1072022907",
"triggerType" : "MANUAL"
}, {
"hash" : "484a65676cccfd48dde7e3fc12536d83b6ebdc8b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33348",
"triggerID" : "484a65676cccfd48dde7e3fc12536d83b6ebdc8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b4e1a56ff405d84036f5fa30e6dd768ef87e711 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270)
* 484a65676cccfd48dde7e3fc12536d83b6ebdc8b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33348)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
fapaul merged pull request #18982:
URL: https://github.com/apache/flink/pull/18982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1071387191
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "3559fb4e2b11c68662815d21c268050e9fedcafe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3559fb4e2b11c68662815d21c268050e9fedcafe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f16ec4dc13e9571ce2d4f59b18f83a97182ac1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269)
* 3559fb4e2b11c68662815d21c268050e9fedcafe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552)
* cabfe09bfb90f080a3cf048559e5e064f3842c94 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "1072022907",
"triggerType" : "MANUAL"
}, {
"hash" : "484a65676cccfd48dde7e3fc12536d83b6ebdc8b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "484a65676cccfd48dde7e3fc12536d83b6ebdc8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b4e1a56ff405d84036f5fa30e6dd768ef87e711 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270)
* 484a65676cccfd48dde7e3fc12536d83b6ebdc8b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1072180893
@realdengziqi it would be good to resolve the conflicts first and rebase with the latest master branch. In the Flink community we always use rebase over merge. Can you also create backport PRs for the release-1.14 and release-1.15 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r826159462
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/TimeWindowTest.java
##########
@@ -29,23 +29,41 @@
public class TimeWindowTest {
@Test
public void testGetWindowStartWithOffset() {
- // [0, 7), [7, 14), [14, 21)...
+ // [-21, 14), [-14, -7), [-7, 0), [0, 7), [7, 14), [14, 21)...
long offset = 0;
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-8, offset, 7), -14);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-7, offset, 7), -7);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-6, offset, 7), -7);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-1, offset, 7), -7);
+ // ---
Review comment:
Thanks, we have removed this line of comments in the new commit [https://github.com/apache/flink/commit/a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af](https://github.com/apache/flink/commit/a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1072939994
@fapaul Thanks for the guidance, we rebased it to the latest master branch of the community and force pushed it recently. We also created backport PRs for the release1.14 branch and the release1.15 branch. And, these PRs have successfully passed the azure build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98216c66614336a98e00d764be862413994c063b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258)
* 74f16ec4dc13e9571ce2d4f59b18f83a97182ac1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi removed a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi removed a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1065390926
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "3559fb4e2b11c68662815d21c268050e9fedcafe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3559fb4e2b11c68662815d21c268050e9fedcafe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f16ec4dc13e9571ce2d4f59b18f83a97182ac1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269)
* 3559fb4e2b11c68662815d21c268050e9fedcafe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5bf80617fee372c23728e2c4ba4192198e34205e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5bf80617fee372c23728e2c4ba4192198e34205e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1065390926
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1065140341
@zjuwangg
Thanks for the review, again! We checked the unit-test module, which located at `org.apache.flink.streaming.runtime.operators.windowing.TimeWindowTest`. Turns out it hasn't cover the test for negative timestamp cases. So we add additional test cases by simply negative the original positive-values only test cases.
During the unit test, we found out that our calculation will make the window exclude the start time, which violated the window assignment principle unfortunately. So, considered the readability and correctness, we borrowed the calculation method inside the `org.apache.flink.table.runtime.operators.window.grouping.WindowsGrouping` method eventually in our code.
**Considered the code-reference mentioned above, looking forward to have a further discussions with you**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjuwangg commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r825645024
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/TimeWindowTest.java
##########
@@ -29,23 +29,41 @@
public class TimeWindowTest {
@Test
public void testGetWindowStartWithOffset() {
- // [0, 7), [7, 14), [14, 21)...
+ // [-21, 14), [-14, -7), [-7, 0), [0, 7), [7, 14), [14, 21)...
long offset = 0;
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-8, offset, 7), -14);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-7, offset, 7), -7);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-6, offset, 7), -7);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-1, offset, 7), -7);
+ // ---
Assert.assertEquals(TimeWindow.getWindowStartWithOffset(1, offset, 7), 0);
Assert.assertEquals(TimeWindow.getWindowStartWithOffset(6, offset, 7), 0);
Assert.assertEquals(TimeWindow.getWindowStartWithOffset(7, offset, 7), 7);
Assert.assertEquals(TimeWindow.getWindowStartWithOffset(8, offset, 7), 7);
- // [-4, 3), [3, 10), [10, 17)...
+ // [-11, -4), [-4, 3), [3, 10), [10, 17)...
offset = 3;
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-10, offset, 7), -11);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-9, offset, 7), -11);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-3, offset, 7), -4);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-2, offset, 7), -4);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-1, offset, 7), -4);
+ // ---
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r829229125
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/TimeWindow.java
##########
@@ -220,7 +220,13 @@ public TimeWindowSerializerSnapshot() {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ long remainder = (timestamp - offset) % windowSize;
Review comment:
Thanks for reviewing this code. I guess it involves reorganizing the code, which maybe too much for this pr. If necessary, we are willing to start a new jira and pr to deal with this problem. And looking forward the next pleasure cooperation with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "1072022907",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4b4e1a56ff405d84036f5fa30e6dd768ef87e711 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "1072022907",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4b4e1a56ff405d84036f5fa30e6dd768ef87e711 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1072180893
@realdengziqi it would be good to resolve the conflicts first and rebase with the latest master branch. In the Flink community we always use rebase over merge. Can you also create backport PRs for the release-1.14 and release-1.15 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "1072022907",
"triggerType" : "MANUAL"
}, {
"hash" : "484a65676cccfd48dde7e3fc12536d83b6ebdc8b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33348",
"triggerID" : "484a65676cccfd48dde7e3fc12536d83b6ebdc8b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 484a65676cccfd48dde7e3fc12536d83b6ebdc8b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33348)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a69a086de263767964103a46c653795ea5334e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1070545096
@fapaul Hi. will u help have a look and merge ir if it's ok? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 5bf80617fee372c23728e2c4ba4192198e34205e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r826160887
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/TimeWindowTest.java
##########
@@ -29,23 +29,41 @@
public class TimeWindowTest {
@Test
public void testGetWindowStartWithOffset() {
- // [0, 7), [7, 14), [14, 21)...
+ // [-21, 14), [-14, -7), [-7, 0), [0, 7), [7, 14), [14, 21)...
long offset = 0;
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-8, offset, 7), -14);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-7, offset, 7), -7);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-6, offset, 7), -7);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-1, offset, 7), -7);
+ // ---
Assert.assertEquals(TimeWindow.getWindowStartWithOffset(1, offset, 7), 0);
Assert.assertEquals(TimeWindow.getWindowStartWithOffset(6, offset, 7), 0);
Assert.assertEquals(TimeWindow.getWindowStartWithOffset(7, offset, 7), 7);
Assert.assertEquals(TimeWindow.getWindowStartWithOffset(8, offset, 7), 7);
- // [-4, 3), [3, 10), [10, 17)...
+ // [-11, -4), [-4, 3), [3, 10), [10, 17)...
offset = 3;
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-10, offset, 7), -11);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-9, offset, 7), -11);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-3, offset, 7), -4);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-2, offset, 7), -4);
+ Assert.assertEquals(TimeWindow.getWindowStartWithOffset(-1, offset, 7), -4);
+ // ---
Review comment:
Thanks, this line was also removed in the new commit [https://github.com/apache/flink/commit/a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af](https://github.com/apache/flink/commit/a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1067051662
@zjuwangg Thanks, we addressed this issue in the original jira, and made changes to `getWindowStartWithOffset` in `org.apache.flink.table.runtime.operators.window.TimeWindow` in a new commit https://github.com/apache/flink/commit/a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af. Looking forward to more discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 5bf80617fee372c23728e2c4ba4192198e34205e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "3559fb4e2b11c68662815d21c268050e9fedcafe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3559fb4e2b11c68662815d21c268050e9fedcafe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 98216c66614336a98e00d764be862413994c063b Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258)
* 74f16ec4dc13e9571ce2d4f59b18f83a97182ac1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269)
* 3559fb4e2b11c68662815d21c268050e9fedcafe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r829061834
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/TimeWindowTest.java
##########
@@ -29,23 +29,38 @@
public class TimeWindowTest {
@Test
public void testGetWindowStartWithOffset() {
- // [0, 7), [7, 14), [14, 21)...
+ // [-21, 14), [-14, -7), [-7, 0), [0, 7), [7, 14), [14, 21)...
Review comment:
```suggestion
// [-21, -14), [-14, -7), [-7, 0), [0, 7), [7, 14), [14, 21)...
```
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/TimeWindow.java
##########
@@ -220,7 +220,13 @@ public TimeWindowSerializerSnapshot() {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ long remainder = (timestamp - offset) % windowSize;
Review comment:
I know you haven't introduced this method but what do you think about removing this method in favor of the other `TimeWindow#getWindowStartWithOffset`. I am afraid that it is easy to miss that we have the same method twice in the code base.
I am also fine to do this as followup if you think it is too much for this PR.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/TimeWindow.java
##########
@@ -262,6 +262,12 @@ public int compare(TimeWindow o1, TimeWindow o2) {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ long remainder = (timestamp - offset) % windowSize;
Review comment:
Nit:
```suggestion
final long remainder = (timestamp - offset) % windowSize;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5bf80617fee372c23728e2c4ba4192198e34205e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931)
* a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 5bf80617fee372c23728e2c4ba4192198e34205e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1067689211
@zjuwangg Unfortunately this is not my expertise, so I can't review and merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r824733805
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/TimeWindow.java
##########
@@ -220,7 +220,9 @@ public TimeWindowSerializerSnapshot() {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ return timestamp
+ - (timestamp - offset) % windowSize
+ - (windowSize & (timestamp - offset) >> 63);
Review comment:
Thanks for reviewing our code, we made a mistake. What we want to change is `org.apache.flink.streaming.api.windowing.windows.TimeWindow`, not `org.apache.flink.table.runtime.operators.window.TimeWindow`
In the new commit, we find the class we want to change and modify the unit test.
Please ignore this change.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi removed a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi removed a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1072022907
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] realdengziqi commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
realdengziqi commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r829203216
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/TimeWindow.java
##########
@@ -262,6 +262,12 @@ public int compare(TimeWindow o1, TimeWindow o2) {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ long remainder = (timestamp - offset) % windowSize;
Review comment:
It has been modified
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/TimeWindowTest.java
##########
@@ -29,23 +29,38 @@
public class TimeWindowTest {
@Test
public void testGetWindowStartWithOffset() {
- // [0, 7), [7, 14), [14, 21)...
+ // [-21, 14), [-14, -7), [-7, 0), [0, 7), [7, 14), [14, 21)...
Review comment:
Thanks, it was an oversight, we've fixed it
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/TimeWindow.java
##########
@@ -220,7 +220,13 @@ public TimeWindowSerializerSnapshot() {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ long remainder = (timestamp - offset) % windowSize;
Review comment:
Thanks for reviewing this code. I guess it involves reorganizing the code, which maybe too much for this pr. If necessary, we are willing to start a new jira and pr to deal with this problem. And looking forward the next pleasure cooperation with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a69a086de263767964103a46c653795ea5334e7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249)
* 98216c66614336a98e00d764be862413994c063b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f16ec4dc13e9571ce2d4f59b18f83a97182ac1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269)
* 4b4e1a56ff405d84036f5fa30e6dd768ef87e711 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74f16ec4dc13e9571ce2d4f59b18f83a97182ac1 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #18982:
URL: https://github.com/apache/flink/pull/18982#discussion_r829061834
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/TimeWindowTest.java
##########
@@ -29,23 +29,38 @@
public class TimeWindowTest {
@Test
public void testGetWindowStartWithOffset() {
- // [0, 7), [7, 14), [14, 21)...
+ // [-21, 14), [-14, -7), [-7, 0), [0, 7), [7, 14), [14, 21)...
Review comment:
```suggestion
// [-21, -14), [-14, -7), [-7, 0), [0, 7), [7, 14), [14, 21)...
```
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/TimeWindow.java
##########
@@ -220,7 +220,13 @@ public TimeWindowSerializerSnapshot() {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ long remainder = (timestamp - offset) % windowSize;
Review comment:
I know you haven't introduced this method but what do you think about removing this method in favor of the other `TimeWindow#getWindowStartWithOffset`. I am afraid that it is easy to miss that we have the same method twice in the code base.
I am also fine to do this as followup if you think it is too much for this PR.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/TimeWindow.java
##########
@@ -262,6 +262,12 @@ public int compare(TimeWindow o1, TimeWindow o2) {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ long remainder = (timestamp - offset) % windowSize;
Review comment:
Nit:
```suggestion
final long remainder = (timestamp - offset) % windowSize;
```
##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/TimeWindow.java
##########
@@ -220,7 +220,13 @@ public TimeWindowSerializerSnapshot() {
* @return window start
*/
public static long getWindowStartWithOffset(long timestamp, long offset, long windowSize) {
- return timestamp - (timestamp - offset + windowSize) % windowSize;
+ long remainder = (timestamp - offset) % windowSize;
Review comment:
Yes no worries this can also be done outside of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18982: [FLINK-26334][datastream] Fix getWindowStartWithOffset in TimeWindow.java
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18982:
URL: https://github.com/apache/flink/pull/18982#issuecomment-1059437393
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32552",
"triggerID" : "dbb6ce5f77546baf2368fc2f23a30d956aa8b3a0",
"triggerType" : "PUSH"
}, {
"hash" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32921",
"triggerID" : "cabfe09bfb90f080a3cf048559e5e064f3842c94",
"triggerType" : "PUSH"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1065235908",
"triggerType" : "MANUAL"
}, {
"hash" : "5bf80617fee372c23728e2c4ba4192198e34205e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32931",
"triggerID" : "1065390926",
"triggerType" : "MANUAL"
}, {
"hash" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32998",
"triggerID" : "a2fd873779a8bcddfb0dcc8fe4809ca9e2b1e6af",
"triggerType" : "PUSH"
}, {
"hash" : "1a69a086de263767964103a46c653795ea5334e7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33249",
"triggerID" : "1a69a086de263767964103a46c653795ea5334e7",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "98216c66614336a98e00d764be862413994c063b",
"triggerType" : "PUSH"
}, {
"hash" : "98216c66614336a98e00d764be862413994c063b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33258",
"triggerID" : "1071387191",
"triggerType" : "MANUAL"
}, {
"hash" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33269",
"triggerID" : "74f16ec4dc13e9571ce2d4f59b18f83a97182ac1",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"triggerType" : "PUSH"
}, {
"hash" : "4b4e1a56ff405d84036f5fa30e6dd768ef87e711",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270",
"triggerID" : "1072022907",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4b4e1a56ff405d84036f5fa30e6dd768ef87e711 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33270)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org