You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/07/24 10:27:50 UTC

[GitHub] [echarts] 100pah opened a new issue #15409: dataZoom type inside bring unnecessary slow rendering in large data.

100pah opened a new issue #15409:
URL: https://github.com/apache/echarts/issues/15409


   ### Version
   5.1.2
   
   ### Steps to reproduce
   ```js
               const POINT_COUNT = 1e7;
               const dzStart = 10;
               const dzEnd = 60;
   
               var option = {
                   tooltip: {
                       trigger: 'axis',
                       axisPointer: {
                       animation: false
                       }
                   },
                   legend: {},
                   dataZoom: [{
                       show: true,
                       realtime: true,
                       // showDataShadow: false,
                       start: dzStart,
                       end: dzEnd
                   }, {
                       type: 'inside',
                       start: dzStart,
                       end: dzEnd,
                   }],
                   xAxis: [{
                       type: 'time'
                   }],
                   yAxis: [{
                       type: 'value'
                   }],
                   series: [],
                   animation: false
               };
   
               var lineStyle = {
                   normal: {
                       width: 2,
                       opacity: 1
                   }
               };
   
               var oneDay = 24 * 3600 * 1000;
               var base = +new Date(1987, 9, 3);
               var y = Math.random() * 1000;
               var values = new Float64Array(POINT_COUNT * 2);
               var off = 0;
               for (var j = 0; j < POINT_COUNT; j++) {
                   y += Math.round(10 + Math.random() * (-10 - 10));
                   values[off++] = base += oneDay;
                   values[off++] = y;
               }
   
               option.series.push({
                   name: 'line',
                   type: 'line',
                   hoverAnimation: false,
                   showSymbol: false,
                   sampling: 'lttb',
                   dimensions: ['date', 'value'],
                   encode: {
                       x: 'date',
                       y: 'value'
                   },
                   data: values,
                   lineStyle: lineStyle
               });
   ```
   
   Drag dataZoom slider bar, the rendering time is OK.
   But pan on cartesian (that is, using `dataZoom 'inside'`), there is slow rendering, mainly caused on re-render of shadow in dataZoom slider (show in picture below, 289ms), which is unnecessary because it never changed.
   
   <img width="762" alt="Screen Shot 2021-07-24 at 6 20 11 PM" src="https://user-images.githubusercontent.com/1956569/126865649-ea0b053d-119c-4c4c-abeb-b679a925bf51.png">
   
   
   ### What is expected?
   
   The performance of `dataZoom 'inside'` should the same as `dataZoom 'slider'`.
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang closed issue #15409: dataZoom type inside bring unnecessary slow rendering in large data.

Posted by GitBox <gi...@apache.org>.
pissang closed issue #15409:
URL: https://github.com/apache/echarts/issues/15409


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] aahung commented on issue #15409: dataZoom type inside bring unnecessary slow rendering in large data.

Posted by GitBox <gi...@apache.org>.
aahung commented on issue #15409:
URL: https://github.com/apache/echarts/issues/15409#issuecomment-919721569


   I am happy to be reached out if more info is needed when you start to investigate this issue. The zooming and panning are pretty laggy when more than ~1000 points in the window. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on issue #15409: dataZoom type inside bring unnecessary slow rendering in large data.

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #15409:
URL: https://github.com/apache/echarts/issues/15409#issuecomment-919719414


   I'm not sure but it seems because slider zoom have throttle but inside zoom doesn't
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] aahung commented on issue #15409: dataZoom type inside bring unnecessary slow rendering in large data.

Posted by GitBox <gi...@apache.org>.
aahung commented on issue #15409:
URL: https://github.com/apache/echarts/issues/15409#issuecomment-919711498


   I also experience more performance hit when zooming using "inside" compared to "slider." 
   
   The `getShallow` took significant amount of time:
   
   <img width="980" alt="image" src="https://user-images.githubusercontent.com/3804518/133375745-ad497dad-16f1-460e-92cc-58a3807b1e6b.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org