[GitHub] mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage

[GitBox <gi...@apache.org>]

mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355140092
 
 
   Hi @rhtyd Sorry for the delay in responding. I believe I have addressed all of your points except one (which I wanted to run past you before making any changes here).
   
   The one remaining issue is with where to place the SIOC code.
   
   SIOC is short for VMware Storage I/O Control.
   
   Initially I placed it under plugins/api/solidfire-sioc because 1) I wanted it to extend the standard CloudStack API and I thought all API plug-ins needed to be placed in this location and 2) originally there was SolidFire-specific code in here (hence the naming of some folders).
   
   As it turns out, in working with the customer for whom I originally developed this code (the SIOC code, that is), I was able to extract all SolidFire-specific references.
   
   How's about this? If I go ahead and remove references to SolidFire from this SIOC code (ex. folder naming, file naming, etc.), would you be OK with me placing it here: plugins/api/sioc?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services