You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2008/07/30 13:49:31 UTC
[jira] Created: (QPID-1204) SimpleACLTest is not accurate enough
SimpleACLTest is not accurate enough
------------------------------------
Key: QPID-1204
URL: https://issues.apache.org/jira/browse/QPID-1204
Project: Qpid
Issue Type: Bug
Components: Java Broker, Java Client, Java Tests
Affects Versions: M3
Reporter: Martin Ritchie
Summary:
The SimpleACLTest is not comprehensive enough. e.g.
testServerPublishInvalidQueueSuccess
Is designed to test that the user 'server' cannot publish to an invalid queue. It doesn't test this!
Due to the fact that send now validates the destination before publication this test is actually checking to see if the user 'server' can declare an exchange.
Protocol logging in comments.
Suggested Change:
Our Exceptions from the broker should contain more detail about the cause of the error .. 'Access Denied to Exchange' for example so this test can check for 'Acecess Denied to Publish'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1204) SimpleACLTest is not accurate enough
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-1204:
---------------------------------
Fix Version/s: 0.6
> SimpleACLTest is not accurate enough
> ------------------------------------
>
> Key: QPID-1204
> URL: https://issues.apache.org/jira/browse/QPID-1204
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Assignee: Robbie Gemmell
> Fix For: 0.6
>
>
> Summary:
> The SimpleACLTest is not comprehensive enough. e.g.
> testServerPublishInvalidQueueSuccess
> Is designed to test that the user 'server' cannot publish to an invalid queue. It doesn't test this!
> Due to the fact that send now validates the destination before publication this test is actually checking to see if the user 'server' can declare an exchange.
> Protocol logging in comments.
> Suggested Change:
> Our Exceptions from the broker should contain more detail about the cause of the error .. 'Access Denied to Exchange' for example so this test can check for 'Acecess Denied to Publish'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1204) SimpleACLTest is not accurate enough
Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marnie McCormack updated QPID-1204:
-----------------------------------
Fix Version/s: (was: M4)
Descoping items not being worked on for M4 into Unknown Fix Version for now
> SimpleACLTest is not accurate enough
> ------------------------------------
>
> Key: QPID-1204
> URL: https://issues.apache.org/jira/browse/QPID-1204
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
>
> Summary:
> The SimpleACLTest is not comprehensive enough. e.g.
> testServerPublishInvalidQueueSuccess
> Is designed to test that the user 'server' cannot publish to an invalid queue. It doesn't test this!
> Due to the fact that send now validates the destination before publication this test is actually checking to see if the user 'server' can declare an exchange.
> Protocol logging in comments.
> Suggested Change:
> Our Exceptions from the broker should contain more detail about the cause of the error .. 'Access Denied to Exchange' for example so this test can check for 'Acecess Denied to Publish'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1204) SimpleACLTest is not accurate enough
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12698045#action_12698045 ]
Martin Ritchie commented on QPID-1204:
--------------------------------------
It is possible that this test can fail because the test relys on an operation on a failed connection to return the AuthenticationException. However, it is possible that the session /StateManager becomes closed and so the subsequent operation receives an IllegalStateException instead.
> SimpleACLTest is not accurate enough
> ------------------------------------
>
> Key: QPID-1204
> URL: https://issues.apache.org/jira/browse/QPID-1204
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> Summary:
> The SimpleACLTest is not comprehensive enough. e.g.
> testServerPublishInvalidQueueSuccess
> Is designed to test that the user 'server' cannot publish to an invalid queue. It doesn't test this!
> Due to the fact that send now validates the destination before publication this test is actually checking to see if the user 'server' can declare an exchange.
> Protocol logging in comments.
> Suggested Change:
> Our Exceptions from the broker should contain more detail about the cause of the error .. 'Access Denied to Exchange' for example so this test can check for 'Acecess Denied to Publish'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1204) SimpleACLTest is not accurate enough
Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marnie McCormack updated QPID-1204:
-----------------------------------
Fix Version/s: M5
Assignee: Martin Ritchie
> SimpleACLTest is not accurate enough
> ------------------------------------
>
> Key: QPID-1204
> URL: https://issues.apache.org/jira/browse/QPID-1204
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: M5
>
>
> Summary:
> The SimpleACLTest is not comprehensive enough. e.g.
> testServerPublishInvalidQueueSuccess
> Is designed to test that the user 'server' cannot publish to an invalid queue. It doesn't test this!
> Due to the fact that send now validates the destination before publication this test is actually checking to see if the user 'server' can declare an exchange.
> Protocol logging in comments.
> Suggested Change:
> Our Exceptions from the broker should contain more detail about the cause of the error .. 'Access Denied to Exchange' for example so this test can check for 'Acecess Denied to Publish'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1204) SimpleACLTest is not accurate enough
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-1204:
------------------------------------
Assignee: Robbie Gemmell (was: Martin Ritchie)
> SimpleACLTest is not accurate enough
> ------------------------------------
>
> Key: QPID-1204
> URL: https://issues.apache.org/jira/browse/QPID-1204
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Assignee: Robbie Gemmell
> Fix For: 0.6
>
>
> Summary:
> The SimpleACLTest is not comprehensive enough. e.g.
> testServerPublishInvalidQueueSuccess
> Is designed to test that the user 'server' cannot publish to an invalid queue. It doesn't test this!
> Due to the fact that send now validates the destination before publication this test is actually checking to see if the user 'server' can declare an exchange.
> Protocol logging in comments.
> Suggested Change:
> Our Exceptions from the broker should contain more detail about the cause of the error .. 'Access Denied to Exchange' for example so this test can check for 'Acecess Denied to Publish'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-1204) SimpleACLTest is not accurate enough
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1204:
---------------------------------
Fix Version/s: (was: M5)
> SimpleACLTest is not accurate enough
> ------------------------------------
>
> Key: QPID-1204
> URL: https://issues.apache.org/jira/browse/QPID-1204
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> Summary:
> The SimpleACLTest is not comprehensive enough. e.g.
> testServerPublishInvalidQueueSuccess
> Is designed to test that the user 'server' cannot publish to an invalid queue. It doesn't test this!
> Due to the fact that send now validates the destination before publication this test is actually checking to see if the user 'server' can declare an exchange.
> Protocol logging in comments.
> Suggested Change:
> Our Exceptions from the broker should contain more detail about the cause of the error .. 'Access Denied to Exchange' for example so this test can check for 'Acecess Denied to Publish'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1204) SimpleACLTest is not accurate enough
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618300#action_12618300 ]
Martin Ritchie commented on QPID-1204:
--------------------------------------
pool-2-thread-4 2008-07-30 12:24:57,732 INFO [qpid.protocol] SEND: [org.apache.qpid.client.protocol.AMQProtocolHandler@1786286] Frame channelId: 0, bodyFrame: [ConnectionSecureOkBodyImpl: response=[B@e4bb3c]
pool-2-thread-4 2008-07-30 12:24:57,733 INFO [qpid.protocol] RECV: [org.apache.qpid.client.protocol.AMQProtocolHandler@1786286] Frame channelId: 0, bodyFrame: [ConnectionTuneBodyImpl: channelMax=65535, frameMax=65535, heartbeat=0]
pool-2-thread-4 2008-07-30 12:24:57,735 INFO [qpid.protocol] SEND: [org.apache.qpid.client.protocol.AMQProtocolHandler@1786286] Frame channelId: 0, bodyFrame: [ConnectionTuneOkBodyImpl: channelMax=65535, frameMax=65535, heartbeat=0]
pool-2-thread-4 2008-07-30 12:24:57,747 INFO [qpid.protocol] SEND: [org.apache.qpid.client.protocol.AMQProtocolHandler@1786286] Frame channelId: 0, bodyFrame: [ConnectionOpenBodyImpl: virtualHost=/test, capabilities=null, insist=true]
pool-2-thread-4 2008-07-30 12:24:57,747 INFO [qpid.protocol] RECV: [org.apache.qpid.client.protocol.AMQProtocolHandler@1786286] Frame channelId: 0, bodyFrame: [ConnectionOpenOkBodyImpl: knownHosts=/test]
pool-2-thread-3 2008-07-30 12:24:57,797 INFO [qpid.protocol] RECV: [org.apache.qpid.client.protocol.AMQProtocolHandler@1786286] Frame channelId: 1, bodyFrame: [ChannelOpenOkBodyImpl: channelId=[B@c0a9f9]
main 2008-07-30 12:24:57,798 INFO [qpid.protocol] SEND: [org.apache.qpid.client.protocol.AMQProtocolHandler@1786286] Frame channelId: 1, bodyFrame: [ChannelOpenBodyImpl: outOfBand=null]
pool-2-thread-1 2008-07-30 12:24:57,800 INFO [qpid.protocol] RECV: [org.apache.qpid.client.protocol.AMQProtocolHandler@1786286] Frame channelId: 1, bodyFrame: [BasicQosOkBodyImpl: ]
main 2008-07-30 12:24:57,800 INFO [qpid.protocol] SEND: [org.apache.qpid.client.protocol.AMQProtocolHandler@1786286] Frame channelId: 1, bodyFrame: [BasicQosBodyImpl: prefetchSize=0, prefetchCount=5000, global=false]
main 2008-07-30 12:24:57,820 INFO [qpid.protocol] SEND: [org.apache.qpid.client.protocol.AMQProtocolHandler@1786286] Frame channelId: 1, bodyFrame: [ExchangeDeclareBodyImpl: ticket=0, exchange=amq.direct, type=direct, passive=false, durable=false, autoDelete=false, internal=false, nowait=true, arguments=null]
pool-2-thread-1 2008-07-30 12:24:57,827 INFO [qpid.protocol] RECV: [org.apache.qpid.client.protocol.AMQProtocolHandler@1786286] Frame channelId: 1, bodyFrame: [ConnectionCloseBodyImpl: replyCode=403, replyText= [error code 403: access refused], classId=60, methodId=40]
pool-2-thread-1 2008-07-30 12:24:57,828 ERROR [qpid.client.state.AMQStateManager] No Waiters for error saving as last error: [error code 403: access refused] [error code 403: access refused]
Failover 2008-07-30 12:24:57,830 ERROR [apache.qpid.client.AMQConnection] Throwable Received but no listener set: Failover was vetoed by client
> SimpleACLTest is not accurate enough
> ------------------------------------
>
> Key: QPID-1204
> URL: https://issues.apache.org/jira/browse/QPID-1204
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
>
> Summary:
> The SimpleACLTest is not comprehensive enough. e.g.
> testServerPublishInvalidQueueSuccess
> Is designed to test that the user 'server' cannot publish to an invalid queue. It doesn't test this!
> Due to the fact that send now validates the destination before publication this test is actually checking to see if the user 'server' can declare an exchange.
> Protocol logging in comments.
> Suggested Change:
> Our Exceptions from the broker should contain more detail about the cause of the error .. 'Access Denied to Exchange' for example so this test can check for 'Acecess Denied to Publish'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1204) SimpleACLTest is not accurate enough
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-1204.
----------------------------------
Resolution: Invalid
As previously noted, the test mentioned is behaving as expected and no change relating to this was necessary.
> SimpleACLTest is not accurate enough
> ------------------------------------
>
> Key: QPID-1204
> URL: https://issues.apache.org/jira/browse/QPID-1204
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Assignee: Robbie Gemmell
> Fix For: 0.6
>
>
> Summary:
> The SimpleACLTest is not comprehensive enough. e.g.
> testServerPublishInvalidQueueSuccess
> Is designed to test that the user 'server' cannot publish to an invalid queue. It doesn't test this!
> Due to the fact that send now validates the destination before publication this test is actually checking to see if the user 'server' can declare an exchange.
> Protocol logging in comments.
> Suggested Change:
> Our Exceptions from the broker should contain more detail about the cause of the error .. 'Access Denied to Exchange' for example so this test can check for 'Acecess Denied to Publish'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-1204) SimpleACLTest is not accurate enough
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763545#action_12763545 ]
Robbie Gemmell commented on QPID-1204:
--------------------------------------
Investigation of the issue determined that due to the manner in which the ACL is processed ( QPID-2133 ), and the ACL configuration in use, the testServerPublishInvalidQueueSuccess method currently is testing what it was inteded to, as the user in question has been granted create permission to declare the exchange it is attempting to use and so is able to reach the point of publication, which is successfully denied.
> SimpleACLTest is not accurate enough
> ------------------------------------
>
> Key: QPID-1204
> URL: https://issues.apache.org/jira/browse/QPID-1204
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client, Java Tests
> Affects Versions: M3
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
>
> Summary:
> The SimpleACLTest is not comprehensive enough. e.g.
> testServerPublishInvalidQueueSuccess
> Is designed to test that the user 'server' cannot publish to an invalid queue. It doesn't test this!
> Due to the fact that send now validates the destination before publication this test is actually checking to see if the user 'server' can declare an exchange.
> Protocol logging in comments.
> Suggested Change:
> Our Exceptions from the broker should contain more detail about the cause of the error .. 'Access Denied to Exchange' for example so this test can check for 'Acecess Denied to Publish'
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org