You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2014/10/29 13:14:36 UTC

[Bug 57164] New: XSSFDrawing.createCellComment() does not honor dx and dy values passed in

https://issues.apache.org/bugzilla/show_bug.cgi?id=57164

            Bug ID: 57164
           Summary: XSSFDrawing.createCellComment() does not honor dx and
                    dy values passed in
           Product: POI
           Version: 3.11-dev
          Hardware: PC
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: XSSF
          Assignee: dev@poi.apache.org
          Reporter: toni97@gmx.de

Created attachment 32164
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=32164&action=edit
suggested patch

XSSFDrawing.createCellComment() takes a ClientAnchor as an argument to control
positioning of the created comment. While it positions the comment at the given
cells it completely ignores any dx and dy values defined in the anchor and sets
those to 0 on the resulting VML-drawing.

See my attached patch for how I think it should work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 57164] [PATCH] XSSFDrawing.createCellComment() does not honor dx and dy values passed in

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57164

Nick Burch <ap...@gagravarr.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
            Summary|XSSFDrawing.createCellComme |[PATCH]
                   |nt() does not honor dx and  |XSSFDrawing.createCellComme
                   |dy values passed in         |nt() does not honor dx and
                   |                            |dy values passed in

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 57164] XSSFDrawing.createCellComment() does not honor dx and dy values passed in

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57164

toni97@gmx.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |toni97@gmx.de
                 OS|                            |All

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 57164] [PATCH] XSSFDrawing.createCellComment() does not honor dx and dy values passed in

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57164

Andreas Beeker <an...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Andreas Beeker <an...@gmx.de> ---
Thank you for the patch.
Applied with r1639996
I've changed that patch, so that the dx/dy values are specified as EMUs
(opposed to pixels) to be in line with other client anchor usages in XSSF.
I've moved the client anchor tests for xssf/hssf to the common base class.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org