[superset] branch lyndsi/ResultsPaneOnDashboard-act-cleanup created (now e208eeb84d)

[ly...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lyndsi pushed a change to branch lyndsi/ResultsPaneOnDashboard-act-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git


      at e208eeb84d 6 act errors removed from ResultsPaneOnDashboard test

This branch includes the following new commits:

     new e208eeb84d 6 act errors removed from ResultsPaneOnDashboard test

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[superset] 01/01: 6 act errors removed from ResultsPaneOnDashboard test

[ly...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lyndsi pushed a commit to branch lyndsi/ResultsPaneOnDashboard-act-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git

commit e208eeb84d7cf94e60d74c6625950cecce884aa0
Author: lyndsiWilliams <kc...@gmail.com>
AuthorDate: Fri Sep 9 01:20:11 2022 -0500

    6 act errors removed from ResultsPaneOnDashboard test
---
 .../components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/superset-frontend/src/explore/components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx b/superset-frontend/src/explore/components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx
index d45149528b..839126bb62 100644
--- a/superset-frontend/src/explore/components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx
+++ b/superset-frontend/src/explore/components/DataTablesPane/test/ResultsPaneOnDashboard.test.tsx
@@ -22,9 +22,10 @@ import userEvent from '@testing-library/user-event';
 import {
   render,
   waitForElementToBeRemoved,
+  waitFor,
 } from 'spec/helpers/testing-library';
 import { exploreActions } from 'src/explore/actions/exploreActions';
-import { ChartMetadata, ChartPlugin, promiseTimeout } from '@superset-ui/core';
+import { ChartMetadata, ChartPlugin } from '@superset-ui/core';
 import { ResultsPaneOnDashboard } from '../components';
 import { createResultsPaneOnDashboardProps } from './fixture';
 
@@ -133,9 +134,9 @@ describe('ResultsPaneOnDashboard', () => {
       },
     );
 
-    await promiseTimeout(() => {
+    await waitFor(() => {
       expect(setForceQuery).toHaveBeenCalledTimes(1);
-    }, 10);
+    });
     expect(queryByText('2 rows')).toBeVisible();
     expect(queryByText('Action')).toBeVisible();
     expect(queryByText('Horror')).toBeVisible();