You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2024/02/27 06:51:27 UTC
[PR] [fix](vec) wrong implementation of operator <=> of Field (#29743) [doris]
mrhhsg opened a new pull request, #31452:
URL: https://github.com/apache/doris/pull/31452
## Proposed changes
pick #29743 from master into 2.0
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](vec) wrong implementation of operator <=> of Field (#29743) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31452:
URL: https://github.com/apache/doris/pull/31452#issuecomment-1965971297
<details>
<summary>TPC-DS: <b>Total hot run time: 202720 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 130bd5e94ce2ed6e4df1374a5dfb517e9fa90f44, data reload: false
query1 930 395 379 379
query2 6518 2334 2089 2089
query3 6915 205 208 205
query4 20154 18033 17942 17942
query5 19727 6487 6559 6487
query6 280 215 226 215
query7 4154 304 313 304
query8 260 263 257 257
query9 3145 2722 2658 2658
query10 427 318 287 287
query11 11391 10644 10631 10631
query12 117 77 73 73
query13 5573 632 629 629
query14 18381 14093 13692 13692
query15 355 238 240 238
query16 6431 263 258 258
query17 1593 1453 872 872
query18 2275 401 417 401
query19 212 142 147 142
query20 79 84 74 74
query21 191 94 99 94
query22 5249 5021 5076 5021
query23 32515 31944 31844 31844
query24 6930 6524 6466 6466
query25 533 432 421 421
query26 630 171 162 162
query27 2071 303 299 299
query28 6059 2229 2186 2186
query29 2816 2638 2690 2638
query30 237 163 167 163
query31 918 733 735 733
query32 70 62 56 56
query33 394 253 250 250
query34 863 476 495 476
query35 1126 931 970 931
query36 1730 1379 1377 1377
query37 88 62 58 58
query38 3070 2930 2967 2930
query39 1383 1328 1329 1328
query40 252 88 98 88
query41 35 36 32 32
query42 85 88 83 83
query43 725 591 682 591
query44 1135 707 715 707
query45 243 228 229 228
query46 1237 994 997 994
query47 1854 1641 1783 1641
query48 982 681 691 681
query49 627 377 354 354
query50 851 612 637 612
query51 4808 4639 4650 4639
query52 93 79 83 79
query53 454 325 321 321
query54 2657 2483 2495 2483
query55 84 82 85 82
query56 217 211 194 194
query57 1219 1075 1062 1062
query58 209 206 191 191
query59 3546 3129 3291 3129
query60 210 182 198 182
query61 83 83 90 83
query62 856 515 480 480
query63 478 338 344 338
query64 2526 1476 1451 1451
query65 3635 3591 3583 3583
query66 802 375 377 375
query67 17499 18204 15435 15435
query68 8367 668 657 657
query69 569 363 347 347
query70 2027 1775 1783 1775
query71 394 303 306 303
query72 6490 3423 3408 3408
query73 736 318 321 318
query74 6305 5842 5916 5842
query75 4568 3667 3711 3667
query76 4593 1168 1224 1168
query77 593 252 250 250
query78 12509 11951 11885 11885
query79 7961 625 643 625
query80 1029 391 396 391
query81 497 235 241 235
query82 1513 99 92 92
query83 162 134 134 134
query84 256 69 71 69
query85 905 271 278 271
query86 391 363 358 358
query87 3268 3010 2994 2994
query88 5201 2353 2345 2345
query89 365 298 285 285
query90 1902 217 199 199
query91 153 113 118 113
query92 58 49 50 49
query93 4622 577 562 562
query94 748 206 207 206
query95 1128 1083 1070 1070
query96 652 324 337 324
query97 6507 6366 6368 6366
query98 188 174 161 161
query99 2866 867 968 867
Total cold run time: 310715 ms
Total hot run time: 202720 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](vec) wrong implementation of operator <=> of Field (#29743) [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #31452:
URL: https://github.com/apache/doris/pull/31452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](vec) wrong implementation of operator <=> of Field (#29743) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31452:
URL: https://github.com/apache/doris/pull/31452#issuecomment-1965894946
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](vec) wrong implementation of operator <=> of Field (#29743) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31452:
URL: https://github.com/apache/doris/pull/31452#issuecomment-1965955644
<details>
<summary>TPC-H: <b>Total hot run time: 50355 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 130bd5e94ce2ed6e4df1374a5dfb517e9fa90f44, data reload: false
------ Round 1 ----------------------------------
q1 17984 4451 4432 4432
q2 2024 147 142 142
q3 10455 1914 1963 1914
q4 10331 1267 1338 1267
q5 8418 4024 4077 4024
q6 246 132 126 126
q7 2050 1607 1617 1607
q8 9299 2737 2761 2737
q9 11061 10624 10510 10510
q10 8648 3525 3537 3525
q11 433 243 237 237
q12 473 303 308 303
q13 18347 3964 4028 3964
q14 351 324 325 324
q15 509 457 455 455
q16 715 602 589 589
q17 1145 966 974 966
q18 7310 6972 6913 6913
q19 1708 1574 1492 1492
q20 542 303 320 303
q21 4540 4162 4139 4139
q22 511 407 386 386
Total cold run time: 117100 ms
Total hot run time: 50355 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4369 4348 4304 4304
q2 321 225 221 221
q3 4172 4178 4151 4151
q4 2770 2763 2767 2763
q5 7290 7191 7246 7191
q6 238 125 123 123
q7 3276 2875 2932 2875
q8 4377 4514 4462 4462
q9 17104 16975 17005 16975
q10 4255 4266 4282 4266
q11 789 680 687 680
q12 1052 860 854 854
q13 7379 3765 3743 3743
q14 447 417 412 412
q15 503 455 463 455
q16 762 699 694 694
q17 3805 3811 3897 3811
q18 8875 8769 8790 8769
q19 1755 1719 1668 1668
q20 2398 2154 2097 2097
q21 8568 8588 8514 8514
q22 1045 961 991 961
Total cold run time: 85550 ms
Total hot run time: 79989 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](vec) wrong implementation of operator <=> of Field (#29743) [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #31452:
URL: https://github.com/apache/doris/pull/31452#issuecomment-1965895000
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](vec) wrong implementation of operator <=> of Field (#29743) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31452:
URL: https://github.com/apache/doris/pull/31452#issuecomment-1965978709
<details>
<summary>ClickBench: <b>Total hot run time: 31.16 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 130bd5e94ce2ed6e4df1374a5dfb517e9fa90f44, data reload: false
query1 0.02 0.02 0.02
query2 0.06 0.02 0.02
query3 0.25 0.06 0.04
query4 1.80 0.06 0.07
query5 0.53 0.52 0.52
query6 1.26 0.61 0.61
query7 0.01 0.01 0.01
query8 0.04 0.02 0.02
query9 0.54 0.47 0.46
query10 0.53 0.53 0.53
query11 0.13 0.09 0.08
query12 0.12 0.09 0.10
query13 0.62 0.62 0.62
query14 0.77 0.78 0.77
query15 0.79 0.76 0.78
query16 0.37 0.37 0.36
query17 1.01 1.02 1.00
query18 0.25 0.24 0.26
query19 1.97 1.74 1.84
query20 0.01 0.01 0.01
query21 15.50 0.57 0.55
query22 2.02 2.30 2.13
query23 17.23 1.08 1.04
query24 4.57 1.08 1.34
query25 0.38 0.10 0.05
query26 0.53 0.13 0.14
query27 0.04 0.04 0.05
query28 8.73 0.77 0.72
query29 12.63 2.36 2.10
query30 0.59 0.53 0.52
query31 2.83 0.39 0.37
query32 3.36 0.50 0.49
query33 3.08 3.06 3.10
query34 15.25 4.81 4.81
query35 4.84 4.86 4.85
query36 1.06 1.03 1.01
query37 0.06 0.05 0.04
query38 0.03 0.02 0.02
query39 0.02 0.01 0.02
query40 0.16 0.14 0.14
query41 0.06 0.02 0.01
query42 0.02 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 104.09 s
Total hot run time: 31.16 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](vec) wrong implementation of operator <=> of Field (#29743) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31452:
URL: https://github.com/apache/doris/pull/31452#issuecomment-1965902042
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](vec) wrong implementation of operator <=> of Field (#29743) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31452:
URL: https://github.com/apache/doris/pull/31452#issuecomment-1965984515
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 130bd5e94ce2ed6e4df1374a5dfb517e9fa90f44 with default session variables
Stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 21.0 seconds inserted 10000000 Rows, about 476K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](vec) wrong implementation of operator <=> of Field (#29743) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31452:
URL: https://github.com/apache/doris/pull/31452#issuecomment-1965981856
TeamCity be ut coverage result:
Function Coverage: 37.79% (8033/21256)
Line Coverage: 29.48% (65524/222278)
Region Coverage: 28.94% (33701/116470)
Branch Coverage: 24.79% (17294/69766)
Coverage Report: http://coverage.selectdb-in.cc/coverage/130bd5e94ce2ed6e4df1374a5dfb517e9fa90f44_130bd5e94ce2ed6e4df1374a5dfb517e9fa90f44/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org