You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2015/06/08 17:42:31 UTC

Re: Review Request 34726: HIVE-10533

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34726/
-----------------------------------------------------------

(Updated June 8, 2015, 3:42 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Bugs: HIVE-10533
    https://issues.apache.org/jira/browse/HIVE-10533


Repository: hive-git


Description
-------

CBO (Calcite Return Path): Join to MultiJoin support for outer joins


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 199a358ba16e857f3b4bf9b0c07d1919eeb709d4 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInsertExchange4JoinRule.java 11c3d23ea7439b713b66a09a9911e47e847f2b18 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java 532d7d3b56377946f6a9ad883d7b7dbf1325a8c7 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectMergeRule.java 8b90a15b5517a0b83c22b7a9bbbd90398c45184a 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java 3d1a3091bd0d9a99366da565f9c136aff0983bb7 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 9c2123899ef6404aeae31682d5bdc78b81c95a37 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 48e3cc76f32dbd0959babb241668a638baab567f 
  ql/src/test/queries/clientpositive/cbo_rp_join0.q PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_join0.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/34726/diff/


Testing
-------


Thanks,

Jesús Camacho Rodríguez


Re: Review Request 34726: HIVE-10533

Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34726/#review88480
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java (line 81)
<https://reviews.apache.org/r/34726/#comment141037>

    Formatting



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java (line 345)
<https://reviews.apache.org/r/34726/#comment141038>

    Formatting



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java (line 530)
<https://reviews.apache.org/r/34726/#comment141040>

    Formatting



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java (line 544)
<https://reviews.apache.org/r/34726/#comment141041>

    Formatting



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java (line 556)
<https://reviews.apache.org/r/34726/#comment141042>

    Formatting



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java (line 27)
<https://reviews.apache.org/r/34726/#comment141043>

    Formatting



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java (line 74)
<https://reviews.apache.org/r/34726/#comment141045>

    Formatting



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java (line 317)
<https://reviews.apache.org/r/34726/#comment141046>

    Formatting


- John Pullokkaran


On June 15, 2015, 6:16 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34726/
> -----------------------------------------------------------
> 
> (Updated June 15, 2015, 6:16 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
> 
> 
> Bugs: HIVE-10533
>     https://issues.apache.org/jira/browse/HIVE-10533
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> CBO (Calcite Return Path): Join to MultiJoin support for outer joins
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 199a358ba16e857f3b4bf9b0c07d1919eeb709d4 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInsertExchange4JoinRule.java 11c3d23ea7439b713b66a09a9911e47e847f2b18 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java 532d7d3b56377946f6a9ad883d7b7dbf1325a8c7 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectMergeRule.java 8b90a15b5517a0b83c22b7a9bbbd90398c45184a 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java 3d1a3091bd0d9a99366da565f9c136aff0983bb7 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 9c2123899ef6404aeae31682d5bdc78b81c95a37 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java bff97721c6ad540a1f8598e617d1c5f452d1cdeb 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 37012b49873495b60ea3f6cceadece1941b06b04 
>   ql/src/test/queries/clientpositive/cbo_rp_join0.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/cbo_rp_join1.q PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_join0.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/cbo_rp_join1.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34726/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Re: Review Request 34726: HIVE-10533

Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34726/
-----------------------------------------------------------

(Updated June 24, 2015, 5:57 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Bugs: HIVE-10533
    https://issues.apache.org/jira/browse/HIVE-10533


Repository: hive-git


Description
-------

CBO (Calcite Return Path): Join to MultiJoin support for outer joins


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 199a358ba16e857f3b4bf9b0c07d1919eeb709d4 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInsertExchange4JoinRule.java 11c3d23ea7439b713b66a09a9911e47e847f2b18 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java 532d7d3b56377946f6a9ad883d7b7dbf1325a8c7 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectMergeRule.java 8b90a15b5517a0b83c22b7a9bbbd90398c45184a 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java 3d1a3091bd0d9a99366da565f9c136aff0983bb7 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java a75d029ccf5b966347e5bf4b8c38695e89f80171 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e821b1de5af947768dca916627911ed5d3433a7f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 37012b49873495b60ea3f6cceadece1941b06b04 
  ql/src/test/queries/clientpositive/cbo_rp_join0.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cbo_rp_join1.q PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_join0.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_join1.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/34726/diff/


Testing
-------


Thanks,

Jesús Camacho Rodríguez


Re: Review Request 34726: HIVE-10533

Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34726/
-----------------------------------------------------------

(Updated June 19, 2015, 2:52 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Bugs: HIVE-10533
    https://issues.apache.org/jira/browse/HIVE-10533


Repository: hive-git


Description
-------

CBO (Calcite Return Path): Join to MultiJoin support for outer joins


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 199a358ba16e857f3b4bf9b0c07d1919eeb709d4 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInsertExchange4JoinRule.java 11c3d23ea7439b713b66a09a9911e47e847f2b18 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java 532d7d3b56377946f6a9ad883d7b7dbf1325a8c7 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectMergeRule.java 8b90a15b5517a0b83c22b7a9bbbd90398c45184a 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java 3d1a3091bd0d9a99366da565f9c136aff0983bb7 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 9c2123899ef6404aeae31682d5bdc78b81c95a37 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java bff97721c6ad540a1f8598e617d1c5f452d1cdeb 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 37012b49873495b60ea3f6cceadece1941b06b04 
  ql/src/test/queries/clientpositive/cbo_rp_join0.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cbo_rp_join1.q PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_join0.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_join1.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/34726/diff/


Testing
-------


Thanks,

Jesús Camacho Rodríguez


Re: Review Request 34726: HIVE-10533

Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34726/
-----------------------------------------------------------

(Updated June 15, 2015, 6:16 p.m.)


Review request for hive, Ashutosh Chauhan and John Pullokkaran.


Bugs: HIVE-10533
    https://issues.apache.org/jira/browse/HIVE-10533


Repository: hive-git


Description
-------

CBO (Calcite Return Path): Join to MultiJoin support for outer joins


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 199a358ba16e857f3b4bf9b0c07d1919eeb709d4 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveMultiJoin.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveInsertExchange4JoinRule.java 11c3d23ea7439b713b66a09a9911e47e847f2b18 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java 532d7d3b56377946f6a9ad883d7b7dbf1325a8c7 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveProjectMergeRule.java 8b90a15b5517a0b83c22b7a9bbbd90398c45184a 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java 3d1a3091bd0d9a99366da565f9c136aff0983bb7 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 9c2123899ef6404aeae31682d5bdc78b81c95a37 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java bff97721c6ad540a1f8598e617d1c5f452d1cdeb 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 37012b49873495b60ea3f6cceadece1941b06b04 
  ql/src/test/queries/clientpositive/cbo_rp_join0.q PRE-CREATION 
  ql/src/test/queries/clientpositive/cbo_rp_join1.q PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_join0.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/cbo_rp_join1.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/34726/diff/


Testing
-------


Thanks,

Jesús Camacho Rodríguez