You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by or...@apache.org on 2021/03/03 08:06:01 UTC
[camel-kafka-connector] 01/11: Use isEmpty for emptiness check as
it's a bit more idiomatic
This is an automated email from the ASF dual-hosted git repository.
orpiske pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git
commit 2a045fd5c5d68f6fc285707e6d5d3b1a5c391917
Author: Otavio Rodolfo Piske <op...@redhat.com>
AuthorDate: Wed Feb 24 11:26:56 2021 +0100
Use isEmpty for emptiness check as it's a bit more idiomatic
---
.../kafkaconnector/maven/docs/UpdateDocComponentsListMojo.java | 6 +++---
.../camel/kafkaconnector/maven/CamelKafkaConnectorUpdateMojo.java | 4 ++--
.../camel/kafkaconnector/maven/utils/JsonMapperKafkaConnector.java | 6 +++---
.../org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java | 2 +-
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/tooling/camel-kafka-connector-docs-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/docs/UpdateDocComponentsListMojo.java b/tooling/camel-kafka-connector-docs-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/docs/UpdateDocComponentsListMojo.java
index 4b22b49..2ca59b6 100644
--- a/tooling/camel-kafka-connector-docs-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/docs/UpdateDocComponentsListMojo.java
+++ b/tooling/camel-kafka-connector-docs-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/docs/UpdateDocComponentsListMojo.java
@@ -123,10 +123,10 @@ public class UpdateDocComponentsListMojo extends AbstractMojo {
if (file.isDirectory()) {
Collection sinkConnector = FileUtils.listFiles(file, new RegexFileFilter(".*SinkTask.*"), DirectoryFileFilter.DIRECTORY);
Collection sourceConnector = FileUtils.listFiles(file, new RegexFileFilter(".*SourceTask.*"), DirectoryFileFilter.DIRECTORY);
- if (sinkConnector.size() > 0 || sourceConnector.size() > 0) {
+ if (!sinkConnector.isEmpty() || !sourceConnector.isEmpty()) {
CamelKafkaConnectorTableOptionModel singleConnector = new CamelKafkaConnectorTableOptionModel();
singleConnector.setName(file.getName());
- if (sinkConnector.size() > 0) {
+ if (!sinkConnector.isEmpty()) {
singleConnector.setSink(true);
String connectorFinal = StringUtils.removeEnd(file.getName(), "kafka-connector");
if (connectorFinal.equalsIgnoreCase("camel-coap-tcp-")) {
@@ -139,7 +139,7 @@ public class UpdateDocComponentsListMojo extends AbstractMojo {
singleConnector.setDocsSink(XREF_CONNECTOR_LINK_PREFIX + connectorFinal + SINK_CONNECTOR_LINK_SUFFIX_ADOC);
}
}
- if (sourceConnector.size() > 0) {
+ if (!sourceConnector.isEmpty()) {
singleConnector.setSource(true);
String connectorFinal = StringUtils.removeEnd(file.getName(), "kafka-connector");
if (connectorFinal.equalsIgnoreCase("camel-coap-tcp-")) {
diff --git a/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/CamelKafkaConnectorUpdateMojo.java b/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/CamelKafkaConnectorUpdateMojo.java
index a494a7d..ae99dcb 100644
--- a/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/CamelKafkaConnectorUpdateMojo.java
+++ b/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/CamelKafkaConnectorUpdateMojo.java
@@ -258,7 +258,7 @@ public class CamelKafkaConnectorUpdateMojo extends AbstractCamelKafkaConnectorMo
libsToRemove.addAll(loggingImpl);
libsToRemove.addAll(configExclusions);
- if (libsToRemove.size() > 0) {
+ if (!libsToRemove.isEmpty()) {
getLog().info("Camel-kafka-connector: the following dependencies will be removed from the connector: " + libsToRemove);
MavenUtils.addExclusionsToDependency(pom, getMainDepArtifactId(), libsToRemove, GENERATED_SECTION_START, GENERATED_SECTION_END);
}
@@ -288,7 +288,7 @@ public class CamelKafkaConnectorUpdateMojo extends AbstractCamelKafkaConnectorMo
deps.addAll(globalProps);
}
- if (deps.size() > 0) {
+ if (!deps.isEmpty()) {
getLog().debug("The following dependencies will be added to the starter: " + deps);
MavenUtils.addDependencies(pom, deps, GENERATED_SECTION_START, GENERATED_SECTION_END);
}
diff --git a/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/JsonMapperKafkaConnector.java b/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/JsonMapperKafkaConnector.java
index a03241a..6c3a70b 100644
--- a/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/JsonMapperKafkaConnector.java
+++ b/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/JsonMapperKafkaConnector.java
@@ -43,13 +43,13 @@ public final class JsonMapperKafkaConnector {
JsonObject wrapper = new JsonObject();
wrapper.put("connector", obj);
wrapper.put("properties", asJsonObject(model.getOptions()));
- if (model.getConverters().size() > 0) {
+ if (!model.getConverters().isEmpty()) {
wrapper.put("converters", new JsonArray(model.getConverters()));
}
- if (model.getTransforms().size() > 0) {
+ if (!model.getTransforms().isEmpty()) {
wrapper.put("transforms", new JsonArray(model.getTransforms()));
}
- if (model.getAggregationStrategies().size() > 0) {
+ if (!model.getAggregationStrategies().isEmpty()) {
wrapper.put("aggregationStrategies", new JsonArray(model.getAggregationStrategies()));
}
return wrapper;
diff --git a/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java b/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java
index 1e26f4e..0a560a7 100644
--- a/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java
+++ b/tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java
@@ -182,7 +182,7 @@ public final class MavenUtils {
XPath xpath = XPathFactory.newInstance().newXPath();
Node dependencies = ((NodeList) xpath.compile("/project/dependencies").evaluate(pom, XPathConstants.NODESET)).item(0);
- if (deps.size() > 0) {
+ if (!deps.isEmpty()) {
dependencies.appendChild(pom.createComment(generatedSectionStartMarker));
for (String dep : deps) {
Element dependency = pom.createElement("dependency");