[GitHub] [incubator-pinot] jackjlli commented on pull request #7033: Include null check for setting minion tag.

[GitBox <gi...@apache.org>]

jackjlli commented on pull request #7033:
URL: https://github.com/apache/incubator-pinot/pull/7033#issuecomment-857268994


   > `InstanceConfig.getTags()` should never return `null`. Are you using a different Helix version?
   > Here's the Helix code:
   > 
   > ```
   >   public List<String> getTags() {
   >     List<String> tags = getRecord().getListField(InstanceConfigProperty.TAG_LIST.toString());
   >     if (tags == null) {
   >       tags = new ArrayList<String>(0);
   >     }
   >     return tags;
   >   }
   > ```
   
   Thanks for pointing out! The purpose of this PR is to address an issue when the helix tag for minion host is missing, and we suspect that it's due to an NPE from this part of code. @amrishlal we can remove the null check for the returned reference of getTags, while a null check is needed for instanceConfig. Please include that into this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org