You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/12/22 17:49:44 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request, #6802: NIFI-11004 Add documentation for OIDC groups claim property
exceptionfactory opened a new pull request, #6802:
URL: https://github.com/apache/nifi/pull/6802
# Summary
[NIFI-11004](https://issues.apache.org/jira/browse/NIFI-11004) Updates the Administrator's Guide with documentation for the OIDC groups claim property and also updates the standard `nifi.properties` configuration with the default value of `groups`, matching the current internal behavior.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [X] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 closed pull request #6802: NIFI-11004 Add documentation for OIDC groups claim property
Posted by GitBox <gi...@apache.org>.
greyp9 closed pull request #6802: NIFI-11004 Add documentation for OIDC groups claim property
URL: https://github.com/apache/nifi/pull/6802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] Lehel44 commented on a diff in pull request #6802: NIFI-11004 Add documentation for OIDC groups claim property
Posted by GitBox <gi...@apache.org>.
Lehel44 commented on code in PR #6802:
URL: https://github.com/apache/nifi/pull/6802#discussion_r1056363577
##########
nifi-docs/src/main/asciidoc/administration-guide.adoc:
##########
@@ -503,6 +503,9 @@ JSON Web Key (JWK) provided through the jwks_uri in the metadata found at the di
|`nifi.security.user.oidc.additional.scopes` | Comma separated scopes that are sent to OpenId Connect Provider in addition to `openid` and `email`.
|`nifi.security.user.oidc.claim.identifying.user` | Claim that identifies the user to be logged in; default is `email`. May need to be requested via the `nifi.security.user.oidc.additional.scopes` before usage.
|`nifi.security.user.oidc.fallback.claims.identifying.user` | Comma separated possible fallback claims used to identify the user in case `nifi.security.user.oidc.claim.identifying.user` claim is not present for the login user.
+|`nifi.security.user.oidc.claim.groups` | Name of the ID token claim that contains an array of group names of which the
+user is a member. Application groups must be supplied from a User Group Provider with matching names in order for the
+authorization process to use ID token claim groups. The default value is `groups`.
Review Comment:
```suggestion
user is a member. Application groups must be supplied by a User Group Provider with matching names for the
authorization process to use ID token claim groups. The default value is `groups`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6802: NIFI-11004 Add documentation for OIDC groups claim property
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6802:
URL: https://github.com/apache/nifi/pull/6802#issuecomment-1364109162
> Why do we need to update nifi-resources.pom?
Thanks for the feedback @Lehel44. The updates to `pom.xml` in `nifi-resources` sets the default value for the `nifi.properties` configuration included in the standard distribution. This follows the convention of other default property values, and also allows custom builds to set different default values using Maven properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] Lehel44 commented on pull request #6802: NIFI-11004 Add documentation for OIDC groups claim property
Posted by GitBox <gi...@apache.org>.
Lehel44 commented on PR #6802:
URL: https://github.com/apache/nifi/pull/6802#issuecomment-1364593106
Thank you. LGTM+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org