[jira] Reopened: (SHINDIG-1387) Signature of getSecurityToken in BasicOAuthLookupService does not match base class OAuthLookupService

["Bastian Hofmann (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bastian Hofmann reopened SHINDIG-1387:
--------------------------------------


If I have a look into the current trunk the BasicOAuthLookupService still is wrong:

/**
 * Basic implementation of OAuthLookupService using BasicOAuthDataStore.
 */
class BasicOAuthLookupService extends OAuthLookupService {

  public function getSecurityToken($oauthRequest, $appUrl, $userId) {
    return new OAuthSecurityToken($userId, $appUrl, $this->getAppId($appUrl), "samplecontainer");
  }

  private function getAppId($appUrl) {
    return 0; // a real implementation would look this up
  }
}

https://svn.apache.org/repos/asf/shindig/trunk/php/src/common/sample/BasicOAuthLookupService.php


> Signature of getSecurityToken in BasicOAuthLookupService does not match base class OAuthLookupService
> -----------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1387
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1387
>             Project: Shindig
>          Issue Type: Bug
>            Reporter: Bastian Hofmann
>             Fix For: 2.0.0-RC1
>
>
> Patch:
> Index: php/src/common/sample/BasicOAuthLookupService.php
> ===================================================================
> 27c27
> <   public function getSecurityToken($oauthRequest, $appUrl, $userId) {
> ---
> >   public function getSecurityToken($oauthRequest, $appUrl, $userId, $contentType) {

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.