You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "luoluoyuyu (via GitHub)" <gi...@apache.org> on 2026/08/27 06:20:13 UTC
[PR] fix(load): validate TsFile before async move [iotdb]
luoluoyuyu opened a new pull request, #18531:
URL: https://github.com/apache/iotdb/pull/18531
## Description
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(load): validate TsFile before async move [iotdb]
Posted by "Caideyipi (via GitHub)" <gi...@apache.org>.
Caideyipi commented on code in PR #18531:
URL: https://github.com/apache/iotdb/pull/18531#discussion_r3871346103
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/util/LoadUtil.java:
##########
@@ -118,6 +120,11 @@ private static boolean loadTsFilesToActiveDir(
return true;
}
+ // Validate before moving the source so ordinary or malformed files remain in place.
+ if (!isValidTsFile(file)) {
Review Comment:
[P1] Validate the complete batch before moving any file
`loadTsFileAsyncToActiveDir` calls this method once per `*.tsfile`. If a directory contains a valid `*.tsfile` followed by a malformed `*.tsfile`, the valid file has already been copied/linked into the active-load directory before this call returns `false` for the malformed one. `doAsyncLoad` then falls back to normal analysis, but the first file remains queued; with `on-success='delete'`, its source may already be deleted as well. This can cause partial ingestion and unsafe retries. Validate all files before starting the transfer, or roll back every transfer when a later validation fails.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/util/LoadUtil.java:
##########
@@ -145,6 +152,19 @@ private static boolean loadTsFilesToActiveDir(
return true;
}
+ private static boolean isValidTsFile(final File file) {
Review Comment:
[P1] Apply this validation to the Pipe async path too
`IoTDBDataNodeReceiver.loadTsFileAsync` calls `LoadUtil.loadFilesToActiveDir`, but `isValidTsFile` is only invoked from `loadTsFilesToActiveDir`. The Pipe seal path therefore still transfers and deletes the main TsFile even when its magic is invalid, then returns `SUCCESS_STATUS`; the active loader fails later, after the sender has already been acknowledged. Identify the main `.tsfile` entry and apply the same validation in `loadFilesToActiveDir` before `transferFilesToActiveDir` (while preserving valid `.resource`/`.mods` sidecars), and add coverage for this path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(load): validate TsFile before async move [iotdb]
Posted by "Caideyipi (via GitHub)" <gi...@apache.org>.
Caideyipi commented on code in PR #18531:
URL: https://github.com/apache/iotdb/pull/18531#discussion_r3871346115
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/util/LoadUtil.java:
##########
@@ -145,6 +152,19 @@ private static boolean loadTsFilesToActiveDir(
return true;
}
+ private static boolean isValidTsFile(final File file) {
Review Comment:
[P1] Apply this validation to the Pipe async path too
`IoTDBDataNodeReceiver.loadTsFileAsync` calls `LoadUtil.loadFilesToActiveDir`, but `isValidTsFile` is only invoked from `loadTsFilesToActiveDir`. The Pipe seal path therefore still transfers and deletes a file with a bad suffix or invalid magic, then returns `SUCCESS_STATUS`; the active loader fails later, after the sender has already been acknowledged. Reuse the same validation in `loadFilesToActiveDir` before `transferFilesToActiveDir`, and add coverage for this path.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/util/LoadUtil.java:
##########
@@ -118,6 +120,11 @@ private static boolean loadTsFilesToActiveDir(
return true;
}
+ // Validate before moving the source so ordinary or malformed files remain in place.
+ if (!isValidTsFile(file)) {
Review Comment:
[P1] Validate the complete batch before moving any file
`loadTsFileAsyncToActiveDir` calls this method once per file. If a directory contains a valid `*.tsfile` followed by an invalid file, the valid file has already been copied/linked into the active-load directory before this call returns `false` for the invalid one. `doAsyncLoad` then falls back to normal analysis, but the first file remains queued; with `on-success='delete'`, its source may already be deleted as well. This can cause partial ingestion and unsafe retries. Validate all files before starting the transfer, or roll back every transfer when a later validation fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(load): validate TsFile before async move [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18531:
URL: https://github.com/apache/iotdb/pull/18531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org