You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/20 13:45:54 UTC

[GitHub] [commons-lang] garydgregory commented on a change in pull request #520: Implement Utils classes in Kotlin.

garydgregory commented on a change in pull request #520:
URL: https://github.com/apache/commons-lang/pull/520#discussion_r411388223



##########
File path: pom.xml
##########
@@ -74,7 +71,7 @@
       <name>Henri Yandell</name>
       <id>bayard</id>
       <email>bayard@apache.org</email>
-      <organization />
+      <organization/>

Review comment:
       @Isira-Seneviratne 
   Please do not change this formatting.

##########
File path: pom.xml
##########
@@ -553,6 +550,12 @@
       <scope>test</scope>
     </dependency>
 
+    <!-- Kotlin -->
+    <dependency>
+      <groupId>org.jetbrains.kotlin</groupId>
+      <artifactId>kotlin-stdlib-jdk8</artifactId>
+      <version>${kotlin.version}</version>
+    </dependency>
   </dependencies>

Review comment:
       -1, that's a bridge too far IMO. If we want to create a Kotlin Commons Lang, we can talk about that on the developer's mailing list...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org