[jira] [Commented] (OAK-6311) Move generic part of PropertyStateValue and PropertyValues to oak-store-spi

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039078#comment-16039078 ] 

Michael Dürig commented on OAK-6311:
------------------------------------

LGTM in general. But why didn't you move {{PropertyValues.convert()}} together with its class but put it into its own {{ValueConverter}} class instead, which stays in {{org.apache.jackrabbit.oak.query}}? 



> Move generic part of PropertyStateValue and PropertyValues to oak-store-spi
> ---------------------------------------------------------------------------
>
>                 Key: OAK-6311
>                 URL: https://issues.apache.org/jira/browse/OAK-6311
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: core, query, store-spi
>            Reporter: angela
>         Attachments: OAK-6311.patch, OAK-6311-tests.patch
>
>
> in the light of the modularisation effort i found that {{o.a.j.oak.spi.query.PropertyStateValue}} and {{o.a.j.oak.spi.query.PropertyValues}} are intended for generic usage and aren't any specific to the query spi.
> since it used in other parts of oak as utility to create {{PropertyValue}} instances, i would like to suggest that we move the generic parts of these 2 classes to {{o.a.j.oak.plugins.memory}} thus to the _oak-store-spi_ module.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)