You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/20 02:03:07 UTC

[GitHub] [incubator-hudi] zhaomin1423 opened a new pull request #1422: [HUDI-400]check upgrade from old plan to new plan for compaction

zhaomin1423 opened a new pull request #1422: [HUDI-400]check upgrade from old plan to new plan for compaction
URL: https://github.com/apache/incubator-hudi/pull/1422
 
 
   What is the purpose of the pull request
   Add more test for compaction plan upgrade
   
   Brief change log
   check upgrade from old plan to new plan for compaction
   Verify this pull request
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] codecov-io commented on issue #1422: [HUDI-400]check upgrade from old plan to new plan for compaction

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1422: [HUDI-400]check upgrade from old plan to new plan for compaction
URL: https://github.com/apache/incubator-hudi/pull/1422#issuecomment-601500333
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1422?src=pr&el=h1) Report
   > Merging [#1422](https://codecov.io/gh/apache/incubator-hudi/pull/1422?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/a752b7b18c5c74c0c9115168188fa4a15a670225?src=pr&el=desc) will **increase** coverage by `0.04%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1422/graphs/tree.svg?width=650&token=VTTXabwbs2&height=150&src=pr)](https://codecov.io/gh/apache/incubator-hudi/pull/1422?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1422      +/-   ##
   ============================================
   + Coverage     67.51%   67.56%   +0.04%     
     Complexity      255      255              
   ============================================
     Files           340      340              
     Lines         16499    16499              
     Branches       1686     1687       +1     
   ============================================
   + Hits          11139    11147       +8     
   + Misses         4622     4615       -7     
   + Partials        738      737       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1422?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...oning/compaction/CompactionV2MigrationHandler.java](https://codecov.io/gh/apache/incubator-hudi/pull/1422/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3ZlcnNpb25pbmcvY29tcGFjdGlvbi9Db21wYWN0aW9uVjJNaWdyYXRpb25IYW5kbGVyLmphdmE=) | `84.21% <100%> (+21.05%)` | `0 <0> (ø)` | :arrow_down: |
   | [...src/main/java/org/apache/hudi/metrics/Metrics.java](https://codecov.io/gh/apache/incubator-hudi/pull/1422/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `56.75% <0%> (-13.52%)` | `0% <0%> (ø)` | |
   | [...pache/hudi/common/versioning/MetadataMigrator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1422/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3ZlcnNpb25pbmcvTWV0YWRhdGFNaWdyYXRvci5qYXZh) | `83.33% <0%> (+25%)` | `0% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1422?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1422?src=pr&el=footer). Last update [a752b7b...bf8ecdf](https://codecov.io/gh/apache/incubator-hudi/pull/1422?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] leesf merged pull request #1422: [HUDI-400]check upgrade from old plan to new plan for compaction

Posted by GitBox <gi...@apache.org>.
leesf merged pull request #1422: [HUDI-400]check upgrade from old plan to new plan for compaction
URL: https://github.com/apache/incubator-hudi/pull/1422
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services