[GitHub] [hbase] Apache9 commented on a change in pull request #3883: HBASE-26490 Add builder for class ReplicationLoadSink

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #3883:
URL: https://github.com/apache/hbase/pull/3883#discussion_r758089951



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationLoadSink.java
##########
@@ -47,4 +46,42 @@ public long getTimestampStarted() {
   public long getTotalOpsProcessed() {
     return totalOpsProcessed;
   }
+
+  public static ReplicationLoadSinkBuilder newBuilder() {

Review comment:
       I think the above IA.Priavte annotation on the constructor means we do not want end users to create this? So I suggest that we move ReplicationLoadSinkBuilder to a separated file, marked it as IA.Private, and provide a create method for creating the ReplicationLoadSinkBuilder. And the constructor of ReplicationLoadSink could be package private.

##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationLoadSink.java
##########
@@ -22,9 +22,8 @@
   private final long timestampStarted;
   private final long totalOpsProcessed;
 
-  // TODO: add the builder for this class
   @InterfaceAudience.Private

Review comment:
       Since this is private now, we do not need IA.Private annotation then?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org