You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/09/11 03:38:54 UTC
Review Request 14074: Hid links to dead slaves to prevent dead links.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14074/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Hid links to dead slaves to prevent dead links.
If a slave is gone, the framework page will print "Slave gone" in place
of the links to the slave's UI. The links would previously fail in
redirection and return the user to the Mesos root page, which is
unpleasant.
Fixes: https://issues.apache.org/jira/browse/MESOS-650
Diffs
-----
src/webui/master/static/framework.html 1973cbed6759d0f007816377319a17c7e91a182d
Diff: https://reviews.apache.org/r/14074/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 14074: Hid links to dead slaves to prevent dead links.
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14074/
-----------------------------------------------------------
(Updated Sept. 13, 2013, 11:18 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-650
https://issues.apache.org/jira/browse/MESOS-650
Repository: mesos-git
Description (updated)
-------
Hid links to dead slaves to prevent dead links.
If a slave is gone, the framework page will print "Slave gone" in place
of the links to the slave's UI. The links would previously fail in
redirection and return the user to the Mesos root page, which is
unpleasant.
Fixes: https://issues.apache.org/jira/browse/MESOS-650
Review: http://reviews.apache.org/r/14074
Diffs (updated)
-----
src/webui/master/static/framework.html 1973cbed6759d0f007816377319a17c7e91a182d
Diff: https://reviews.apache.org/r/14074/diff/
Testing
-------
Ran tasks on a slave, killed the slave, and rendered the framework page. The links were replaced with "Slave gone".
Thanks,
Ross Allen
Re: Review Request 14074: Hid links to dead slaves to prevent dead links.
Posted by Benjamin Mahler <bm...@twitter.com>.
Yep!
On Sep 13, 2013, at 7:19 PM, "Ross Allen" <ro...@mesosphe.re> wrote:
>
>
>> On Sept. 13, 2013, 8:57 p.m., Ben Mahler wrote:
>>> How about: "Slave offline"?
>
> I like it. "Slave offline" is a better description. I updated the diff with the new text.
>
> Good to ship?
>
>
> - Ross
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14074/#review26097
> -----------------------------------------------------------
>
>
> On Sept. 13, 2013, 11:18 p.m., Ross Allen wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/14074/
>> -----------------------------------------------------------
>>
>> (Updated Sept. 13, 2013, 11:18 p.m.)
>>
>>
>> Review request for mesos and Ben Mahler.
>>
>>
>> Bugs: MESOS-650
>> https://issues.apache.org/jira/browse/MESOS-650
>>
>>
>> Repository: mesos-git
>>
>>
>> Description
>> -------
>>
>> Hid links to dead slaves to prevent dead links.
>>
>> If a slave is gone, the framework page will print "Slave gone" in place
>> of the links to the slave's UI. The links would previously fail in
>> redirection and return the user to the Mesos root page, which is
>> unpleasant.
>>
>> Fixes: https://issues.apache.org/jira/browse/MESOS-650
>>
>> Review: http://reviews.apache.org/r/14074
>>
>>
>> Diffs
>> -----
>>
>> src/webui/master/static/framework.html 1973cbed6759d0f007816377319a17c7e91a182d
>>
>> Diff: https://reviews.apache.org/r/14074/diff/
>>
>>
>> Testing
>> -------
>>
>> Ran tasks on a slave, killed the slave, and rendered the framework page. The links were replaced with "Slave gone".
>>
>>
>> Thanks,
>>
>> Ross Allen
>
Re: Review Request 14074: Hid links to dead slaves to prevent dead links.
Posted by Ross Allen <ro...@mesosphe.re>.
> On Sept. 13, 2013, 8:57 p.m., Ben Mahler wrote:
> > How about: "Slave offline"?
I like it. "Slave offline" is a better description. I updated the diff with the new text.
Good to ship?
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14074/#review26097
-----------------------------------------------------------
On Sept. 13, 2013, 11:18 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14074/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 11:18 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-650
> https://issues.apache.org/jira/browse/MESOS-650
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Hid links to dead slaves to prevent dead links.
>
> If a slave is gone, the framework page will print "Slave gone" in place
> of the links to the slave's UI. The links would previously fail in
> redirection and return the user to the Mesos root page, which is
> unpleasant.
>
> Fixes: https://issues.apache.org/jira/browse/MESOS-650
>
> Review: http://reviews.apache.org/r/14074
>
>
> Diffs
> -----
>
> src/webui/master/static/framework.html 1973cbed6759d0f007816377319a17c7e91a182d
>
> Diff: https://reviews.apache.org/r/14074/diff/
>
>
> Testing
> -------
>
> Ran tasks on a slave, killed the slave, and rendered the framework page. The links were replaced with "Slave gone".
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 14074: Hid links to dead slaves to prevent dead links.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14074/#review26097
-----------------------------------------------------------
Ship it!
How about: "Slave offline"?
- Ben Mahler
On Sept. 11, 2013, 1:40 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14074/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2013, 1:40 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-650
> https://issues.apache.org/jira/browse/MESOS-650
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Hid links to dead slaves to prevent dead links.
>
> If a slave is gone, the framework page will print "Slave gone" in place
> of the links to the slave's UI. The links would previously fail in
> redirection and return the user to the Mesos root page, which is
> unpleasant.
>
> Fixes: https://issues.apache.org/jira/browse/MESOS-650
>
>
> Diffs
> -----
>
> src/webui/master/static/framework.html 1973cbed6759d0f007816377319a17c7e91a182d
>
> Diff: https://reviews.apache.org/r/14074/diff/
>
>
> Testing
> -------
>
> Ran tasks on a slave, killed the slave, and rendered the framework page. The links were replaced with "Slave gone".
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 14074: Hid links to dead slaves to prevent dead links.
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14074/
-----------------------------------------------------------
(Updated Sept. 11, 2013, 1:40 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-650
https://issues.apache.org/jira/browse/MESOS-650
Repository: mesos-git
Description
-------
Hid links to dead slaves to prevent dead links.
If a slave is gone, the framework page will print "Slave gone" in place
of the links to the slave's UI. The links would previously fail in
redirection and return the user to the Mesos root page, which is
unpleasant.
Fixes: https://issues.apache.org/jira/browse/MESOS-650
Diffs
-----
src/webui/master/static/framework.html 1973cbed6759d0f007816377319a17c7e91a182d
Diff: https://reviews.apache.org/r/14074/diff/
Testing (updated)
-------
Ran tasks on a slave, killed the slave, and rendered the framework page. The links were replaced with "Slave gone".
Thanks,
Ross Allen