You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/11/11 12:18:06 UTC
[GitHub] [ozone] rakeshadr opened a new pull request #2830: Remove OMKeyRequest#getBucketLayout overridden method in subclasses
rakeshadr opened a new pull request #2830:
URL: https://github.com/apache/ozone/pull/2830
## What changes were proposed in this pull request?
As part of HDDS-5929, bucketlayout is an object variable in OmKeyRequest and will be initialized in the constructor. With this change, its not required to override the OmKeyRequest#getBucketLayout() method in all its FSO sub classes. This task will refactor and remove the overriding of #getBucketLayout().
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5970
## How was this patch tested?
Existing test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a change in pull request #2830: HDDS-5970. Remove OMKeyRequest#getBucketLayout overridden method in subclasses
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on a change in pull request #2830:
URL: https://github.com/apache/ozone/pull/2830#discussion_r747678148
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileInterfacesWithFSO.java
##########
@@ -18,47 +18,29 @@
package org.apache.hadoop.fs.ozone;
-import org.apache.hadoop.hdds.conf.OzoneConfiguration;
-import org.apache.hadoop.ozone.om.OMConfigKeys;
-import org.apache.hadoop.ozone.om.request.TestOMRequestUtils;
+import org.apache.hadoop.ozone.om.helpers.BucketLayout;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import java.io.IOException;
-import java.util.Arrays;
-import java.util.Collection;
/**
* Test OzoneFileSystem Interfaces - prefix layout.
*
* This test will test the various interfaces i.e.
- * create, read, write, getFileStatus
+ * create, read,ra write, getFileStatus
Review comment:
Yes, its a mistake. I've reverted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on pull request #2830: HDDS-5970. Remove OMKeyRequest#getBucketLayout overridden method in subclasses
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #2830:
URL: https://github.com/apache/ozone/pull/2830#issuecomment-966474230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aryangupta1998 commented on a change in pull request #2830: HDDS-5970. Remove OMKeyRequest#getBucketLayout overridden method in subclasses
Posted by GitBox <gi...@apache.org>.
aryangupta1998 commented on a change in pull request #2830:
URL: https://github.com/apache/ozone/pull/2830#discussion_r747661426
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileInterfacesWithFSO.java
##########
@@ -18,47 +18,29 @@
package org.apache.hadoop.fs.ozone;
-import org.apache.hadoop.hdds.conf.OzoneConfiguration;
-import org.apache.hadoop.ozone.om.OMConfigKeys;
-import org.apache.hadoop.ozone.om.request.TestOMRequestUtils;
+import org.apache.hadoop.ozone.om.helpers.BucketLayout;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import java.io.IOException;
-import java.util.Arrays;
-import java.util.Collection;
/**
* Test OzoneFileSystem Interfaces - prefix layout.
*
* This test will test the various interfaces i.e.
- * create, read, write, getFileStatus
+ * create, read,ra write, getFileStatus
Review comment:
Is this a typing mistake? Can we revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr merged pull request #2830: HDDS-5970. Remove OMKeyRequest#getBucketLayout overridden method in subclasses
Posted by GitBox <gi...@apache.org>.
rakeshadr merged pull request #2830:
URL: https://github.com/apache/ozone/pull/2830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aryangupta1998 commented on pull request #2830: HDDS-5970. Remove OMKeyRequest#getBucketLayout overridden method in subclasses
Posted by GitBox <gi...@apache.org>.
aryangupta1998 commented on pull request #2830:
URL: https://github.com/apache/ozone/pull/2830#issuecomment-966455468
Thanks, @rakeshadr for the patch!
Overall the patch looks good to me +1. Adding a few minor comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org