You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2018/11/03 21:02:00 UTC

[jira] [Commented] (HIVE-20850) Push case conditional from projections to dimension tables if possible

    [ https://issues.apache.org/jira/browse/HIVE-20850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674206#comment-16674206 ] 

Hive QA commented on HIVE-20850:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12946748/HIVE-20850.01.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14731/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14731/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14731/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-11-03 21:00:26.489
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-14731/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-11-03 21:00:26.492
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at ae1eb15 HIVE-20778: Join reordering may not be triggered if all joins in plan are created by decorrelation logic (Vineet Garg via Jesus Camacho Rodriguez)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at ae1eb15 HIVE-20778: Join reordering may not be triggered if all joins in plan are created by decorrelation logic (Vineet Garg via Jesus Camacho Rodriguez)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-11-03 21:00:27.167
+ rm -rf ../yetus_PreCommit-HIVE-Build-14731
+ mkdir ../yetus_PreCommit-HIVE-Build-14731
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-14731
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-14731/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:2065
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java' cleanly.
error: patch failed: ql/src/test/results/clientpositive/perf/tez/cbo_query15.q.out:49
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/perf/tez/cbo_query15.q.out' with conflicts.
Going to apply patch with: git apply -p0
/data/hiveptest/working/scratch/build.patch:219: trailing whitespace.
  group by ss_store_sk, 
/data/hiveptest/working/scratch/build.patch:226: trailing whitespace.
           from (select ss_item_sk item_sk,avg(ss_net_profit) rank_col 
/data/hiveptest/working/scratch/build.patch:250: trailing whitespace.
where asceding.rnk = descending.rnk 
/data/hiveptest/working/scratch/build.patch:5119: trailing whitespace.
  group by ss_store_sk, 
/data/hiveptest/working/scratch/build.patch:5130: trailing whitespace.
  group by ss_store_sk, 
error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:2065
Falling back to three-way merge...
Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java' cleanly.
error: patch failed: ql/src/test/results/clientpositive/perf/tez/cbo_query15.q.out:49
Falling back to three-way merge...
Applied patch to 'ql/src/test/results/clientpositive/perf/tez/cbo_query15.q.out' with conflicts.
U ql/src/test/results/clientpositive/perf/tez/cbo_query15.q.out
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-14731
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12946748 - PreCommit-HIVE-Build

> Push case conditional from projections to dimension tables if possible
> ----------------------------------------------------------------------
>
>                 Key: HIVE-20850
>                 URL: https://issues.apache.org/jira/browse/HIVE-20850
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>         Attachments: HIVE-20850.01.patch, HIVE-20850.01.patch, HIVE-20850.01.patch
>
>
> noticed by [~gopalv]: If there is a project which could be only evaluated after the join; but the condition references only a single column from a small dimension table; hive will end up evaluating the same thing over and over again...
> {code}
> explain
> select  s_store_name, s_store_id,
>         sum(case when (d_day_name='Sunday') then ss_sales_price else null end) sun_sales,
>         sum(case when (d_day_name='Monday') then ss_sales_price else null end) mon_sales,
>         sum(case when (d_day_name='Tuesday') then ss_sales_price else  null end) tue_sales,
>         sum(case when (d_day_name='Wednesday') then ss_sales_price else null end) wed_sales,
>         sum(case when (d_day_name='Thursday') then ss_sales_price else null end) thu_sales,
>         sum(case when (d_day_name='Friday') then ss_sales_price else null end) fri_sales,
>         sum(case when (d_day_name='Saturday') then ss_sales_price else null end) sat_sales
>  from date_dim, store_sales, store
>  where d_date_sk = ss_sold_date_sk and
>        s_store_sk = ss_store_sk and
>        s_gmt_offset = -6 and
>        d_year = 1998 
>  group by s_store_name, s_store_id
>  order by s_store_name, s_store_id,sun_sales,mon_sales,tue_sales,wed_sales,thu_sales,fri_sales,sat_sales
>  limit 100;
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)