[GitHub] [incubator-openwhisk-deploy-kube] dgrove-oss commented on a change in pull request #494: Support Pod Disruption Budget

[GitBox <gi...@apache.org>]

dgrove-oss commented on a change in pull request #494: Support Pod Disruption Budget
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/494#discussion_r301589189
 
 

 ##########
 File path: helm/openwhisk/values-metadata.yaml
 ##########
 @@ -1560,4 +1560,24 @@ metrics:
       description: "true to enable user metrics"
       type: "boolean"
       required: true
+pdb:
+  _metadata:
+  label: "Pod's disruption budget settings"
+  description: "Pod Disruption settings for voluntary and nonvoluntary disruptions"
+  enable:
+    _metadata:
+      label: "Enable pod disruption budget for deployment"
+      description: "true to enable pod disruption budgets for pods"
+      type: "boolean"
+      required: true
+  component:
 
 Review comment:
   The tool that processes values-metadata.yaml won't understand the pattern you are describing here by using `component`.   I think the choices are either (a) replicate the component name & maxUnavailable stanza for each component (zookeeper, controller, etc.) that you have defined in values.yaml or (b) leave off the entries in values-metadata.yaml.    I'm fine with either option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services