You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/18 11:09:00 UTC

[jira] [Commented] (NIFI-4175) Add Proxy Properties to SFTP Processors

    [ https://issues.apache.org/jira/browse/NIFI-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091412#comment-16091412 ] 

ASF GitHub Bot commented on NIFI-4175:
--------------------------------------

GitHub user trixpan opened a pull request:

    https://github.com/apache/nifi/pull/2018

    NIFI-4175 - Add HTTP proxy support to *SFTP processors

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [] Have you written or updated unit tests to verify your changes?
    - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [X] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [X] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/trixpan/nifi NIFI-4175

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2018.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2018
    
----
commit fc93aefd3351c939b06e83db77c89ce0957d025f
Author: Andre F de Miranda <tr...@users.noreply.github.com>
Date:   2017-07-18T11:04:48Z

    NIFI-4175 - Add HTTP proxy support to *SFTP processors

----


> Add Proxy Properties to SFTP Processors
> ---------------------------------------
>
>                 Key: NIFI-4175
>                 URL: https://issues.apache.org/jira/browse/NIFI-4175
>             Project: Apache NiFi
>          Issue Type: New Feature
>            Reporter: Grant Langlois
>            Priority: Minor
>
> Add proxy server configuration as properties to the Nifi SFTP components. Specifically add properties for:
> Proxy Type: JSCH supported proxies including SOCKS4, SOCKS5 and HTTP
> Proxy Host
> Proxy Port
> Proxy Username
> Proxy Password
> This would allow these properties to be configured for each processor. These properties would align with what is configurable for the JSCH session and shouldn't require any additional dependencies.
> This proposal is similar to what is already implemented for the FTP processors



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)