[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #137: some pekko naming issues

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #137:
URL: https://github.com/apache/incubator-pekko-http/pull/137#discussion_r1169754163


##########
build.sbt:
##########
@@ -405,11 +405,11 @@ lazy val docs = project("docs")
       "scaladoc.org.apache.pekko.base_url" -> s"https://pekko.apache.org/api/pekko/${PekkoDependency.docs.link}",
       "scaladoc.org.apache.pekko.link_style" -> "direct",
       "javadoc.org.apache.pekko.http.base_url" -> {
-        val v = if (!isSnapshot.value) "current" else version.value
+        val v = if (isSnapshot.value) "current" else version.value

Review Comment:
   The boolean expression seems wrong. Builds for snapshots are getting the full snapshot version string here. Everything else for snapshot builds uses 'current'. I agree that for non-snapshot builds, having the version number makes sense - but that's not what this expression is doing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org