You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/04 10:23:09 UTC
Review Request 64294: Renamed `ACKNOWLEDGE_PUBLISH` to
`UPDATE_PUBLISH_STATUS`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64294/
-----------------------------------------------------------
Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.
Repository: mesos
Description
-------
Renamed the call for naming consistency with other API calls. Also
fixed its protobuf definition in the V1 API.
Diffs
-----
include/mesos/resource_provider/resource_provider.proto 615a2ab8a00f4da3906ad0ae322a885c84b3574b
include/mesos/v1/resource_provider/resource_provider.proto 7197b9ba3f761d618e5d67662a5f3fba72701ef0
src/resource_provider/manager.cpp c37553d22375400a52928e26de7db5b599fd0873
src/resource_provider/validation.cpp 75556c05de4878e66e937bc18838a6a56b5c1f73
Diff: https://reviews.apache.org/r/64294/diff/1/
Testing
-------
make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64294: Renamed `ACKNOWLEDGE_PUBLISH` to
`UPDATE_PUBLISH_STATUS`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64294/#review192713
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 4, 2017, 10:23 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64294/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 10:23 a.m.)
>
>
> Review request for mesos, Jie Yu, Joseph Wu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed the call for naming consistency with other API calls. Also
> fixed its protobuf definition in the V1 API.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 615a2ab8a00f4da3906ad0ae322a885c84b3574b
> include/mesos/v1/resource_provider/resource_provider.proto 7197b9ba3f761d618e5d67662a5f3fba72701ef0
> src/resource_provider/manager.cpp c37553d22375400a52928e26de7db5b599fd0873
> src/resource_provider/validation.cpp 75556c05de4878e66e937bc18838a6a56b5c1f73
>
>
> Diff: https://reviews.apache.org/r/64294/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>