You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/09/29 16:29:10 UTC
[GitHub] [sling-org-apache-sling-engine] cziegeler opened a new pull request #21: SLING-8742 : Allow overriding the extension when using the RequestDis…
cziegeler opened a new pull request #21:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/21
…patcher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] rombert commented on a change in pull request #21: SLING-8742 : Allow overriding the extension when using the RequestDis…
Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #21:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/21#discussion_r719150003
##########
File path: pom.xml
##########
@@ -128,7 +128,7 @@
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.auth.core</artifactId>
- <version>1.0.0</version>
+ <version>1.5.4</version>
Review comment:
Out of curiosity, why do we need to increase the version for the auth.core and fileupload dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] cziegeler merged pull request #21: SLING-8742 : Allow overriding the extension when using the RequestDis…
Posted by GitBox <gi...@apache.org>.
cziegeler merged pull request #21:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] cziegeler commented on a change in pull request #21: SLING-8742 : Allow overriding the extension when using the RequestDis…
Posted by GitBox <gi...@apache.org>.
cziegeler commented on a change in pull request #21:
URL: https://github.com/apache/sling-org-apache-sling-engine/pull/21#discussion_r719169760
##########
File path: pom.xml
##########
@@ -128,7 +128,7 @@
<dependency>
<groupId>org.apache.sling</groupId>
<artifactId>org.apache.sling.auth.core</artifactId>
- <version>1.0.0</version>
+ <version>1.5.4</version>
Review comment:
The used versions were outdated and there are security issues reported against them. So I updated them to avoid getting automated security reports. Not really related to this issue but doesn't really change anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org