You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@hbase.apache.org by lars hofhansl <lh...@yahoo.com> on 2011/08/06 04:01:51 UTC

hbase shell broken in truck (with simple patch)

I noticed in HBase trunk I always get this error in the shell:

ERROR: undefined method `getRecoverableZookeeper' for #<Java::OrgApacheHadoopHbaseZookeeper::ZooKeeperWatcher:0x1c904f75>


This is apparently caused by HBASE-3065. The fix is trivial:

Index: src/main/ruby/hbase/admin.rb
===================================================================
--- src/main/ruby/hbase/admin.rb        (revision 1154413)
+++ src/main/ruby/hbase/admin.rb        (working copy)
@@ -30,7 +30,7 @@
       @admin = org.apache.hadoop.hbase.client.HBaseAdmin.new(configuration)
       connection = @admin.getConnection()
       @zk_wrapper = connection.getZooKeeperWatcher()
-      zk = @zk_wrapper.getZooKeeper()
+      zk = @zk_wrapper.getRecoverableZooKeeper().getZooKeeper()
       @zk_main = org.apache.zookeeper.ZooKeeperMain.new(zk)
       @formatter = formatter
     end

Should I open an issue and add the patch there?

Thanks.

-- Lars


Re: hbase shell broken in trunk (with simple patch)

Posted by lars hofhansl <lh...@yahoo.com>.
Created HBASE-4171 and attached the fix there.



----- Original Message -----
From: Gary Helmling <gh...@gmail.com>
To: user@hbase.apache.org; lars hofhansl <lh...@yahoo.com>
Cc: 
Sent: Friday, August 5, 2011 7:04 PM
Subject: Re: hbase shell broken in truck (with simple patch)

Thanks Lars.  That's a remnant of HBASE-3065.

Yes please open an issue with the patch.  We'll get it in.


On Fri, Aug 5, 2011 at 7:01 PM, lars hofhansl <lh...@yahoo.com> wrote:

> I noticed in HBase trunk I always get this error in the shell:
>
> ERROR: undefined method `getRecoverableZookeeper' for
> #<Java::OrgApacheHadoopHbaseZookeeper::ZooKeeperWatcher:0x1c904f75>
>
>
> This is apparently caused by HBASE-3065. The fix is trivial:
>
> Index: src/main/ruby/hbase/admin.rb
> ===================================================================
> --- src/main/ruby/hbase/admin.rb        (revision 1154413)
> +++ src/main/ruby/hbase/admin.rb        (working copy)
> @@ -30,7 +30,7 @@
>        @admin =
> org.apache.hadoop.hbase.client.HBaseAdmin.new(configuration)
>        connection = @admin.getConnection()
>        @zk_wrapper = connection.getZooKeeperWatcher()
> -      zk = @zk_wrapper.getZooKeeper()
> +      zk = @zk_wrapper.getRecoverableZooKeeper().getZooKeeper()
>        @zk_main = org.apache.zookeeper.ZooKeeperMain.new(zk)
>        @formatter = formatter
>      end
>
> Should I open an issue and add the patch there?
>
> Thanks.
>
> -- Lars
>
>


Re: hbase shell broken in truck (with simple patch)

Posted by Gary Helmling <gh...@gmail.com>.
Thanks Lars.  That's a remnant of HBASE-3065.

Yes please open an issue with the patch.  We'll get it in.


On Fri, Aug 5, 2011 at 7:01 PM, lars hofhansl <lh...@yahoo.com> wrote:

> I noticed in HBase trunk I always get this error in the shell:
>
> ERROR: undefined method `getRecoverableZookeeper' for
> #<Java::OrgApacheHadoopHbaseZookeeper::ZooKeeperWatcher:0x1c904f75>
>
>
> This is apparently caused by HBASE-3065. The fix is trivial:
>
> Index: src/main/ruby/hbase/admin.rb
> ===================================================================
> --- src/main/ruby/hbase/admin.rb        (revision 1154413)
> +++ src/main/ruby/hbase/admin.rb        (working copy)
> @@ -30,7 +30,7 @@
>        @admin =
> org.apache.hadoop.hbase.client.HBaseAdmin.new(configuration)
>        connection = @admin.getConnection()
>        @zk_wrapper = connection.getZooKeeperWatcher()
> -      zk = @zk_wrapper.getZooKeeper()
> +      zk = @zk_wrapper.getRecoverableZooKeeper().getZooKeeper()
>        @zk_main = org.apache.zookeeper.ZooKeeperMain.new(zk)
>        @formatter = formatter
>      end
>
> Should I open an issue and add the patch there?
>
> Thanks.
>
> -- Lars
>
>

Re: hbase shell broken in trunk (with simple patch)

Posted by lars hofhansl <lh...@yahoo.com>.
Err... It did say 

ERROR: undefined method `getZooKeeper' for #<Java::OrgApacheHadoopHbaseZookeeper::ZooKeeperWatcher:0x1c904f75>

Pasted the wrong message. Also fixed subject.


----- Original Message -----
From: lars hofhansl <lh...@yahoo.com>
To: "user@hbase.apache.org" <us...@hbase.apache.org>
Cc: 
Sent: Friday, August 5, 2011 7:01 PM
Subject: hbase shell broken in truck (with simple patch)

I noticed in HBase trunk I always get this error in the shell:

ERROR: undefined method `getRecoverableZookeeper' for #<Java::OrgApacheHadoopHbaseZookeeper::ZooKeeperWatcher:0x1c904f75>


This is apparently caused by HBASE-3065. The fix is trivial:

Index: src/main/ruby/hbase/admin.rb
===================================================================
--- src/main/ruby/hbase/admin.rb        (revision 1154413)
+++ src/main/ruby/hbase/admin.rb        (working copy)
@@ -30,7 +30,7 @@
       @admin = org.apache.hadoop.hbase.client.HBaseAdmin.new(configuration)
       connection = @admin.getConnection()
       @zk_wrapper = connection.getZooKeeperWatcher()
-      zk = @zk_wrapper.getZooKeeper()
+      zk = @zk_wrapper.getRecoverableZooKeeper().getZooKeeper()
       @zk_main = org.apache.zookeeper.ZooKeeperMain.new(zk)
       @formatter = formatter
     end

Should I open an issue and add the patch there?

Thanks.

-- Lars