[GitHub] log4net pull request #32: Implement log4net.Extensions.Logging extension for...

[jasonwilliams200OK <gi...@git.apache.org>]

GitHub user jasonwilliams200OK opened a pull request:

    https://github.com/apache/log4net/pull/32

    Implement log4net.Extensions.Logging extension for aspnet core

    ### Add extension source project - 1ff39f9
    Created extension package at: `extensions/log4net.Extensions.Logging/log4net.Extensions.Logging`
    
    Note that for the moment until log4net v3 is released (with .NET Core support), we have `"log4net": { "target": "project" },` in project.json. After that this will be changed to `"log4net": "3.0.0",` or `"log4net": "3.0.0-*",` (if some preview is released before the v3 RTM).
    
    ### Add test web app for asp extension - 11a0ec1
    Added test project (web app) at: `extensions/log4net.Extensions.Logging/log4net.Extensions.Logging.Test`
    
    The test web app was simply created by `dotnet new -t web` with addition of `"log4net.Extensions.Logging": { "target": "project" }` in project.json, then extension usage in `Startup.cs` and a sample log4net settings file at `Settings/logconfig.xml`.
    
    To build and run test web app:
    
    ```sh
    # this script works in Unix shell or Windows PowerShell
    # for Windows Command Prompt use backslashes in `cd` command
    
    git clone https://github.com/jasonwilliams200OK/log4net --single-branch -b feature/asp-logging-extension
    cd log4net
    
    # restore package
    dotnet restore
    
    # build dependencies, web app and run the web app
    cd extensions/log4net.Extensions.Logging/log4net.Extensions.Logging.Test
    dotnet run
    ```
    
    Then open localhost:5000 in the browser and logs should appear in the console.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jasonwilliams200OK/log4net feature/asp-logging-extension

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/log4net/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit 1ff39f995031ff39bf0f3797a4f3e2040ad2b1bb
Author: Peter Jas <ne...@yahoo.com>
Date:   2016-08-21T00:14:53Z

    Add extension source project

commit 11a0ec15a9c578587314d508adc4d062d6a9c001
Author: Peter Jas <ne...@yahoo.com>
Date:   2016-08-21T00:51:56Z

    Add test web app for asp extension

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---