You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/08/16 08:50:53 UTC
[GitHub] zeppelin pull request #3144: [ZEPPELIN-3723] Pre-Loader for Zeppelin UI
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3144
[ZEPPELIN-3723] Pre-Loader for Zeppelin UI
### What is this PR for?
Given the size of vendor.js (2.6MB) alone, and the project has various other CSS and JS as well.
I think it makes sense to have a pre-loader screen if in case Zeppelin was running behind a slow network/proxy.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-3723](https://issues.apache.org/jira/browse/ZEPPELIN-3723)
### How should this be tested?
* Check Screenshots
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3723
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3144
----
commit 19dfe900db07eda17b89168bf68e1b95ce9551f1
Author: Prabhjyot Singh <pr...@...>
Date: 2018-08-16T08:46:39Z
ZEPPELIN-3723: Pre-Loader for Zeppelin UI
Change-Id: Ic4290933a07ce510aee8f765b8bb1cc8c4cb92ca
----
---
[GitHub] zeppelin issue #3144: [ZEPPELIN-3723] Pre-Loader for Zeppelin UI
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3144
@jongyoul Let me try to find/optimize for that (reduce our whole fe size) as well if I find something will open up a new JIRA for the same.
---
[GitHub] zeppelin issue #3144: [ZEPPELIN-3723] Pre-Loader for Zeppelin UI
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3144
Thanks for the review will merge this if no more discussion.
---
[GitHub] zeppelin issue #3144: [ZEPPELIN-3723] Pre-Loader for Zeppelin UI
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3144
@zjffdu @r-kamath Can you help review this.
---
[GitHub] zeppelin issue #3144: [ZEPPELIN-3723] Pre-Loader for Zeppelin UI
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3144
It makes sense to me. BTW, is there any way to reduce our whole fe size?
---
[GitHub] zeppelin issue #3144: [ZEPPELIN-3723] Pre-Loader for Zeppelin UI
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3144
@r-kamath Sure, I've aligned color with Zeppelin's background and header color and updated the description to reflect the latest screenshot.
---
[GitHub] zeppelin pull request #3144: [ZEPPELIN-3723] Pre-Loader for Zeppelin UI
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3144
---