You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Craig Longman <cr...@begeek.com> on 2003/02/21 21:17:36 UTC
svn: system(' svn-commit.tmp') returned 32512
i'm having some trouble getting svn to work. i am using the following:
svn, version 0.18.0 (r4973)
compiled Feb 21 2003, 01:17:30
i was able to create a repository, issue an import command, as well as
checkout and status commands. but if i ever try and do a svn commit, i
get the following:
sh: svn-commit.tmp: command not found
svn: Error calling external program
svn: Commit failed (details follow):
svn: system(' svn-commit.tmp') returned 32512
i cannot find anything on the net to help me resolve this problem, and i
have no idea what i should do next to test things out. it souinds like
a svn-commit.tmp file is created and then executed for me, is there some
way of getting that file to hang around instead of being deleted?
CraigL->Thx();
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn: system(' svn-commit.tmp') returned 32512
Posted by David Kimdon <dw...@debian.org>.
On Fri, Feb 21, 2003 at 10:36:22PM +0000, Philip Martin wrote:
> Ben Collins-Sussman <su...@collab.net> writes:
>
> It's the SVN_CLIENT_EDITOR stuff David Kimdon added in rev 4812. If I
> configure without using --with-editor=PATH then I get
ouch, sorry about that bug, thanks for cleaning up my mess. Now I've
got my filter to flag messages with the words 'Kimdon' in it so in the
future I can respond more quickly.
-David
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn: system(' svn-commit.tmp') returned 32512
Posted by Philip Martin <ph...@codematters.co.uk>.
Ben Collins-Sussman <su...@collab.net> writes:
> Wow, we have genuine regression bug. I just unset EDITOR on my
> FreeBSD box, and instead of seeing the usual error about "you must use
> -F, -m or set EDITOR", I get the same error as you:
>
> svn: Error calling external program
> svn: Commit failed (details follow):
> subversion/clients/cmdline/util.c:201: (apr_err=200012)
> svn: system(' svn-commit.tmp') returned 32512
It's the SVN_CLIENT_EDITOR stuff David Kimdon added in rev 4812. If I
configure without using --with-editor=PATH then I get
#define SVN_CLIENT_EDITOR ""
in svn_private_config.h and svn_cl__edit_externally has
#ifdef SVN_CLIENT_EDITOR
if (! editor)
editor = SVN_CLIENT_EDITOR;
#endif
Is it possible to have configure not generate the #define? Or do we
need another pre-processor symbol SVN_CLIENT_EDITOR_ENABLED?
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn: system(' svn-commit.tmp') returned 32512
Posted by Philip Martin <ph...@codematters.co.uk>.
Matt Kraai <kr...@alumni.cmu.edu> writes:
> Would someone please
> test and, if the tests are successful, apply the following patch?
Works for me with and without --with-editor. Applied in rev 5011.
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn: system(' svn-commit.tmp') returned 32512
Posted by Matt Kraai <kr...@alumni.cmu.edu>.
On Fri, Feb 21, 2003 at 04:02:26PM -0800, Ben Collins-Sussman wrote:
> Craig Longman <cr...@begeek.com> writes:
>
> > actually, the EDITOR was not set (i'm running bash on linux), but if i
> > _provide_ an EDITOR or a -m then it works great! fwiw, the output
> > from not having EDITOR set and having EDITOR set to "" appears to be
> > identical.
>
> Wow, we have genuine regression bug. I just unset EDITOR on my
> FreeBSD box, and instead of seeing the usual error about "you must use
> -F, -m or set EDITOR", I get the same error as you:
>
> svn: Error calling external program
> svn: Commit failed (details follow):
> subversion/clients/cmdline/util.c:201: (apr_err=200012)
> svn: system(' svn-commit.tmp') returned 32512
>
> Subversion should *not* be trying to run system(EDITOR) if the
> variable is undefined.
If --with-editor is not passed to configure, SVN_CLIENT_EDITOR is set
to the empty string, which becomes the default. Would someone please
test and, if the tests are successful, apply the following patch?
Index: configure.in
===================================================================
--- configure.in (revision 5009)
+++ configure.in (working copy)
@@ -282,12 +282,12 @@
AC_MSG_ERROR([--with-editor requires an argument.])
else
SVN_CLIENT_EDITOR=$withval
+ AC_DEFINE_UNQUOTED(SVN_CLIENT_EDITOR, "$SVN_CLIENT_EDITOR",
+ [The path of a default editor for the client.])
+
fi
])
-
-AC_DEFINE_UNQUOTED(SVN_CLIENT_EDITOR, "$SVN_CLIENT_EDITOR",
- [Define to the path of a default editor for the client.])
MOD_ACTIVATION="-a"
AC_ARG_ENABLE(mod-activation,
Matt
--
Oink!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: editor variable empty (was: Re: svn: system(' svn-commit.tmp') returned 32512)
Posted by Benjamin Pflugmann <be...@pflugmann.de>.
On Sat 2003-02-22 at 01:40:58 +0100, I wrote:
[...]
> Just wanted to let you know, that I cannot reproduce this using r5011
> on Linux:
Argh! Ignore that. Just saw that 5011 was the fix.
Sorry about the noice, but my mail lagged behind...
Bye,
Benjamin.
editor variable empty (was: Re: svn: system(' svn-commit.tmp') returned 32512)
Posted by Benjamin Pflugmann <be...@pflugmann.de>.
Hi.
On Fri 2003-02-21 at 16:02:26 -0800, Ben Collins-Sussman wrote:
> Craig Longman <cr...@begeek.com> writes:
>
> > actually, the EDITOR was not set (i'm running bash on linux), but if i
> > _provide_ an EDITOR or a -m then it works great! fwiw, the output
> > from not having EDITOR set and having EDITOR set to "" appears to be
> > identical.
>
> Wow, we have genuine regression bug. I just unset EDITOR on my
> FreeBSD box, and instead of seeing the usual error about "you must use
> -F, -m or set EDITOR", I get the same error as you:
>
> svn: Error calling external program
> svn: Commit failed (details follow):
> subversion/clients/cmdline/util.c:201: (apr_err=200012)
> svn: system(' svn-commit.tmp') returned 32512
>
> Subversion should *not* be trying to run system(EDITOR) if the
> variable is undefined.
>
> Should we file this bug?
Just wanted to let you know, that I cannot reproduce this using r5011
on Linux:
> env -u EDITOR -u SVN_EDITOR -u VISUAL bash
$ svn ci
subversion/libsvn_client/commit.c:670: (apr_err=205007)
svn: No external editor available
svn: Commit failed (details follow):
subversion/clients/cmdline/util.c:484: (apr_err=205007)
svn: Could not use external editor to fetch log message; consider setting the $SVN_EDITOR environment variable or using the --message (-m) or --file (-F) options.
subversion/clients/cmdline/util.c:117: (apr_err=205007)
svn: None of the environment variables SVN_EDITOR, VISUAL or EDITOR is set, and no 'editor-cmd' run-time configuration option was found.
That's the expected error, AFAICT. I also had a look at the source
(subversion/clients/cmdline/util.c) and it checks for the result of
editor being NULL, which would be the result from getenv() when a
variable is not set (from man getenv):
The getenv() function returns a pointer to the value in the environ-
ment, or NULL if there is no match.
Just for completness, I do get the same error as you, if I set one of
the variables to the empty string. One can argue if Subversion should
check for that case, too.
So if I had to guess, I would have a look whether SVN_EDITOR or VISUAL
are set to an empty string or if the editor is set in Subversion's
config file that way.
Bye,
Benjamin.
Re: svn: system(' svn-commit.tmp') returned 32512
Posted by Ben Collins-Sussman <su...@collab.net>.
Craig Longman <cr...@begeek.com> writes:
> actually, the EDITOR was not set (i'm running bash on linux), but if i
> _provide_ an EDITOR or a -m then it works great! fwiw, the output
> from not having EDITOR set and having EDITOR set to "" appears to be
> identical.
Wow, we have genuine regression bug. I just unset EDITOR on my
FreeBSD box, and instead of seeing the usual error about "you must use
-F, -m or set EDITOR", I get the same error as you:
svn: Error calling external program
svn: Commit failed (details follow):
subversion/clients/cmdline/util.c:201: (apr_err=200012)
svn: system(' svn-commit.tmp') returned 32512
Subversion should *not* be trying to run system(EDITOR) if the
variable is undefined.
Should we file this bug?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn: system(' svn-commit.tmp') returned 32512
Posted by Craig Longman <cr...@begeek.com>.
Ben Collins-Sussman wrote:
>Craig Longman <cr...@begeek.com> writes:
>
>
>
>>i'm having some trouble getting svn to work. i am using the following:
>>
>> svn, version 0.18.0 (r4973)
>> compiled Feb 21 2003, 01:17:30
>>
>>i was able to create a repository, issue an import command, as well as
>>checkout and status commands. but if i ever try and do a svn commit,
>>i get the following:
>>
>> sh: svn-commit.tmp: command not found
>> svn: Error calling external program
>> svn: Commit failed (details follow):
>> svn: system(' svn-commit.tmp') returned 32512
>>
>>
>
>A commit requires a log message.
>
>It seems like your $EDITOR variable is set to "", judging by the
>system() call there.
>
>
actually, the EDITOR was not set (i'm running bash on linux), but if i
_provide_ an EDITOR or a -m then it works great! fwiw, the output from
not having EDITOR set and having EDITOR set to "" appears to be identical.
thanks a lot.
CraigL->Thx();
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn: system(' svn-commit.tmp') returned 32512
Posted by Ben Collins-Sussman <su...@collab.net>.
Craig Longman <cr...@begeek.com> writes:
> i'm having some trouble getting svn to work. i am using the following:
>
> svn, version 0.18.0 (r4973)
> compiled Feb 21 2003, 01:17:30
>
> i was able to create a repository, issue an import command, as well as
> checkout and status commands. but if i ever try and do a svn commit,
> i get the following:
>
> sh: svn-commit.tmp: command not found
> svn: Error calling external program
> svn: Commit failed (details follow):
> svn: system(' svn-commit.tmp') returned 32512
A commit requires a log message.
It seems like your $EDITOR variable is set to "", judging by the
system() call there.
Set that variable, or unset it.
Or use -m or -F to set a log message.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org