[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

[mike-jumper <gi...@git.apache.org>]

Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/181#discussion_r182205125
  
    --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectAuthenticationProvider.java ---
    @@ -0,0 +1,56 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.guacamole.auth.quickconnect;
    +
    +import org.apache.guacamole.GuacamoleException;
    +import org.apache.guacamole.net.auth.AuthenticatedUser;
    +import org.apache.guacamole.net.auth.AbstractAuthenticationProvider;
    +import org.apache.guacamole.net.auth.UserContext;
    +
    +/**
    + * Class providing the necessary hooks into the Guacamole Client authentication
    + * process so that the QuickConnect functionality can be initialized and be used
    + * throughout the web client.
    + */
    +public class QuickConnectAuthenticationProvider extends AbstractAuthenticationProvider {
    +
    +    /**
    +     * userContext for this authentication provider.
    +     */
    +    private UserContext userContext;
    +
    +    @Override
    +    public String getIdentifier() {
    +        return "quickconnect";
    +    }
    +
    +    @Override
    +    public UserContext getUserContext(AuthenticatedUser authenticatedUser)
    +            throws GuacamoleException {
    +
    +        if (userContext == null)
    +            userContext = new QuickConnectUserContext(this,
    +                    authenticatedUser.getIdentifier());
    --- End diff --
    
    As a single instance of each `AuthenticationProvider` is maintained for all users, maintaining a reference to a single `UserContext` at the `AuthenticationProvider` level will mean that all users share the same data. In this case, this seems odd since the `UserContext` is being explicitly initialized for the current `AuthenticatedUser`.


---