You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/12 22:08:27 UTC
[kudu-CR] tidy: enable rule for constant naming
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7158
to review the following change.
Change subject: tidy: enable rule for constant naming
......................................................................
tidy: enable rule for constant naming
This enables the rule that constants should be named kFooBar and fixes
the cases where we didn't adhere to this. The fixes were started using
clang-tidy --fix, but it wasn't very good at finding all references, so
I did some by-hand tweaking to get it to compile after that.
I left a few aberrations in gutil, etc, but this should be at least a
good cleanup.
Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
---
M src/kudu/.clang-tidy
M src/kudu/cfile/type_encodings.cc
M src/kudu/client/meta_cache.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
M src/kudu/gutil/strings/escaping.cc
M src/kudu/gutil/strings/substitute.cc
M src/kudu/gutil/strings/substitute.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/master/master.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/request_tracker-test.cc
M src/kudu/rpc/request_tracker.cc
M src/kudu/rpc/request_tracker.h
M src/kudu/rpc/retriable_rpc.h
M src/kudu/security/ca/cert_management.cc
M src/kudu/security/cert.cc
M src/kudu/security/crypto.cc
M src/kudu/security/openssl_util.h
M src/kudu/security/openssl_util_bio.h
M src/kudu/security/tls_context.cc
M src/kudu/server/pprof-path-handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/tablet/all_types-scan-correctness-test.cc
M src/kudu/tablet/cbtree-test.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tserver/tablet_server.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.h
M src/kudu/util/mem_tracker-test.cc
M src/kudu/util/os-util.cc
M src/kudu/util/process_memory.cc
M src/kudu/util/rle-test.cc
M src/kudu/util/trace.h
35 files changed, 183 insertions(+), 179 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/7158/1
--
To view, visit http://gerrit.cloudera.org:8080/7158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] tidy: enable rule for constant naming
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: tidy: enable rule for constant naming
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] tidy: enable rule for constant naming
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: tidy: enable rule for constant naming
......................................................................
tidy: enable rule for constant naming
This enables the rule that constants should be named kFooBar and fixes
the cases where we didn't adhere to this. The fixes were started using
clang-tidy --fix, but it wasn't very good at finding all references, so
I did some by-hand tweaking to get it to compile after that.
I left a few aberrations in gutil, etc, but this should be at least a
good cleanup.
Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Reviewed-on: http://gerrit.cloudera.org:8080/7158
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/.clang-tidy
M src/kudu/cfile/type_encodings.cc
M src/kudu/client/meta_cache.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
M src/kudu/gutil/strings/escaping.cc
M src/kudu/gutil/strings/substitute.cc
M src/kudu/gutil/strings/substitute.h
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/master/master.cc
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/request_tracker-test.cc
M src/kudu/rpc/request_tracker.cc
M src/kudu/rpc/request_tracker.h
M src/kudu/rpc/retriable_rpc.h
M src/kudu/security/ca/cert_management.cc
M src/kudu/security/cert.cc
M src/kudu/security/crypto.cc
M src/kudu/security/openssl_util.h
M src/kudu/security/openssl_util_bio.h
M src/kudu/security/tls_context.cc
M src/kudu/server/pprof-path-handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/tablet/all_types-scan-correctness-test.cc
M src/kudu/tablet/cbtree-test.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tserver/tablet_server.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.h
M src/kudu/util/mem_tracker-test.cc
M src/kudu/util/os-util.cc
M src/kudu/util/process_memory.cc
M src/kudu/util/rle-test.cc
M src/kudu/util/trace.h
35 files changed, 183 insertions(+), 179 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7971659ef3152580d44d6ddfb18be7ebf41052c7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>